From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B46B9C41514 for ; Fri, 2 Aug 2019 19:26:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88B902086A for ; Fri, 2 Aug 2019 19:26:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="byi/JLB7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404767AbfHBT0l (ORCPT ); Fri, 2 Aug 2019 15:26:41 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:17220 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404439AbfHBT0l (ORCPT ); Fri, 2 Aug 2019 15:26:41 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 02 Aug 2019 12:26:41 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 02 Aug 2019 12:26:39 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 02 Aug 2019 12:26:39 -0700 Received: from [10.2.171.217] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Aug 2019 19:26:39 +0000 Subject: Re: [PATCH 20/34] xen: convert put_page() to put_user_page*() To: "Weiny, Ira" , Juergen Gross , "john.hubbard@gmail.com" , Andrew Morton CC: "devel@driverdev.osuosl.org" , Dave Chinner , Christoph Hellwig , "Williams, Dan J" , "x86@kernel.org" , "linux-mm@kvack.org" , Dave Hansen , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rpi-kernel@lists.infradead.org" , "devel@lists.orangefs.org" , "xen-devel@lists.xenproject.org" , Boris Ostrovsky , "rds-devel@oss.oracle.com" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , "ceph-devel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , LKML , "linux-media@vger.kernel.org" , "linux-nfs@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "netdev@vger.kernel.org" , "sparclinux@vger.kernel.org" , Jason Gunthorpe References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-21-jhubbard@nvidia.com> <4471e9dc-a315-42c1-0c3c-55ba4eeeb106@suse.com>

<2807E5FD2F6FDA4886F6618EAC48510E79E66216@CRSMSX101.amr.corp.intel.com> In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E79E66216@CRSMSX101.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Weiny, Ira" , Juergen Gross , "john.hubbard@gmail.com" , Andrew Morton Cc: "devel@driverdev.osuosl.org" , Dave Chinner , Christoph Hellwig , "Williams, Dan J" , "x86@kernel.org" , "linux-mm@kvack.org" , Dave Hansen , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rpi-kernel@lists.infradead.org" , "devel@lists.orangefs.org" , "xen-devel@lists.xenproject.org" On 8/2/19 9:09 AM, Weiny, Ira wrote: >> >> On 02.08.19 07:48, John Hubbard wrote: >>> On 8/1/19 9:36 PM, Juergen Gross wrote: >>>> On 02.08.19 04:19, john.hubbard@gmail.com wrote: >>>>> From: John Hubbard >>> ... >>> If that's not the case (both here, and in 3 or 4 other patches in this >>> series, then as you said, I should add NULL checks to put_user_pages() >>> and put_user_pages_dirty_lock(). >> >> In this case it is not correct, but can easily be handled. The NULL case can >> occur only in an error case with the pages array filled partially or not at all. >> >> I'd prefer something like the attached patch here. > > I'm not an expert in this code and have not looked at it carefully but that patch does seem to be the better fix than forcing NULL checks on everyone. > OK, I'll use Juergen's approach, and also check for that pattern in the other patches. thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH 20/34] xen: convert put_page() to put_user_page*() Date: Fri, 2 Aug 2019 12:25:01 -0700 Message-ID: <746b2412-f48a-9722-2763-253a1b9c899d@nvidia.com> References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-21-jhubbard@nvidia.com> <4471e9dc-a315-42c1-0c3c-55ba4eeeb106@suse.com>

<2807E5FD2F6FDA4886F6618EAC48510E79E66216@CRSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E79E66216@CRSMSX101.amr.corp.intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: "Weiny, Ira" , Juergen Gross , "john.hubbard@gmail.com" , Andrew Morton Cc: "devel@driverdev.osuosl.org" , Dave Chinner , Christoph Hellwig , "Williams, Dan J" , "x86@kernel.org" , "linux-mm@kvack.org" , Dave Hansen , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rpi-kernel@lists.infradead.org" , "devel@lists.orangefs.org" , "xen-devel@lists.xenproject.org" List-Id: ceph-devel.vger.kernel.org On 8/2/19 9:09 AM, Weiny, Ira wrote: >> >> On 02.08.19 07:48, John Hubbard wrote: >>> On 8/1/19 9:36 PM, Juergen Gross wrote: >>>> On 02.08.19 04:19, john.hubbard@gmail.com wrote: >>>>> From: John Hubbard >>> ... >>> If that's not the case (both here, and in 3 or 4 other patches in this >>> series, then as you said, I should add NULL checks to put_user_pages() >>> and put_user_pages_dirty_lock(). >> >> In this case it is not correct, but can easily be handled. The NULL case can >> occur only in an error case with the pages array filled partially or not at all. >> >> I'd prefer something like the attached patch here. > > I'm not an expert in this code and have not looked at it carefully but that patch does seem to be the better fix than forcing NULL checks on everyone. > OK, I'll use Juergen's approach, and also check for that pattern in the other patches. thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 From: jhubbard@nvidia.com (John Hubbard) Date: Fri, 2 Aug 2019 12:25:01 -0700 Subject: [PATCH 20/34] xen: convert put_page() to put_user_page*() In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E79E66216@CRSMSX101.amr.corp.intel.com> References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-21-jhubbard@nvidia.com> <4471e9dc-a315-42c1-0c3c-55ba4eeeb106@suse.com>

<2807E5FD2F6FDA4886F6618EAC48510E79E66216@CRSMSX101.amr.corp.intel.com> Message-ID: <746b2412-f48a-9722-2763-253a1b9c899d@nvidia.com> List-Id: Linux Driver Project Developer List On 8/2/19 9:09 AM, Weiny, Ira wrote: >> >> On 02.08.19 07:48, John Hubbard wrote: >>> On 8/1/19 9:36 PM, Juergen Gross wrote: >>>> On 02.08.19 04:19, john.hubbard@gmail.com wrote: >>>>> From: John Hubbard >>> ... >>> If that's not the case (both here, and in 3 or 4 other patches in this >>> series, then as you said, I should add NULL checks to put_user_pages() >>> and put_user_pages_dirty_lock(). >> >> In this case it is not correct, but can easily be handled. The NULL case can >> occur only in an error case with the pages array filled partially or not at all. >> >> I'd prefer something like the attached patch here. > > I'm not an expert in this code and have not looked at it carefully but that patch does seem to be the better fix than forcing NULL checks on everyone. > OK, I'll use Juergen's approach, and also check for that pattern in the other patches. thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DB5C433FF for ; Fri, 2 Aug 2019 19:27:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D0492086A for ; Fri, 2 Aug 2019 19:27:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mR59RZf9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="byi/JLB7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D0492086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mGhv+4URlVHuss16kSYv0DJSaEgL9VfWeCpzmMOe9yY=; b=mR59RZf9phkas8cjH+OC09avq WINpdFvPisYdMUb0tElyzGVSPN5UA2267h2cR347evw8C6TBdJPSy0DIuaSZ3IJC1TfHBJzmx5K4c HRVlUP2whcZdke2Ywan2+n9WKKaJDyXNJ++42Cb3luit9o/8rf9ZfN3pM5z4Hdsg2zQ8YIaZoTT5h iNKKUlQXMNe7y+gY2sOtmYKLKhQu++1BBRWPyH6k4hgT0n88iB2/6mnQajnb8YbWBf3fxRBzyX43L wu+D4veY4ohfJl3bTmR6bk06qi5iRFv1dJUWB0nuOEQQJDYePX2V/oJlyyhlK71w6B99W9N6z50lg /6JgL/v0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htdCW-0006Iz-1d; Fri, 02 Aug 2019 19:26:52 +0000 Received: from hqemgate14.nvidia.com ([216.228.121.143]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1htdCK-0005z4-8p; Fri, 02 Aug 2019 19:26:41 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 02 Aug 2019 12:26:41 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 02 Aug 2019 12:26:39 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 02 Aug 2019 12:26:39 -0700 Received: from [10.2.171.217] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Aug 2019 19:26:39 +0000 Subject: Re: [PATCH 20/34] xen: convert put_page() to put_user_page*() To: "Weiny, Ira" , Juergen Gross , "john.hubbard@gmail.com" , Andrew Morton References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-21-jhubbard@nvidia.com> <4471e9dc-a315-42c1-0c3c-55ba4eeeb106@suse.com>

<2807E5FD2F6FDA4886F6618EAC48510E79E66216@CRSMSX101.amr.corp.intel.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: <746b2412-f48a-9722-2763-253a1b9c899d@nvidia.com> Date: Fri, 2 Aug 2019 12:25:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E79E66216@CRSMSX101.amr.corp.intel.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1564774001; bh=rRhheBqnK3+cjDjuz6CHnpsz5YflbO5z8PXp1A2YK5w=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=byi/JLB7CNtV06561y8XoJ3SAPfLWvMAReG7pbHQL4vyYMWIeKNh0N7pvRnXFQG1L qdrcKeqyYLdfyHlBvNt3iltX04f4l9yslTmpDdtWvq1t3b7bkuO+rrbkZHys+WsmhV 6Aa9W+8qQAz5X83c7tyDcDc6Mg36wKOuzq27pabbfn+69ez0SBMHEuaNtlKh20Fcaj gTip6LdymKj+uFDjnVTxb7sYVNWRS9rebCu5gBiFOf/CT8TUXKtD/8+Sk9b10OKO7l 1Y0kk6maXEh1JdSy6qqRDc1JYyIdeVQu9Kdnt4cKXn6PzYq3IXSks/FI+pwJb3dRVj 9ZhtT6T5hfRNQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190802_122640_394983_A4405912 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-fbdev@vger.kernel.org" , Jan Kara , "kvm@vger.kernel.org" , Boris Ostrovsky , Dave Hansen , Dave Chinner , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "sparclinux@vger.kernel.org" , "Williams, Dan J" , "devel@driverdev.osuosl.org" , "rds-devel@oss.oracle.com" , "linux-rdma@vger.kernel.org" , "x86@kernel.org" , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Jason Gunthorpe , "xen-devel@lists.xenproject.org" , "devel@lists.orangefs.org" , "linux-media@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "linux-block@vger.kernel.org" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , "linux-rpi-kernel@lists.infradead.org" , "ceph-devel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-nfs@vger.kernel.org" , "netdev@vger.kernel.org" , LKML , "linux-xfs@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/2/19 9:09 AM, Weiny, Ira wrote: >> >> On 02.08.19 07:48, John Hubbard wrote: >>> On 8/1/19 9:36 PM, Juergen Gross wrote: >>>> On 02.08.19 04:19, john.hubbard@gmail.com wrote: >>>>> From: John Hubbard >>> ... >>> If that's not the case (both here, and in 3 or 4 other patches in this >>> series, then as you said, I should add NULL checks to put_user_pages() >>> and put_user_pages_dirty_lock(). >> >> In this case it is not correct, but can easily be handled. The NULL case can >> occur only in an error case with the pages array filled partially or not at all. >> >> I'd prefer something like the attached patch here. > > I'm not an expert in this code and have not looked at it carefully but that patch does seem to be the better fix than forcing NULL checks on everyone. > OK, I'll use Juergen's approach, and also check for that pattern in the other patches. thanks, -- John Hubbard NVIDIA _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3143EC32750 for ; Fri, 2 Aug 2019 19:27:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3B532086A for ; Fri, 2 Aug 2019 19:27:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="byi/JLB7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3B532086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1htdCW-00085X-8f; Fri, 02 Aug 2019 19:26:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1htdCV-00085S-HL for xen-devel@lists.xenproject.org; Fri, 02 Aug 2019 19:26:51 +0000 X-Inumbo-ID: 73ecc2ae-b55b-11e9-9edd-4782ea6b1ebb Received: from hqemgate14.nvidia.com (unknown [216.228.121.143]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 73ecc2ae-b55b-11e9-9edd-4782ea6b1ebb; Fri, 02 Aug 2019 19:26:40 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 02 Aug 2019 12:26:41 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 02 Aug 2019 12:26:39 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 02 Aug 2019 12:26:39 -0700 Received: from [10.2.171.217] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Aug 2019 19:26:39 +0000 To: "Weiny, Ira" , Juergen Gross , "john.hubbard@gmail.com" , Andrew Morton References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-21-jhubbard@nvidia.com> <4471e9dc-a315-42c1-0c3c-55ba4eeeb106@suse.com>