From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09416C10F12 for ; Wed, 17 Apr 2019 06:36:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE0682073F for ; Wed, 17 Apr 2019 06:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729774AbfDQGgy (ORCPT ); Wed, 17 Apr 2019 02:36:54 -0400 Received: from mga18.intel.com ([134.134.136.126]:49764 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbfDQGgy (ORCPT ); Wed, 17 Apr 2019 02:36:54 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 23:36:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="165434092" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.198]) ([10.237.72.198]) by fmsmga001.fm.intel.com with ESMTP; 16 Apr 2019 23:36:51 -0700 Subject: Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects To: Jiri Olsa , Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Andi Kleen , Song Liu , Alexei Starovoitov , Daniel Borkmann References: <20190416160127.30203-1-jolsa@kernel.org> <20190416160127.30203-12-jolsa@kernel.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <746f02e3-a509-5081-8427-b610e52c1fb0@intel.com> Date: Wed, 17 Apr 2019 09:35:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190416160127.30203-12-jolsa@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/19 7:01 PM, Jiri Olsa wrote: > The eBPF program can be loaded multiple times > with the same name (tag). We can share dso > objects for those programs. Doesn't a eBPF program get recompiled differently every time it is loaded? > > Link: http://lkml.kernel.org/n/tip-3damf8vq1dryhtpbk5b06jpt@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/machine.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index d4aa44489011..a60653827891 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -23,6 +23,7 @@ > #include "linux/hash.h" > #include "asm/bug.h" > #include "bpf-event.h" > +#include "dso.h" > > #include "sane_ctype.h" > #include > @@ -699,11 +700,18 @@ static int machine__process_ksymbol_register(struct machine *machine, > > map = map_groups__find(&machine->kmaps, event->ksymbol_event.addr); > if (!map) { > - map = dso__new_map(event->ksymbol_event.name); > - if (!map) > + struct dso *dso; > + > + dso = dsos__findnew(&machine->dsos, event->ksymbol_event.name); > + if (!dso) > return -ENOMEM; > > - map->start = event->ksymbol_event.addr; > + map = map__new2(event->ksymbol_event.addr, dso); > + if (!map) { > + dso__put(dso); > + return -ENOMEM; > + } > + > map->end = map->start + event->ksymbol_event.len; > map_groups__insert(&machine->kmaps, map); > } >