From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Russkikh Subject: Re: [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access Date: Mon, 8 Oct 2018 17:10:21 +0300 Message-ID: <747f70d8-303a-aeea-2359-26b03a5e0336@aquantia.com> References: <6b4837b970d7709bc2e11d89a7e21e5f10584e30.1538734658.git.igor.russkikh@aquantia.com> <1539006774.10342.16.camel@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Dmitry Bezrukov , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" To: Oliver Neukum , "David S . Miller" Return-path: Received: from mail-eopbgr680065.outbound.protection.outlook.com ([40.107.68.65]:63744 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726056AbeJHVdR (ORCPT ); Mon, 8 Oct 2018 17:33:17 -0400 In-Reply-To: <1539006774.10342.16.camel@suse.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi Oliver, >> + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_MAJOR, >> + 1, 1, &aqc111_data->fw_ver.major); >> + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_MINOR, >> + 1, 1, &aqc111_data->fw_ver.minor); >> + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_REV, >> + 1, 1, &aqc111_data->fw_ver.rev); > > Why read the stuff you don't need? fw_ver is used below to determine phy access mode. fw_ver.rev is not used in this exact patch, thats true, but it gets reported in later patches in the set. Regards, Igor From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [net-next,05/19] net: usb: aqc111: Introduce PHY access From: Igor Russkikh Message-Id: <747f70d8-303a-aeea-2359-26b03a5e0336@aquantia.com> Date: Mon, 8 Oct 2018 17:10:21 +0300 To: Oliver Neukum , "David S . Miller" Cc: Dmitry Bezrukov , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" List-ID: SGkgT2xpdmVyLAoKPj4gKwlhcWMxMTFfcmVhZF9jbWQoZGV2LCBBUV9BQ0NFU1NfTUFDLCBBUV9G V19WRVJfTUFKT1IsCj4+ICsJCQkxLCAxLCAmYXFjMTExX2RhdGEtPmZ3X3Zlci5tYWpvcik7Cj4+ ICsJYXFjMTExX3JlYWRfY21kKGRldiwgQVFfQUNDRVNTX01BQywgQVFfRldfVkVSX01JTk9SLAo+ PiArCQkJMSwgMSwgJmFxYzExMV9kYXRhLT5md192ZXIubWlub3IpOwo+PiArCWFxYzExMV9yZWFk X2NtZChkZXYsIEFRX0FDQ0VTU19NQUMsIEFRX0ZXX1ZFUl9SRVYsCj4+ICsJCQkxLCAxLCAmYXFj MTExX2RhdGEtPmZ3X3Zlci5yZXYpOwo+IAo+IFdoeSByZWFkIHRoZSBzdHVmZiB5b3UgZG9uJ3Qg bmVlZD8KCmZ3X3ZlciBpcyB1c2VkIGJlbG93IHRvIGRldGVybWluZSBwaHkgYWNjZXNzIG1vZGUu Cgpmd192ZXIucmV2IGlzIG5vdCB1c2VkIGluIHRoaXMgZXhhY3QgcGF0Y2gsIHRoYXRzIHRydWUs CmJ1dCBpdCBnZXRzIHJlcG9ydGVkIGluIGxhdGVyIHBhdGNoZXMgaW4gdGhlIHNldC4KClJlZ2Fy ZHMsCiAgSWdvcgo=