All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dean Camera <dean@fourwalledcubicle.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] Increase HID_MAX_BUFFER_SIZE to 8KB to support additional, devices.
Date: Thu, 26 Nov 2020 09:26:55 +1100	[thread overview]
Message-ID: <74873fa6-0234-b642-adb3-62683671222a@fourwalledcubicle.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2011251412230.3441@cbobk.fhfr.pm>

Sure, I'll do that now (and do the same for my other unreviewed patch, 
which adds additional ioctls(). It's suprisingly frustratingly difficult 
to get Thunderbird to send a one-time unformatted plain-text email, as 
it seems to be a global setting that has to be changed.

I've given up on that and just set up git-send-email, which I've never 
used before but hope doesn't mangle anything.

Cheers!
- Dean

On 26/11/2020 12:12 am, Jiri Kosina wrote:
> On Wed, 18 Nov 2020, Dean Camera wrote:
> 
>> Currently the maximum HID report size which can be buffered by the
>> kernel is 8KB. This is sufficient for the vast majority of HID
>> devices on the market, as most HID reports are fairly small.
>>
>> However, some unusual devices such as the Elgate Stream Deck exist
>> which use a report size slightly over 8KB for the image data that
>> is sent to the device. Reports these large cannot be buffered by
>> the regular HID subsystem currently, thus the only way to use such
>> device is to bypass the HID subsystem entirely.
>>
>> This increases the maximum HID report size to 16KB, which should
>> cover all sanely designed HID devices.
>>
>> Signed-off-by: Dean Camera <dean@fourwalledcubicle.com>
> 
> Dean,
> 
> thanks for the patch.
> 
> It has been whitespace-damaged by your mail client though. Could you
> please fix that and resubmit?
> 

  reply	other threads:[~2020-11-25 22:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <acdda6f0-3675-7e8b-b57c-711fe8199ce9@fourwalledcubicle.com>
2020-11-25 13:12 ` [PATCH 1/2] Increase HID_MAX_BUFFER_SIZE to 8KB to support additional, devices Jiri Kosina
2020-11-25 22:26   ` Dean Camera [this message]
2020-11-25 22:42     ` Dean Camera
2020-11-19  5:55 Dean Camera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74873fa6-0234-b642-adb3-62683671222a@fourwalledcubicle.com \
    --to=dean@fourwalledcubicle.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.