From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED From: Lars-Peter Clausen Message-Id: <748ffc14-de12-c11e-eb12-65c599fe5f4e@metafoo.de> Date: Fri, 27 Apr 2018 08:53:39 +0200 To: Vinod Koul , Moritz Fischer Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com List-ID: T24gMDQvMjcvMjAxOCAwNzoxMSBBTSwgVmlub2QgS291bCB3cm90ZToKPiBPbiBUaHUsIEFwciAy NiwgMjAxOCBhdCAxMDo0MDowMEFNIC0wNzAwLCBNb3JpdHogRmlzY2hlciB3cm90ZToKPj4gUmVx dWVzdCBJUlEgd2l0aCBJUlFGX1NIQVJFRCBmbGFnLiBUaGlzIHdvcmtzIHNpbmNlIHRoZSBpbnRl cnJ1cHQKPj4gaGFuZGxlciBhbHJlYWR5IGNoZWNrcyBpZiB0aGVyZSBpcyBhbiBhY3R1YWwgSVJR IHBlbmRpbmcgYW5kIHJldHVybnMKPj4gSVJRX05PTkUgb3RoZXJ3aXNlLgo+IAo+IGhtbW0gd2hh dCBhcmUgd2UgdHJ5aW5nIHRvIGZpeCBoZXJlPyBJcyB5b3VyIGRldmljZSBvbiBhIHNoYXJlZCBs aW5lIG9yIG5vdD8KCklSUUZfU0hBUkVEIGRvZXMgbm90IG1lYW4gdGhhdCB0aGUgSVJRIGlzIG9u IGEgc2hhcmVkIGxpbmUuIEl0IG1lYW5zIHRoYXQKdGhlIGRyaXZlciBjYW4gaGFuZGxlIGl0IGlm IHRoZSBJUlEgaXMgb24gYSBzaGFyZWQgbGluZS4gU2luY2UgdGhlIGRyaXZlcgpjYW4gaGFuZGxl IGl0IHNldHRpbmcgdGhlIGZsYWcgaXMgYSBnb29kIGlkZWEgc2luY2UgdGhpcyBlbmFibGVzIHVz ZWNhc2VzCndoZXJlIHRoZSBsaW5lIGlzIHNoYXJlZC4KCj4gCj4+Cj4+IEFja2VkLWJ5OiBMYXJz LVBldGVyIENsYXVzZW4gPGxhcnNAbWV0YWZvby5kZT4KPj4gU2lnbmVkLW9mZi1ieTogTW9yaXR6 IEZpc2NoZXIgPG1kZkBrZXJuZWwub3JnPgo+PiAtLS0KPj4gQ2hhbmdlcyBmcm9tIHYxOgo+PiAt IEFkZGVkIExhcnMnIEFja2VkLWJ5Cj4+IC0gRHJvcHBlZCBwYXRjaCBbMS8yXSBhbmQgY2hhbmdl ZCBhY2NvcmRpbmdseQo+PiAtLS0KPj4gIGRyaXZlcnMvZG1hL2RtYS1heGktZG1hYy5jIHwgMiAr LQo+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS9kbWEtYXhpLWRtYWMuYyBiL2RyaXZlcnMvZG1hL2Rt YS1heGktZG1hYy5jCj4+IGluZGV4IDI0MTlmZTUyNGRhYS4uMTViMjQ1M2QyNjQ3IDEwMDY0NAo+ PiAtLS0gYS9kcml2ZXJzL2RtYS9kbWEtYXhpLWRtYWMuYwo+PiArKysgYi9kcml2ZXJzL2RtYS9k bWEtYXhpLWRtYWMuYwo+PiBAQCAtNjg3LDcgKzY4Nyw3IEBAIHN0YXRpYyBpbnQgYXhpX2RtYWNf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4gIAlpZiAocmV0KQo+PiAgCQln b3RvIGVycl91bnJlZ2lzdGVyX2RldmljZTsKPj4gIAo+PiAtCXJldCA9IHJlcXVlc3RfaXJxKGRt YWMtPmlycSwgYXhpX2RtYWNfaW50ZXJydXB0X2hhbmRsZXIsIDAsCj4+ICsJcmV0ID0gcmVxdWVz dF9pcnEoZG1hYy0+aXJxLCBheGlfZG1hY19pbnRlcnJ1cHRfaGFuZGxlciwgSVJRRl9TSEFSRUQs Cj4+ICAJCWRldl9uYW1lKCZwZGV2LT5kZXYpLCBkbWFjKTsKPj4gIAlpZiAocmV0KQo+PiAgCQln b3RvIGVycl91bnJlZ2lzdGVyX29mOwo+PiAtLSAKPj4gMi4xNy4wCj4+Cj4KLS0tClRvIHVuc3Vi c2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBkbWFlbmdp bmUiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3Jn Ck1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21v LWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757468AbeD0Gxw (ORCPT ); Fri, 27 Apr 2018 02:53:52 -0400 Received: from www381.your-server.de ([78.46.137.84]:42786 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757381AbeD0Gxv (ORCPT ); Fri, 27 Apr 2018 02:53:51 -0400 Subject: Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED To: Vinod Koul , Moritz Fischer Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com References: <20180426174000.12008-1-mdf@kernel.org> <20180427051115.GX6014@localhost> From: Lars-Peter Clausen Message-ID: <748ffc14-de12-c11e-eb12-65c599fe5f4e@metafoo.de> Date: Fri, 27 Apr 2018 08:53:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180427051115.GX6014@localhost> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/2018 07:11 AM, Vinod Koul wrote: > On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote: >> Request IRQ with IRQF_SHARED flag. This works since the interrupt >> handler already checks if there is an actual IRQ pending and returns >> IRQ_NONE otherwise. > > hmmm what are we trying to fix here? Is your device on a shared line or not? IRQF_SHARED does not mean that the IRQ is on a shared line. It means that the driver can handle it if the IRQ is on a shared line. Since the driver can handle it setting the flag is a good idea since this enables usecases where the line is shared. > >> >> Acked-by: Lars-Peter Clausen >> Signed-off-by: Moritz Fischer >> --- >> Changes from v1: >> - Added Lars' Acked-by >> - Dropped patch [1/2] and changed accordingly >> --- >> drivers/dma/dma-axi-dmac.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c >> index 2419fe524daa..15b2453d2647 100644 >> --- a/drivers/dma/dma-axi-dmac.c >> +++ b/drivers/dma/dma-axi-dmac.c >> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev) >> if (ret) >> goto err_unregister_device; >> >> - ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0, >> + ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED, >> dev_name(&pdev->dev), dmac); >> if (ret) >> goto err_unregister_of; >> -- >> 2.17.0 >> >