From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bajor.fuzziesquirrel.com (mail.fuzziesquirrel.com [173.167.31.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vVKJH6KckzDqGv for ; Sat, 25 Feb 2017 05:24:31 +1100 (AEDT) X-Virus-Scanned: amavisd-new at fuzziesquirrel.com Sender: bradleyb@fuzziesquirrel.com Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: Target name refactoring From: Brad Bishop In-Reply-To: Date: Fri, 24 Feb 2017 13:24:26 -0500 Cc: OpenBMC Maillist Content-Transfer-Encoding: quoted-printable Message-Id: <74BF93A2-A512-4EDF-BECF-86FCE40B2615@fuzziesquirrel.com> References: <45AAA114-D2B4-4B75-8485-B4B7F4AFD989@fuzziesquirrel.com> To: Rick Altherr X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 18:24:32 -0000 > On Feb 24, 2017, at 11:41 AM, Rick Altherr = wrote: >=20 > nit: stop is a verb. Stopped is a state. Right. So using one of the conventions below we=E2=80=99d have either: obmc-stop-host obmc-host-stopped or obmc-host-stop obmc-host-stopped I=E2=80=99m guessing the first person to reply with a preference will = probably win. >=20 > On Feb 24, 2017 5:59 AM, "Brad Bishop" = wrote: >=20 > > On Feb 21, 2017, at 10:00 PM, Joel Stanley wrote: > > > > On Tue, Feb 21, 2017 at 8:50 AM, Andrew Geissler = wrote: > >> Some design decisions came out of my last set of changes in the > >> OpenBMC state area. There was a proposal to rename our targets > >> responsible for booting and powering on/off the system. > >> > >> Currently we have this: > >> - PowerOn: obmc-power-chassis-on.target = obmc-chassis-start.target > >> - PowerOff: obmc-power-chassis-off.target = obmc-chassis-stop.target > >> obmc-stop-host.target > >> > >> The obmc-power-chassis-*.targets are responsible for doing whatever = is > >> required to apply pgood to the chassis. > >> The obmc-chassis-*.targets are responsible for starting and = stopping > >> all host related services > >> The obmc-stop-host.target is where we have the soft power off = service > >> (notify host of shutdown, wait for host to shutdown gracefully) > >> > >> Refactoring Proposal: > >> - First the chassis-start and chassis-stop target names don=E2=80=99t= make > >> sense anymore with the new bmc, chassis, and host state break = down=E2=80=99s > >> so: > >> - Rename obmc-chassis-start.target to obmc-start-host.target > >> - Rename obmc-chassis-stop.target to obmc-stop-host.target > >> - Rename the current obmc-stop-host.target to = obmc-shutdown-host.target > > > > Can I suggest putting the host before the action? > > > > obmc-host-stop > > obmc-host-start > > obmc-host-shutdown >=20 > We have two types of targets, synchronization targets (for example = network-pre.target), > and action targets(for example multi-user.target). Sync targets are = not directly > start/stoppable - they have to be started implicitly by systemd. I = would like a way > to be able to tell which one I am looking at from the name. For = example: >=20 > obmc-stop-host # Action - stop the host. > obmc-host-stop # Sync - the host has been stopped. >=20 > I had proposed this obmc-[verb]-[what] for actions and = obmc-[what]-[state] to Andrew > privately..I=E2=80=99m fine with something else, again, as long as it = is consistent. >=20 > I can think of two conventions: >=20 > obmc-[verb]-[what] for actions > obmc-[what]-[state] for sync points >=20 > or >=20 > obmc-[what]-[verb] for actions > obmc-[what]-[state] for sync points >=20 > Either one is fine with me. The former seems slightly easier to = distinguish between > the two. >=20 > > > >> > >> The target relationships are then the following: > >> > >> obmc-host-start.target requires obmc-power-chassis-on.target > >> obmc-shutdown-host.target requires obmc-stop-host.target requires > >> obmc-power-chassis-off.target > > > > obmc-host-start requires obmc-chassis-poweron > > > > obmc-host-shutdown requires obmc-host-stop requires = obmc-chassis-poweroff > > > > I think the rest of your proposal sounds good, from what I = understand. > > > > Cheers, > > > > Joel > > > >> > >> When a system goes to the quiesce target, the host state manager = will > >> call the obmc-stop-host.target. Otherwise, the host state service > >> will call the obmc-shutdown-host.target when power off is = requested. > >> > >> Thoughts/Comments? > >> Andrew