All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@nvidia.com>
To: David Henningsson <david.henningsson@canonical.com>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>
Subject: Re: ALSA: hda: hdmi: Hint matching between input devices and pcm devices
Date: Tue, 23 Aug 2011 08:51:36 -0700	[thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04B24A3823@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <4E53C32E.9020801@canonical.com>

David Henningsson wrote at Tuesday, August 23, 2011 9:12 AM:
> Since modern HDMI cards often have more than one output pin and thus
> input device, we need to know which one has actually been plugged in.
> 
> This patch adds a name hint that indicates which PCM device is connected
> to which pin.
> 
> To do that, the jack creation has been deferred to build_controls, i e,
> after the PCM devices have been created.
> 
> Would be great to have Stephen look through this patch quickly before
> it's committed.

Structurally, I think this looks OK. The only question I have is the 
string format:

"HDMI/DP (pcm %d)", pcmdev

* Is there a 1:1 mapping between the internal pcmdev numbers and what
alsa-lib presents to clients? Thinking about ALSA device numbering, it's
like "hw:1,3", so includes the card number too; should that be in the
string?

* Would it be better to make the string completely generic - i.e. not
include "HDMI/DP", but rather something like "ALSA PCM %d", or even
"ALSA PCM hw:%d,%d" so that the same format could be used for non-HDMI/
DP PCMs in the future?

-- 
nvpublic

  reply	other threads:[~2011-08-23 15:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23 15:11 ALSA: hda: hdmi: Hint matching between input devices and pcm devices David Henningsson
2011-08-23 15:51 ` Stephen Warren [this message]
2011-08-24  4:53   ` David Henningsson
2011-08-24 21:21     ` Stephen Warren
2011-08-25  7:13       ` David Henningsson
2011-08-25 17:41         ` Stephen Warren
2011-08-25 21:37           ` David Henningsson
2011-08-29 22:14             ` Pierre-Louis Bossart
2011-08-30  7:06               ` David Henningsson
2011-08-30  7:40               ` Clemens Ladisch
2011-08-30 13:01                 ` Pierre-Louis Bossart
     [not found]                 ` <000601cc6714$fc5caa80$f515ff80$@bossart@linux.intel.com>
2011-09-12  7:10                   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF04B24A3823@HQMAIL01.nvidia.com \
    --to=swarren@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.