From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] tegra: fdt: Add extra I2C definitions for U-Boot
Date: Mon, 26 Dec 2011 20:35:38 -0800 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF176CC74422@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <1324923111-340-3-git-send-email-sjg@chromium.org>
Simon Glass wrote at Monday, December 26, 2011 11:12 AM:
> Add U-Boot's peripheral ID and pinmux selection to the Tegra20
> device tree file.
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
...
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000C000 0x100>;
> interrupts = < 70 >;
> + u-boot,pinmux = <0>;
That isn't acceptable to me for the same reasons I've outline many
times before while discussing USB.
At least periph-id can be argued to be related to the HW, but the pinmux
value is a hack that really has no place in device tree.
> + speed = <100000>;
That's already defined as "clock-frequency" in the Linux kernel.
> + u-boot,periph-id = <12>; // PERIPH_ID_I2C1
--
nvpublic
next prev parent reply other threads:[~2011-12-27 4:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 18:11 [U-Boot] [PATCH 0/7] tegra: Add I2C driver and associated parts Simon Glass
2011-12-26 18:11 ` [U-Boot] [PATCH 1/7] tegra: Rename NV_PA_PMC_BASE to TEGRA2_PMC_BASE Simon Glass
2011-12-26 19:12 ` Marek Vasut
2012-01-09 21:34 ` Stephen Warren
2011-12-26 18:11 ` [U-Boot] [PATCH 2/7] tegra: fdt: Add extra I2C definitions for U-Boot Simon Glass
2011-12-26 19:12 ` Marek Vasut
2011-12-27 4:35 ` Stephen Warren [this message]
2011-12-27 5:15 ` Simon Glass
2011-12-29 6:40 ` Stephen Warren
2011-12-29 7:11 ` Simon Glass
2011-12-26 18:11 ` [U-Boot] [PATCH 3/7] tegra: Add I2C support to funcmux Simon Glass
2012-01-09 21:36 ` Stephen Warren
2012-01-09 21:40 ` Simon Glass
2012-01-09 22:56 ` Simon Glass
2011-12-26 18:11 ` [U-Boot] [PATCH 4/7] tegra: Add I2C driver Simon Glass
2011-12-26 19:15 ` Marek Vasut
2012-01-08 16:57 ` Simon Glass
2012-01-08 17:06 ` Marek Vasut
2012-01-08 18:16 ` Simon Glass
2012-01-08 5:57 ` Mike Frysinger
2012-01-08 16:46 ` Simon Glass
2012-01-09 22:07 ` Stephen Warren
2012-01-12 4:17 ` Simon Glass
2012-01-12 19:14 ` Stephen Warren
2012-01-13 7:12 ` Heiko Schocher
2012-01-13 14:49 ` Simon Glass
2012-01-13 15:27 ` Heiko Schocher
2012-02-03 23:18 ` Simon Glass
2011-12-26 18:11 ` [U-Boot] [PATCH 5/7] tegra: Initialise I2C on Nvidia boards Simon Glass
2011-12-26 18:11 ` [U-Boot] [PATCH 6/7] tegra: Select I2C ordering for Seaboard Simon Glass
2012-01-09 21:42 ` Stephen Warren
2011-12-26 18:11 ` [U-Boot] [PATCH 7/7] tegra: Enable I2C on Seaboard Simon Glass
2012-01-09 21:45 ` Stephen Warren
[not found] ` <CAPnjgZ3jTm6j-fK_Kn==W3uGr=8pREEWXawP39kojLzzSH07wQ@mail.gmail.com>
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17801D1D4A@HQMAIL01.nvidia.com>
2012-01-12 19:10 ` Simon Glass
2012-01-12 19:21 ` Stephen Warren
2012-01-12 19:28 ` Simon Glass
2012-01-13 7:34 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF176CC74422@HQMAIL01.nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.