From: "Souza, Jose" <jose.souza@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>
Cc: "Sripada, Radhakrishna" <radhakrishna.sripada@intel.com>,
"joonas.lahtinen@linux.intel.com"
<joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"Atwood, Matthew S" <matthew.s.atwood@intel.com>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add struct to hold IP version
Date: Wed, 20 Oct 2021 19:29:59 +0000 [thread overview]
Message-ID: <74cc5b4a8ebe2a5f7ae01994c6782124328a2e0e.camel@intel.com> (raw)
In-Reply-To: <87tuhcni3k.fsf@intel.com>
On Wed, 2021-10-20 at 12:47 +0300, Jani Nikula wrote:
> On Tue, 19 Oct 2021, José Roberto de Souza <jose.souza@intel.com> wrote:
> > The constant platform display version is not using this new struct but
> > the runtime variant will definitely use it.
>
> Cc: Some more folks to hijack this thread. Sorry! ;)
>
> We added runtime info to i915, because we had this idea and goal of
> turning the device info to a truly const pointer to the info structures
> in i915_pci.c that are stored in rodata. The idea was that we'll have a
> complete split of mutable and immutable device data, with all the
> mutable data in runtime info.
>
> Alas, we never got there. More and more data that was mostly const but
> sometimes needed tweaking kept piling up. mkwrite_device_info() was
> supposed to be a clue not to modify device info runtime, but instead it
> proliferated. Now we have places like intel_fbc_init() disabling FBC
> through that. But most importantly, we have fusing that considerably
> changes the device info, and the copying all of that data over to
> runtime info probably isn't worth it.
>
> Should we just acknowledge that the runtime info is useless, and move
> some of that data to intel_device_info and some of it elsewhere in i915?
With newer platforms getting more and more modular, I believe we will need to store even more mutable platform information.
In my opinion a separation of immutable and mutable platform information is cleaner and easier to maintain.
>
>
> BR,
> Jani.
>
next prev parent reply other threads:[~2021-10-20 19:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 0:23 [Intel-gfx] [PATCH 1/3] drm/i915: Add struct to hold IP version José Roberto de Souza
2021-10-20 0:23 ` [Intel-gfx] [PATCH 2/3] drm/i915: Track media IP stepping separated from GT José Roberto de Souza
2021-11-02 7:30 ` Lucas De Marchi
2021-10-20 0:23 ` [Intel-gfx] [PATCH 3/3] drm/i915: Rename GT_STEP to GRAPHICS_STEP José Roberto de Souza
2021-10-20 15:06 ` Yokoyama, Caz
2021-11-02 7:27 ` Lucas De Marchi
2021-10-20 0:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Add struct to hold IP version Patchwork
2021-10-20 1:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-20 5:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-02 20:04 ` Souza, Jose
2021-10-20 9:47 ` [Intel-gfx] [PATCH 1/3] " Jani Nikula
2021-10-20 19:29 ` Souza, Jose [this message]
2021-10-21 13:11 ` Jani Nikula
2021-10-22 20:15 ` Lucas De Marchi
2021-10-25 9:04 ` Jani Nikula
2021-11-02 5:33 ` Souza, Jose
2021-10-20 15:00 ` Yokoyama, Caz
2021-10-20 19:19 ` Souza, Jose
2021-10-22 21:26 ` Yokoyama, Caz
2021-10-28 21:08 ` Souza, Jose
2021-11-01 14:29 ` Yokoyama, Caz
2021-11-02 7:32 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74cc5b4a8ebe2a5f7ae01994c6782124328a2e0e.camel@intel.com \
--to=jose.souza@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=matthew.s.atwood@intel.com \
--cc=radhakrishna.sripada@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.