From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F88FC388F9 for ; Sat, 21 Nov 2020 20:10:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF3DC217A0 for ; Sat, 21 Nov 2020 20:10:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gYjQ+VU1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF3DC217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgZDV-0004g6-Rb for qemu-devel@archiver.kernel.org; Sat, 21 Nov 2020 15:10:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgZCM-0003rF-9w for qemu-devel@nongnu.org; Sat, 21 Nov 2020 15:09:30 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:34451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgZCK-0004q5-MI for qemu-devel@nongnu.org; Sat, 21 Nov 2020 15:09:30 -0500 Received: by mail-pf1-x443.google.com with SMTP id w6so11188117pfu.1 for ; Sat, 21 Nov 2020 12:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FiksJ0NtazC+dMSPsesnVn9fDJTOrd9LMHgw4rP63JM=; b=gYjQ+VU1HDqjEyEKMT19TKEChKypwIosv7Hm3oew/ZMWS12OECtcKpMDhOazPvkK7s U7/W6uXsIgr6hne7S5nfYJNuuDETV0O58f5OKRWEqeodN/Sk5qaVX05dmIx43Upuor3A X7Qf/99Y7CssKcJaTEVO1yvHT+SSzz5dXODKVgLN6GjXgNN1BAgzef4p96KYdH0r3RYe JfXEL5VKpeFrwO/hhFiaUZVLGA7aNnGQ4Wum0TtChYcDAY1E1eiXarc8BWNRXTpswB2O EvTrtZ3F5vJIT90W+lEcOpdL09ozix2tyZSF7rIJV5b7nprpJ2IqozjAP8h0Td6vO5Lt 7W+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FiksJ0NtazC+dMSPsesnVn9fDJTOrd9LMHgw4rP63JM=; b=IuEf8E/iDHlUVt35rvFKe65MkKPiEqAN67Lm+2gQleAlt/vavt3c6C47GmmbgI4w9D nwcrMd4tDLWaULREPe3KVVV0JW/GV8YvOhlqF96zkIPc/L7t+MEdseIrp1a7EANy/hfE O1ukxfyMzUitCzyG0Lt34olsT0ciKaPOj/AAAzj65EUU3MlPUQ3OdEyxc467d0n3DH3P 6iZebyES3enz17O2C7rk2H9Ju2Ta6tmkEVJgtBVJFkns2Zg+4XBRxJblK+34Sll4Zisc 2aToS7G5Ruo9E2Mo44uP6SyW03t/ik7taijuh5dVMNL3bfiN0mN6aovIC7PQVciUlK89 UOFg== X-Gm-Message-State: AOAM5327OhBUZgIvUBPDNOPBBnFwNVLdweIHrY6dTaT/umKRl3U1xpZe +uhrWlz9meP7hDuxNtit5JfbTQ== X-Google-Smtp-Source: ABdhPJxQoyM7eKc2qgEmXKs90ca8SAqa1tZu21dfMhIDwW0XirUF1UKBrVQrs1sKVki2DO6KI9T5ZA== X-Received: by 2002:a17:90a:ea05:: with SMTP id w5mr3187896pjy.204.1605989367499; Sat, 21 Nov 2020 12:09:27 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id 17sm7898096pfu.180.2020.11.21.12.09.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Nov 2020 12:09:26 -0800 (PST) Subject: Re: [PATCH 18/26] target/mips: Extract Loongson SIMD translation routines To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201120210844.2625602-1-f4bug@amsat.org> <20201120210844.2625602-19-f4bug@amsat.org> <2aa2dd99-fb46-0466-bd13-3ea8aacdc697@amsat.org> From: Richard Henderson Message-ID: <74d2995f-c04f-3531-a5e0-2f02fc19da0f@linaro.org> Date: Sat, 21 Nov 2020 12:09:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2aa2dd99-fb46-0466-bd13-3ea8aacdc697@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x443.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fredrik Noring , Craig Janeczek , Aleksandar Rikalo , Laurent Vivier , Paolo Bonzini , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/21/20 6:30 AM, Philippe Mathieu-Daudé wrote: >> -/* Godson integer instructions */ >> -static void gen_loongson_integer(DisasContext *ctx, uint32_t opc, >> - int rd, int rs, int rt) >> -{ > > This isn't part of the LoongSIMD ... > > [...] >> -} >> - >> -/* Loongson multimedia instructions */ >> -static void gen_loongson_multimedia(DisasContext *ctx, int rd, int rs, int rt) >> -{ > [...] > > ... but this part is. > With gen_loongson_integer not moved, Reviewed-by: Richard Henderson r~