From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 566DCC433EF for ; Wed, 22 Sep 2021 06:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41CBC611B0 for ; Wed, 22 Sep 2021 06:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232777AbhIVGay (ORCPT ); Wed, 22 Sep 2021 02:30:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57108 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232753AbhIVGax (ORCPT ); Wed, 22 Sep 2021 02:30:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=PGPf9ZzB33LZyiZilg2aozwZm5TDj5p0O5vz/gJCSjvz+UFxd649DuOMY96TZ0C7Yhswar Jo7WK7EKH7drHXehvlque90NgI8miKqAqdhI8I3mYPRJ1+VBPU59VAOBjhjFTrRdyNQnyy WXSIXoeyFvkhHyhwswuM+UhVvVnYRvw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-rlf42m89PJC7NzJSU0wK7w-1; Wed, 22 Sep 2021 02:29:22 -0400 X-MC-Unique: rlf42m89PJC7NzJSU0wK7w-1 Received: by mail-wr1-f69.google.com with SMTP id z2-20020a5d4c82000000b0015b140e0562so1157345wrs.7 for ; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=BTiUyza22nA4nqG+bqy7KNAB06y0JXOiZQoAa5q8QNZX8nT9fW5S/mWTSU5HwbctaG RmZcU7W1EbpsE+uU3Dw7FjmL2hk+Jyc9xeTaqHCoS0DX62OmubiFtnLgzVSYfAErwpRI DH+IRsqiZuZI6RJw992YTdtb93KGmJDQv+atA7C7Fk0EfFQxZjltJaJXYWZjALScH7xX MZ8b2Kbns0nUraUIBPZJBdN6ZX/haXy6cECY2Mf7oRUDxUNJjXEPvbVJct5yOpGbYuJE iDq5TrnxzAU2vnbCTEHPnxYU6lohbYlp1ELEyNbcmo8+9QwJ5+w/LlLwx6EdjIfv07jH a81Q== X-Gm-Message-State: AOAM531NYjlBJA4qE/f1wHoGwfFQzO85XuUPj7+6SHZjkVUzBKpHQNu3 s2X3IwD+CyVruahMQPvVO8fj3N9brL85wPDOuJIGX/5wDsejtmojNlHNwMQgrUecLcJrLbmONFI Iqu1IyPI6EVFSuF3Wr+beqZtH X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506101wrp.171.1632292161047; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhBqcw62XwXR9WbHiblbcM9n6+4WHbybrr5/MkhCq7T4dnVdh+qdYz2KsHuqdWFBJH3F6z5Q== X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506073wrp.171.1632292160784; Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n26sm4980232wmi.43.2021.09.21.23.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Subject: Re: [PATCH v3 16/16] perf: Drop guest callback (un)register stubs To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-17-seanjc@google.com> From: Paolo Bonzini Message-ID: <74d2e94f-fbd3-522e-8fc5-da5a0a575838@redhat.com> Date: Wed, 22 Sep 2021 08:29:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-17-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/21 02:05, Sean Christopherson wrote: > Drop perf's stubs for (un)registering guest callbacks now that KVM > registration of callbacks is hidden behind GUEST_PERF_EVENTS=y. The only > other user is x86 XEN_PV, and x86 unconditionally selects PERF_EVENTS. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > include/linux/perf_event.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index d582dfeb4e20..20327d1046bb 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -1505,11 +1505,6 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr) { } > static inline void > perf_bp_event(struct perf_event *event, void *data) { } > > -static inline void perf_register_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > -static inline void perf_unregister_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > - > static inline void perf_event_mmap(struct vm_area_struct *vma) { } > > typedef int (perf_ksymbol_get_name_f)(char *name, int name_len, void *data); > Reviewed-by: Paolo Bonzini From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF16C433F5 for ; Wed, 22 Sep 2021 06:29:27 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 1D282611C9 for ; Wed, 22 Sep 2021 06:29:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1D282611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C035840573; Wed, 22 Sep 2021 02:29:26 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qeMX+z6Yjah5; Wed, 22 Sep 2021 02:29:25 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B45B74A173; Wed, 22 Sep 2021 02:29:25 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 882A340573 for ; Wed, 22 Sep 2021 02:29:24 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZvauEbqeeGqi for ; Wed, 22 Sep 2021 02:29:23 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 94A9B40413 for ; Wed, 22 Sep 2021 02:29:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=PGPf9ZzB33LZyiZilg2aozwZm5TDj5p0O5vz/gJCSjvz+UFxd649DuOMY96TZ0C7Yhswar Jo7WK7EKH7drHXehvlque90NgI8miKqAqdhI8I3mYPRJ1+VBPU59VAOBjhjFTrRdyNQnyy WXSIXoeyFvkhHyhwswuM+UhVvVnYRvw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-WFdEsCn0PdKCIgG3ofoAyg-1; Wed, 22 Sep 2021 02:29:22 -0400 X-MC-Unique: WFdEsCn0PdKCIgG3ofoAyg-1 Received: by mail-wr1-f71.google.com with SMTP id j16-20020adfa550000000b0016012acc443so1129165wrb.14 for ; Tue, 21 Sep 2021 23:29:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=XVMyCQNyY6JWpnB/oWG0QxGRmgyjsEujyklMinH4oA3vgNcDhC3S7OhcVp22DiLe42 FYRpU5+vPhysV//1vwavrx+R7SO/drlwdSXONM0aQmT5iSqr8ys5G5ShkvkjXfcrpmaw oe1a5JiPM/cyfMmUTIdg98EmsKQFBDFgQHNLBWW7VIrzTO/ylKeubIrpvoaeSV4ZGvFz DkmHeRb59qv0hKrmBBpIN+UHqqVKC0TJ6pLlruIRblGxk7dkbdLuz1NMm5jFV1eqx/FN ASEs0zeRVfO4cSVaEC0Eu/fkXirZaVEnQxq+y2M8rUODXNveHdZnxTCt+7439X7TSqwS vavA== X-Gm-Message-State: AOAM5316f14oDvPOyk3n8G9MMlUyYk+1DFkb+YrzTyItqyovzwcXnqyg +3fCWuBylIQV+NZFVMZSefC/rmPuUwr5n+H+8LBrd1lAUkcpQ7UCrjUBDIkbPvdbWTw7BiKu6ES boanI0GoJ77wZxownzEbRhrQ+ X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506122wrp.171.1632292161048; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhBqcw62XwXR9WbHiblbcM9n6+4WHbybrr5/MkhCq7T4dnVdh+qdYz2KsHuqdWFBJH3F6z5Q== X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506073wrp.171.1632292160784; Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n26sm4980232wmi.43.2021.09.21.23.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Subject: Re: [PATCH v3 16/16] perf: Drop guest callback (un)register stubs To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-17-seanjc@google.com> From: Paolo Bonzini Message-ID: <74d2e94f-fbd3-522e-8fc5-da5a0a575838@redhat.com> Date: Wed, 22 Sep 2021 08:29:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-17-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, Alexander Shishkin , Vitaly Kuznetsov , linux-riscv@lists.infradead.org, Jiri Olsa , kvmarm@lists.cs.columbia.edu, Stefano Stabellini , Joerg Roedel , linux-csky@vger.kernel.org, xen-devel@lists.xenproject.org, Namhyung Kim , Artem Kashkanov , linux-arm-kernel@lists.infradead.org, Jim Mattson , Like Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Zhu Lingshan X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 22/09/21 02:05, Sean Christopherson wrote: > Drop perf's stubs for (un)registering guest callbacks now that KVM > registration of callbacks is hidden behind GUEST_PERF_EVENTS=y. The only > other user is x86 XEN_PV, and x86 unconditionally selects PERF_EVENTS. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > include/linux/perf_event.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index d582dfeb4e20..20327d1046bb 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -1505,11 +1505,6 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr) { } > static inline void > perf_bp_event(struct perf_event *event, void *data) { } > > -static inline void perf_register_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > -static inline void perf_unregister_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > - > static inline void perf_event_mmap(struct vm_area_struct *vma) { } > > typedef int (perf_ksymbol_get_name_f)(char *name, int name_len, void *data); > Reviewed-by: Paolo Bonzini _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5256C433F5 for ; Wed, 22 Sep 2021 06:30:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5F9A61206 for ; Wed, 22 Sep 2021 06:30:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A5F9A61206 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jZb8NoEdBRGcNmbTF+xDUX0Un/xv5SvQBXZ8n2NOFI4=; b=f8QZ6bcfvrm9kyh8zD5UZ7Oseq DrGoDuyhMtbHDK0hnme3pU+RP7xWrBdMH8/b2nqDl56UNTbiyGmbyZATiOFYZxfqtI9MZR0k5rDmP aV0ms5horYUb2SoYhWClTOqCUq1p1jgZr2xhtxwRAZqpjKEsR0ObH1rizwwaP4tPQELC2LJyZqPlp 4luvDVoh3qKkqg2kfGFmJUaw1Jfj2CHqgrEjhQQMzXmVOcl04GHP3yxZE/Ru2Q7kfMqsbD6KacA9L nOa04o90UMw9hUvniz013FMzfWX79gYtNsAkvhWfXTkATpNYEbm8VgMlTbP+hqSy25NrbqTuIIOzK UPXiNBnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSvlI-0073HZ-6W; Wed, 22 Sep 2021 06:29:44 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSvky-00739U-F7 for linux-riscv@lists.infradead.org; Wed, 22 Sep 2021 06:29:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=PGPf9ZzB33LZyiZilg2aozwZm5TDj5p0O5vz/gJCSjvz+UFxd649DuOMY96TZ0C7Yhswar Jo7WK7EKH7drHXehvlque90NgI8miKqAqdhI8I3mYPRJ1+VBPU59VAOBjhjFTrRdyNQnyy WXSIXoeyFvkhHyhwswuM+UhVvVnYRvw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-QFpiKEUaOZGwLah-eYb4pg-1; Wed, 22 Sep 2021 02:29:22 -0400 X-MC-Unique: QFpiKEUaOZGwLah-eYb4pg-1 Received: by mail-wr1-f70.google.com with SMTP id m18-20020adfe952000000b0015b0aa32fd6so1137075wrn.12 for ; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=rhRXUgwOtRuwQnYZO06nJhOJoSapqwAw4Og8rH9CDM96ke2NTsWSUsdhpGn1bbmE5U PDrXPpPWbNfPtC4mjqljS45hq55oLIntBrcUJkvjuUcdqo079+i6imekf/sV0rzI6Egj anWQoi4skQt0CMrGNQ4RisBt91fdhmRVzqHI3i861MkfzDwyR4qPmyR5dDyHmqmNM7ae r7JT57E2BL2O3KXWQsNyAJZDHe+JN+rejo0pbNN9Rq74Zs3yG0N7YWiMI1s4DdmctrPm 2qQnS0ZsOkEshyYQLbnb3Q+qrrS5odM913cHSSMotTcLNBgiYtO8YJiBPcaAt7DJhhK0 d96g== X-Gm-Message-State: AOAM5332D2OsDNO9vvjlyyE3hbo7OWx6dFTy5KiyAqPhGmtPhvLlWPvo BO93R3SHmUYXmWR/jh7TbPCSgcfZk8NE4m3KQAlUR2WajO3T9kM1+D39rDAbLXn6DXMQmO3U4Zp SVfJOVQiMzjAlmkQNo4a4SMpTcpdX X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506106wrp.171.1632292161047; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhBqcw62XwXR9WbHiblbcM9n6+4WHbybrr5/MkhCq7T4dnVdh+qdYz2KsHuqdWFBJH3F6z5Q== X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506073wrp.171.1632292160784; Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n26sm4980232wmi.43.2021.09.21.23.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Subject: Re: [PATCH v3 16/16] perf: Drop guest callback (un)register stubs To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-17-seanjc@google.com> From: Paolo Bonzini Message-ID: <74d2e94f-fbd3-522e-8fc5-da5a0a575838@redhat.com> Date: Wed, 22 Sep 2021 08:29:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-17-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_232924_621766_49CAB50F X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 22/09/21 02:05, Sean Christopherson wrote: > Drop perf's stubs for (un)registering guest callbacks now that KVM > registration of callbacks is hidden behind GUEST_PERF_EVENTS=y. The only > other user is x86 XEN_PV, and x86 unconditionally selects PERF_EVENTS. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > include/linux/perf_event.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index d582dfeb4e20..20327d1046bb 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -1505,11 +1505,6 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr) { } > static inline void > perf_bp_event(struct perf_event *event, void *data) { } > > -static inline void perf_register_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > -static inline void perf_unregister_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > - > static inline void perf_event_mmap(struct vm_area_struct *vma) { } > > typedef int (perf_ksymbol_get_name_f)(char *name, int name_len, void *data); > Reviewed-by: Paolo Bonzini _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D77C433FE for ; Wed, 22 Sep 2021 06:31:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3797E60EE5 for ; Wed, 22 Sep 2021 06:31:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3797E60EE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5BKl/R4T8STL17eBWF+b7ynEh3gz+tRNze0seQh83xE=; b=KiDzsiZe0PFQc8kv5ysXMVeMb5 mIfCMbXIr+M9XewEqsZC5ZrVJgBXoBmJXgrAzCuQxIGk+0zzmFGhhxFCtXU4NzY6NFW069wbiZt/G jh7dPwDjuukPI5vtiDECOPrmThZfRkArf3898BHfJZ0gb9hClMcvsQVhZP4bWrGWFuV77pQdUVzHA WXwUacvu3vpPhJ9glkQzZmVljDw2wULDVzJ8nZORW+eeKLFX6mpB7Znu5Q4ZfUhbDlQYAAOn5ECOC cnrHuNVoEyRQBxfQNPibo8SYJ7nhTgQzusP8m8N6rdaPrjVBmg0s1YXJLn4of++qJv6Z5RTivh3fL YE67RXyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSvl2-0073BV-SH; Wed, 22 Sep 2021 06:29:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSvky-00739P-Bi for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 06:29:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=PGPf9ZzB33LZyiZilg2aozwZm5TDj5p0O5vz/gJCSjvz+UFxd649DuOMY96TZ0C7Yhswar Jo7WK7EKH7drHXehvlque90NgI8miKqAqdhI8I3mYPRJ1+VBPU59VAOBjhjFTrRdyNQnyy WXSIXoeyFvkhHyhwswuM+UhVvVnYRvw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-474-D2M5b5r5OxGYG3t2Iky3Vw-1; Wed, 22 Sep 2021 02:29:22 -0400 X-MC-Unique: D2M5b5r5OxGYG3t2Iky3Vw-1 Received: by mail-wr1-f72.google.com with SMTP id f11-20020adfc98b000000b0015fedc2a8d4so1199669wrh.0 for ; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=t8lvU+Wj6DbKN+pYhG0V/lZnmqOzWI0yFAqa2AX2Na99xAIg20/d5jJtHTcP3KPZJA LXWZyue6FaqjOMDogA5A1h4cEO7lwEyU00G7CYDVkwf+iN9vrZCfBj6HoC7m+XvGw2Xd OVLiXAW7qZ68tlezZyyj1QqkrIqcqigykaoXgwPonTqxm8v1/R1kZ7JtNatWSN/7TSu9 ABZ7F3/hjIsBRJgNdwORHqKaIPGI+Kz/vSK6QLIO53f0CZ1BaTEGR8ES2l6jRQX7D8V4 yFm56ZEwMSkeKlA/s+sZLs4rh0+2rfs1D+6SN4t2PIU991Hp2xfW08YTDoYc60CkVl3Y oSZQ== X-Gm-Message-State: AOAM532WMVtyWNQinQDFtNW58dcy1n7sj0Q6MzMShRHmg8tmDdy9sFJ2 6QRut5XbsP6px1xPwfrTtkg+jaGkWMtu4fFWuxfNgkgsP3kZhePY9PPXbLvfBlcwqYpusoNx6M2 rFrEcEjqvvKMWnukZgxlNFQQGTRptbVGwFiQ= X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506113wrp.171.1632292161048; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhBqcw62XwXR9WbHiblbcM9n6+4WHbybrr5/MkhCq7T4dnVdh+qdYz2KsHuqdWFBJH3F6z5Q== X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506073wrp.171.1632292160784; Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n26sm4980232wmi.43.2021.09.21.23.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Subject: Re: [PATCH v3 16/16] perf: Drop guest callback (un)register stubs To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-17-seanjc@google.com> From: Paolo Bonzini Message-ID: <74d2e94f-fbd3-522e-8fc5-da5a0a575838@redhat.com> Date: Wed, 22 Sep 2021 08:29:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-17-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_232924_556302_704E85E7 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/09/21 02:05, Sean Christopherson wrote: > Drop perf's stubs for (un)registering guest callbacks now that KVM > registration of callbacks is hidden behind GUEST_PERF_EVENTS=y. The only > other user is x86 XEN_PV, and x86 unconditionally selects PERF_EVENTS. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > include/linux/perf_event.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index d582dfeb4e20..20327d1046bb 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -1505,11 +1505,6 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr) { } > static inline void > perf_bp_event(struct perf_event *event, void *data) { } > > -static inline void perf_register_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > -static inline void perf_unregister_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > - > static inline void perf_event_mmap(struct vm_area_struct *vma) { } > > typedef int (perf_ksymbol_get_name_f)(char *name, int name_len, void *data); > Reviewed-by: Paolo Bonzini _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel