From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BAAC433EF for ; Tue, 1 Feb 2022 16:02:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9EA68D0071; Tue, 1 Feb 2022 11:02:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4DDB8D006D; Tue, 1 Feb 2022 11:02:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9788F8D0071; Tue, 1 Feb 2022 11:02:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 8552C8D006D for ; Tue, 1 Feb 2022 11:02:14 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 403CC99900 for ; Tue, 1 Feb 2022 16:02:14 +0000 (UTC) X-FDA: 79094677788.15.37775E3 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf14.hostedemail.com (Postfix) with ESMTP id AC0AC100010 for ; Tue, 1 Feb 2022 16:01:58 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 211Ftfn2029825; Tue, 1 Feb 2022 16:01:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=kmlA1pREIFwUoFd0LKN0kI4uGv/wP2vJggCsvL1mkUo=; b=I36shokbqnM14gfR7mqUq5DxTAf4+xIKc3h8HO0E2sthhmWFHC6Q8Z5WlpDATgqtNo4n 5PGCXIL0rS3ANRoBFtxZqHxEtCxuRLs/Ldr1joXwvLGo0ADfbaBHuNA9lcFqQ1RKfNGC VODg71bXJsi/G0LkCRjLBXyxZXtGjUfRQfvFXMn5vuQmp78m66qkfPxQ0XhmomF46H1b A4dylaWp7gf1eds9DuQh74aPkDCmfQ8wQPRiwtz0fbw5fGnelFVoJjsSu/6rVwxdv/J4 +xmX9SF/kp8XMMRqej/8vUB77hvSiuXr5hGakOset5NUfcxLx49zE2vNE6wD30YAVdxv EA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3dxj9fucjp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Feb 2022 16:01:51 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 211Fv9sm178722; Tue, 1 Feb 2022 16:01:50 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by aserp3020.oracle.com with ESMTP id 3dvwd6fqpp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Feb 2022 16:01:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=htG36ezGGhZl3syrwJavMRq7m5liYUIMTqgGOMtAegeO/OhFcVbRWM8y4BokDlKBavYbVjNSBpwWHBYkhsRHJFIG62GAemmaeAxWl3Kc2uV+4ACbe0fLa7LviDk3NK12Py6rc5smhJPCgCdP9pjialBQ2Y2yC9WchllLK/u6Wbco/VVmWBUbDnc8VmksAvPgAAXjb7ziJEEW+Ij7EoIm1cBAPxV/dwaZK8M5IeI7nrJkFQnzTKeyBwg8APO4ue66T9UGdlIVuovYQymWXQTwGN6wuSkhS1PUvWY+ZqENZ30y7YMDrJIRCw1V6Vtn1kQ3VXdG+8EB0/sk0ypPWG26xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kmlA1pREIFwUoFd0LKN0kI4uGv/wP2vJggCsvL1mkUo=; b=UR2DL0iutHHhlXpOfVknm3B0CRMudaWp3veZcexNOmy0fcJcNKiZhUpJkyJU3Os0um8wKAih9WEKEKumFNkfXpv5ax0FUtaJ/ierd6lbrHxVtLA8Be8FzTDbE5YO0Am9V4m71y3XU2lzdyUrQpi9G5p5bZowqRAOmeVC/ZDkTeX3DqZ46DStVfkHhKTpIhlqjot18Aen4/6GsAT55/c4w8vTl2suuXuz/gP8DhJWkferWaCQ1sU2SfUE4zDXuhS/jv6MdJ2gUy+k+6VD3Dt5Meyvjlnpihp3tVYAdtUZehaHn3Bj3nVB6LBIjVVHKzFcC4PFL5YT8/E7rR/JeLB9cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kmlA1pREIFwUoFd0LKN0kI4uGv/wP2vJggCsvL1mkUo=; b=DzgZg+aPe8FbSRGIzRnmsw+J0+SBznzRTgutmdX6z3gHQi2l485BBPDXbYIFQ/6LIvre0JoIw6DftSxDZLrHihMpvYqsKSrjZlaSYbfuslohpdqo27L0tOGajvfIQh7tWXy+R8JnHjQc/F/mz6cCTZJvNJYXMFsKu3gTkuM+xKo= Received: from BLAPR10MB4835.namprd10.prod.outlook.com (2603:10b6:208:331::11) by BN6PR1001MB2404.namprd10.prod.outlook.com (2603:10b6:405:33::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Tue, 1 Feb 2022 16:01:48 +0000 Received: from BLAPR10MB4835.namprd10.prod.outlook.com ([fe80::4910:964a:4156:242a]) by BLAPR10MB4835.namprd10.prod.outlook.com ([fe80::4910:964a:4156:242a%4]) with mapi id 15.20.4951.012; Tue, 1 Feb 2022 16:01:48 +0000 Message-ID: <74d4bd51-6f16-542d-9710-3c609346cfe7@oracle.com> Date: Tue, 1 Feb 2022 16:01:42 +0000 Subject: Re: [RFC] Missing compound_head() in memory-failure Content-Language: en-US To: Matthew Wilcox Cc: Jane Chu , Naoya Horiguchi , linux-mm@kvack.org, Andrew Morton , Dan Williams References: <30a327fd-ae49-7412-ef77-9ec19480626e@oracle.com> From: Joao Martins In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR04CA0062.eurprd04.prod.outlook.com (2603:10a6:208:1::39) To BLAPR10MB4835.namprd10.prod.outlook.com (2603:10b6:208:331::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 976e0c57-783d-4cf2-fbfa-08d9e59c2703 X-MS-TrafficTypeDiagnostic: BN6PR1001MB2404:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DX0jNeti4RZMupoa3mSOgxCjncQN6xDlvrdZi/BWMueYi5sLoQEK0PTtHgEIc9YBs3CIT9knuIlCB+gqOsCf6UqY26vTNwnBFZVIZy2xlqV8ubCWdpL/darwoL2FNHviDo4gIbpWcU9EfkylQUSUx5BQFw5r7GagaYKHSkRR0+9Q/Oev+mnj2vqYnW0m6cfiPMiFPyvnjgHHCIQNymbeJKE7wBJaMcbEMHKGZd5h4fEhBGAPfg2jdeg8WVRUwdAuadp4U389OYSADCeHPG7FS5eJVgMeIwSiV++vz75bgmk7lgBTjR4lXQ/kPdPnziwylaCoMN1Di2ZFG6f3g4uXWslmbb92WLuot8EN3xcjdeHW82fmar/TXQRrHTVH0SEshQ6L4GtT7JsV/jlTu6Z756C+W3f5gUehjeoC+O/93Y4wu045wuS+tRKAwIDJzHtqjDN/yTp/4vuh5DjJRrT9L8wx+bnnBdjJw9XvMOjR2DeN+lhnBdFYliuAwhrrhOXqpLn9ob6vjOVu+eT6opZiOfH8DiaN4IUhNzS0t4SvCKNpsAlMWpYU5RddVH3/m/fE9o0WrNvbfRbPOWWw6Q/LYwVHO7HEzoPIZOk1mEOZ10xSAG1eppjdQImBaT3BTWmc+5WRlaDzkFDS4Zz86u+ieN/yW7gNjd/j353YEVfXgdmnjo+j8fA59LJ7h4wF07oQwcO/+0fSqaIYapZUk2O9MKHoxTzII35FOKo36z/33lGY9ZAp+GgranQdLLZSz5NhS7MKXikPQmBT8aGxSdeo1L3LPyxLgPKroNcTSL0nMCc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB4835.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(54906003)(5660300002)(8676002)(8936002)(6666004)(4326008)(83380400001)(2906002)(6512007)(31696002)(86362001)(6486002)(186003)(966005)(36756003)(38100700002)(53546011)(26005)(6506007)(508600001)(66476007)(66556008)(31686004)(66946007)(316002)(2616005)(4744005)(45980500001)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2RuMDhZZ01mTUZZNW9vRlJOa1ZoSU5nNjhQeU11UFpyNEtKTk1ZcWkvME9Q?= =?utf-8?B?VjVVL1hBZDRmYlRoTWI4VW02U1FNUE9xcEllaEJ0dWlkcWkrRmMvZzBTZ2pZ?= =?utf-8?B?bDRla3FUNEZraFk1bGtxaGk1Um83aWtXem1NYllHNHh1aVpaN2ZGVHltMEZh?= =?utf-8?B?ZkJiRTVRczI2NUJ5aXlFOVV0cnJPak1oUS9VVE56ODZWZ2dHMjFaeFlEcGdZ?= =?utf-8?B?YVI0cHZ4SzZWMzA4YUdVOUtqOGpZM3pJTktxcmVJM05YQSs2cTV6L3dvMUoy?= =?utf-8?B?QTVXUHdTRzZTSEdJRzE3NWJPeExCc0RyS0hERittdlhaMzdmckxzRS9yd3JJ?= =?utf-8?B?WWtsT2tvYnlTZEFFVk1pV2lycE5EbGNZa1FtVW94OU5RK1VFVkRPd1JEU1N1?= =?utf-8?B?bzJFZDRqVVRPeEU5L3ZNWmtLSTBtZVJObVE2WGo4SVdtV2FGVWZZM3lmbEp1?= =?utf-8?B?YTd1NUJ0TUVUeFhUa1hsbkxqOVNvVFduQlpycFlBNDB4QU02N0JHQ3dXZHlS?= =?utf-8?B?ZWQyeTZlTFdoaGJieTRuSmJRRXl3bzUyOVR1MmVKZVdqdzJBT0NSYytnVmk2?= =?utf-8?B?aTRMTDlCWHBKeUF0enY5WVFlUVgwQVdTUFRaRmZlWXpIaDU2bytTMFNMckxY?= =?utf-8?B?SngzVE1SWTgrQk5YSUcydEJCZkxCYjJnMkJ5K2RsNWsvQWk4U21icUtIb2dF?= =?utf-8?B?YzBrdWhlVVpndmZtZkgvWWkxdHI4MHgvcnhvOUZKeEEweGVKMENuZVdzZnMx?= =?utf-8?B?YnkxallmM0ZNeEs5cXN1bVRMZWtRSlBrTHJrSldoNUhQcGJlZkRURWJ1ZzBB?= =?utf-8?B?bkdRbVp2UmY3Y1lxOTZBUHBLZkY2ckMrRGkyM0ZiQS92MnNjRzFnVUJGTkNO?= =?utf-8?B?ZWorTXl0REhVUmV6Z3l0OE5odXI3Q0pvR2NuZStGc3dPL1UrWXNiT1BCbzhM?= =?utf-8?B?SCs5eFdsUERTQ1RLUmZLWTNZZGNiWWJDQVQ1d1ZTZWFnalllQTF4bGlIWk5h?= =?utf-8?B?QlEvRmJ0OGFSYWl5QUlFbGV3aGFvWnA1MVlKUXpTb2hsUE9zVE1KNmlFVVJ4?= =?utf-8?B?YVZZMmVhYmxoWWQvdUc1eUFNeWNyM1ZYNGQvcTJldUV2bDhJQTlTV0g1eFcw?= =?utf-8?B?NnUwZnpIWmljakJvQXIwOUtYOXgzdFZVKyt5ZFZpaG1sRWRGYUEzZWtaMHUz?= =?utf-8?B?U0lYbXZ6OFY2ZitZQjd2WDZQTnUyVkorN1U2OW96SDZHRlgxcmhjSTBYUml3?= =?utf-8?B?ZDdPM2pXQVhVb3FrN1dpK0NBMVR0bnRPRGpnZEhlZkFnY1JLRDJhemJLSk11?= =?utf-8?B?V1h2bnpoSENHK1BCUStOYnRHQ3NWYlZ6cjFQR3dUS2xZVHZ6RHZnR1hNcFNj?= =?utf-8?B?Q3ZxV3lxc0VhcGJtcFczZzE1TkJSVS9JRTZOaG5oSnR2Ty9EcnEzaVQ2akxT?= =?utf-8?B?R1B0cHVCVWozRXNNRGVaUjNsVC9kYktWc0VEbHU0cVRSN2dhOGdVc2dST3Qx?= =?utf-8?B?clArZ3p5M1pSNU5mN2g1RzZTZUgrakdoZlhxaFNPV3N0eGRhMFlTTEpWalZD?= =?utf-8?B?UExyeHkwT042b21SeEVFaVFPR0FDb0k3Zk1qKzIwbEtzM1lnbnk5UnJxSGwy?= =?utf-8?B?eXR1ZE5HYnQ1dHJLU1RvaGlES1RwbHowMnZicTlQTFp1U3E4b1NaVXlFa3lQ?= =?utf-8?B?cTI3QzhQYTAyNGV5YVZtQVFzUzJXMEw2YTJ5dzhsbG1jTkxMeHlKenhWZlNF?= =?utf-8?B?WE1JbzdyekxEeEExaDdxL1M0STJQaCtlTTJ6aFZsQnQ5UVdrV0MwMlgyeERs?= =?utf-8?B?ZXRzRDZPeUJmOE5sTGRQQ3JnTDZMMDdPd3NxaEdFLzNyZVVOaDU5eXMwdXZw?= =?utf-8?B?ZUQ3cVF5aVFUenFhU2E0eUpzRnhmRlltaThUWHJPL1UvVERzeWJZcWpBeU5P?= =?utf-8?B?cTNJVmxFSWhUSFRYTGVnL0pmM2c1bC9LUzVVdFNaU2VKS1ltU2dNdllwMWNS?= =?utf-8?B?L2tXa2ZoNmVsRDBIYTFYL2M2eVoyVDErbVljdHc0c01KRFRsOC9JWFBxSDJL?= =?utf-8?B?Q1Q4MkREUG1FczM1Vm5lSG4rWnJIM20yajFSeERhZVBUdEJHdVl4bGkvelYx?= =?utf-8?B?bUkyT0xEY1FDeGtxb3h5ekNyZVZwY2lkMy8wazdjR0FieHpPT0E3VFRTQTJy?= =?utf-8?B?WnYvSDBiTTNDQzJIazRud3Z1OTdKTHBzMmdnS0ZZS2VvY29BMk9KNitUMHdo?= =?utf-8?B?RlludU14S1JSem1WRkdjQXpOQml3PT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 976e0c57-783d-4cf2-fbfa-08d9e59c2703 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 16:01:48.4679 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C5SlYAL/xTFeR3vteUMdV78ZmXDInKQHJRY7SVbGfmt37zb8qA+Arg23RJDFhEiS3TFWlbzFeNTg2Yc0yarqk3+iivb3kh1b2aTbE+6Kl6Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2404 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10245 signatures=673430 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=851 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202010090 X-Proofpoint-GUID: IUH33CtcxBbl7eGdrUOiMmnoPMKj8gDj X-Proofpoint-ORIG-GUID: IUH33CtcxBbl7eGdrUOiMmnoPMKj8gDj X-Rspamd-Queue-Id: AC0AC100010 X-Rspam-User: nil Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=I36shokb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=DzgZg+aP; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf14.hostedemail.com: domain of joao.m.martins@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=joao.m.martins@oracle.com X-Stat-Signature: 43iiokh651c4a4oekrh93goc4bcaa8h8 X-Rspamd-Server: rspam08 X-HE-Tag: 1643731318-435589 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/1/22 15:46, Matthew Wilcox wrote: > On Mon, Jan 31, 2022 at 08:54:39PM +0000, Joao Martins wrote: >> On 1/31/22 20:29, Matthew Wilcox wrote: >>> Unless I am mistaken, you have to pass the compound head of the page >>> which has the error to collect_procs(). Am I mistaken? >>> >> -rc2 already has a fix for it: >> >> https://lore.kernel.org/linux-mm/20220129021420.PgBIZm-q9%25akpm@linux-foundation.org/ >> >> Earlier in that function there's a: >> >> page = compound_head(page); >> >> So the @page passed to collect_procs() already is a head page. > > It's wrong though ;-( You set the HWPoison bit on the page after > calling compound_head(), so you set the bit on the head page instead > of the precise page that had the poison. > Considering that on device-dax we would unmap the whole 2M page regardless of the poisoned subpage isn't that actually representative still? > I'm fixing this up as part of the folio patches, but you may wish to > fix it earlier than that.