From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC24C4338F for ; Thu, 5 Aug 2021 01:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22E5C61073 for ; Thu, 5 Aug 2021 01:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237668AbhHEBfX (ORCPT ); Wed, 4 Aug 2021 21:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234640AbhHEBfW (ORCPT ); Wed, 4 Aug 2021 21:35:22 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 654E8C061765 for ; Wed, 4 Aug 2021 18:35:08 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id m9so4853745ljp.7 for ; Wed, 04 Aug 2021 18:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AjXSLkd7H7YYDtJulH4krIQq1Y0iBImwf2ezdniIkdA=; b=sHJcB4jXI1zcgqPOZbIRAPp1vjrO3w4XLO+80yQ1MuSzVrAV1xXi4+raix9RC4NhxR U5NGLYnBmO98IShasDNXUY7XCt02jwep11JHfp9yDdK2Eg9rUiv1b5cMFXGwZUN6mnih Gr0jul6O94GONM1N3GP2bbkBnqwI5MaWXW9EFM4euqjtgRfvjmFPB66ll06X7Cf07c4s uFxxwc8uyVPKRPN/Dz8LzXKbiGSPeOEVC87x3UBHIBpShnrjhhHwJgBt2v1otbyfGyh4 ebJOkkxwL4VnvIcSzcEpMtIyjjrsJpgno2wWvtQk4a1nlM+q/2cQtZG7iS1vvW48Br2d /PYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AjXSLkd7H7YYDtJulH4krIQq1Y0iBImwf2ezdniIkdA=; b=WRMJsT5mrNuG9Dy69/1/c14/9NbIlTE2IcQRHpyUrtRLY5HAIrwmy2fGvZTxMm393n r2wCk8EhkeytocY9XXaz6lYH4bO2HdIAopyUqoodYybeCsQYFjSv6ZuJWtbWkfQF4Fwl P0CuIAC21y48+JRkUzaaDECP07QE3N+3H1y1+dRjWYlT584cmuzjfVtsq0UoT7Hi+vIb dMk4v31VROzrrhkceSe99KZE6JSJraFdTyt5I84CsjXk2/2pfFRjq70urZBNvjuf9in7 dqumOrKK9TMzhMdtZD974rKWd5EOSU5vb3M877yNNuveIXOI2zrX15jlhAL4nrGc5Klz 3+cA== X-Gm-Message-State: AOAM533MlNrYAHh6J8yCljYDKyRr0SRlj9VjXnRuUwa9062Z/oNldt0r vhe4ySU8HhbfH5DGXRLV6ss= X-Google-Smtp-Source: ABdhPJxJs0S5Dx9r0YKKkwk2cKGfGp76xrV0JclngteQaqi1YprULQ3XX9G3z8R7SUfkqenjL+DDhA== X-Received: by 2002:a2e:85d7:: with SMTP id h23mr1357805ljj.329.1628127306755; Wed, 04 Aug 2021 18:35:06 -0700 (PDT) Received: from [192.168.2.145] (46-138-65-182.dynamic.spd-mgts.ru. [46.138.65.182]) by smtp.googlemail.com with ESMTPSA id y3sm280964ljj.121.2021.08.04.18.35.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Aug 2021 18:35:06 -0700 (PDT) Subject: Re: [PATCH v2] brcmfmac: firmware: Fix firmware loading To: Linus Walleij , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , Kalle Valo Cc: linux-wireless@vger.kernel.org, Stefan Hansson , Arend van Spriel References: <20210804153434.3429348-1-linus.walleij@linaro.org> From: Dmitry Osipenko Message-ID: <74e24409-aeb2-5297-6888-7af2b1126ccd@gmail.com> Date: Thu, 5 Aug 2021 04:35:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210804153434.3429348-1-linus.walleij@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org 04.08.2021 18:34, Linus Walleij пишет: > + bool tested_board_variant; What about s/tested/tried/? > void (*done)(struct device *dev, int err, struct brcmf_fw_request *req); > }; > > -static void brcmf_fw_request_done(const struct firmware *fw, void *ctx); > - > #ifdef CONFIG_EFI > /* In some cases the EFI-var stored nvram contains "ccode=ALL" or "ccode=XV" > * to specify "worldwide" compatible settings, but these 2 ccode-s do not work > @@ -638,11 +637,25 @@ static int brcmf_fw_request_firmware(const struct firmware **fw, > return request_firmware(fw, cur->path, fwctx->dev); > } > > -static void brcmf_fw_request_done(const struct firmware *fw, void *ctx) > +static void brcmf_fw_request_done_first(const struct firmware *fw, void *ctx) Is it really worthwhile to rename this function? There is no "done_second".