From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E45DC43387 for ; Thu, 17 Jan 2019 03:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B94920675 for ; Thu, 17 Jan 2019 03:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727708AbfAQDG2 (ORCPT ); Wed, 16 Jan 2019 22:06:28 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2179 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727185AbfAQDG1 (ORCPT ); Wed, 16 Jan 2019 22:06:27 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C44E097AE6C89CDCF6C1; Thu, 17 Jan 2019 11:06:25 +0800 (CST) Received: from [127.0.0.1] (10.65.91.35) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.408.0; Thu, 17 Jan 2019 11:06:19 +0800 Subject: Re: Question about default m88e1510 LED configuration of marvell phy To: "Wang, Dongsheng" , Andrew Lunn CC: Andrew Lunn , David Miller , "netdev@vger.kernel.org" , "Zhuangyuzeng (Yisen)" , Salil Mehta , "lipeng (Y)" , Yunsheng Lin , Dengweiwei References: <1a4ecb58-7835-85f9-51b7-88b0cfca7eba@huawei.com> <20190115033910.GA11722@lunn.ch> <3b4b16139b974dcf8a8d6d5223e0b901@HXTBJIDCEMVIW02.hxtcorp.net> From: "shenjian (K)" Message-ID: <74ed40b7-d644-4725-f5ec-0a9c97e441ad@huawei.com> Date: Thu, 17 Jan 2019 11:06:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <3b4b16139b974dcf8a8d6d5223e0b901@HXTBJIDCEMVIW02.hxtcorp.net> Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.65.91.35] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 在 2019/1/15 17:08, Wang, Dongsheng 写道: > On 2019/1/15 14:41, shenjian (K) wrote: >> >> 在 2019/1/15 11:39, Andrew Lunn 写道: >>> On Tue, Jan 15, 2019 at 11:07:17AM +0800, shenjian (K) wrote: >>>> Hi, all >>>> We encounted a problem when using the marvel 88e151x phy driver, the >>>> link(LED[0])/ack(LED[1]) leds worked abnormally since we updated our kernel to v4.19. >>>> The act led kept on and never blink. It works well when we use genphy driver, aslo >>>> works well when use marvell phy in kernel v4.18. >>>> >>>> I found that the default led configuration had been changed to 0x1177 >>>> by commit commit 077772468ec1(net: phy: marvell: change default m88e1510 LED configuration). >>> It is a difficult job deciding what the driver should configure. I >>> would actually prefer to keeps with the reset default, which would be >>> 0x101e according to the datasheet. >>> >>> If you are using device tree, you have the option of poking values >>> into registers, using marvell,reg-init. There are a few examples you >>> can copy. Doing that guarantees you have the configuration you want. >>> >>> Andrew >>> >>> . >>> >> Thanks, Andrew. >> >> But we are using acpi mode, is there any ohter way to poke values into registers ? > > You can describe property in ACPI _DSD. And parse then in > marvell_config_init just like of. > > Cheers > Dongsheng > > > > . > I will check is this supported by our bios. Thanks, Dongsheng.