From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu: print where we get the vbios image from
Date: Tue, 11 Aug 2020 18:44:09 +0200 [thread overview]
Message-ID: <74eff14a-9a37-1d92-da49-fc3e53d5bf5e@gmail.com> (raw)
In-Reply-To: <20200811160457.1073325-1-alexander.deucher@amd.com>
Am 11.08.20 um 18:04 schrieb Alex Deucher:
> ACPI, ROM, PCI BAR, etc.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 28 ++++++++++++++++++------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index b1172d93c99c..6333cada1e09 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -417,26 +417,40 @@ static inline bool amdgpu_acpi_vfct_bios(struct amdgpu_device *adev)
>
> bool amdgpu_get_bios(struct amdgpu_device *adev)
> {
> - if (amdgpu_atrm_get_bios(adev))
> + if (amdgpu_atrm_get_bios(adev)) {
> + dev_info(adev->dev, "Fetched VBIOS from ATRM\n");
> goto success;
> + }
>
> - if (amdgpu_acpi_vfct_bios(adev))
> + if (amdgpu_acpi_vfct_bios(adev)) {
> + dev_info(adev->dev, "Fetched VBIOS from VFCT\n");
> goto success;
> + }
>
> - if (igp_read_bios_from_vram(adev))
> + if (igp_read_bios_from_vram(adev)) {
> + dev_info(adev->dev, "Fetched VBIOS from VRAM BAR\n");
> goto success;
> + }
>
> - if (amdgpu_read_bios(adev))
> + if (amdgpu_read_bios(adev)) {
> + dev_info(adev->dev, "Fetched VBIOS from ROM BAR\n");
> goto success;
> + }
>
> - if (amdgpu_read_bios_from_rom(adev))
> + if (amdgpu_read_bios_from_rom(adev)) {
> + dev_info(adev->dev, "Fetched VBIOS from ROM\n");
> goto success;
> + }
>
> - if (amdgpu_read_disabled_bios(adev))
> + if (amdgpu_read_disabled_bios(adev)) {
> + dev_info(adev->dev, "Fetched VBIOS from disabled ROM BAR\n");
> goto success;
> + }
>
> - if (amdgpu_read_platform_bios(adev))
> + if (amdgpu_read_platform_bios(adev)) {
> + dev_info(adev->dev, "Fetched VBIOS from platform\n");
> goto success;
> + }
>
> DRM_ERROR("Unable to locate a BIOS ROM\n");
> return false;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-08-11 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 16:04 [PATCH] drm/amdgpu: print where we get the vbios image from Alex Deucher
2020-08-11 16:04 ` [PATCH] drm/amdgpu: note what type of reset we are using Alex Deucher
2020-08-11 16:17 ` Nirmoy
2020-08-12 2:16 ` Quan, Evan
2020-08-11 16:44 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74eff14a-9a37-1d92-da49-fc3e53d5bf5e@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.