From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4F4026AE0; Sat, 17 Feb 2024 15:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708184726; cv=none; b=pp1EsPLWjyMxNNST4ZJQJaz8cMG2mFLQTKFJbxdpBoE5MCQXGTKT5Xxg0ZpE4uGmC3yLwSwk6rSJGGyzyYbNVCYz2F+EfHuviL0cdSAll3rriDWv/UNNSGsQOG8Bn5tWlRCtW6gXw4Yk254QvlH9dobH0sSK6IzQIW2zJhkTGhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708184726; c=relaxed/simple; bh=Pn42SOug1SeuUwFUNDXOg1b5cYz8sTuWFoTywf+qOKY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=bgnIIn9LndHF1Cgt6cJOgsIKp8rEY2drwLIkbLjY5fgLLZ2Vtl5IJaJDk5hCnHTM5/MOoCUl3vWc7FYBz8eStgds5zyLPtYgm3i36ZYh3ybWwG9EQMFvgXLLRIfuC1O+T1Cjd78pqRa5Cpbs2VS0yMKbdS5P6dz7qprCFuNEIis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=okau/IxH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="okau/IxH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41HErtwF021695; Sat, 17 Feb 2024 15:45:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=DXamrJ4SOCBYjAmqzjslC7fuieKptJ71ZD0J10qEzJY=; b=ok au/IxHG6vmukrkgzYuPL3h8FpnVdAmse3RBs0N4kUoriRkPEDdDk20DACTtX2OFP ZVreTFt1JcspCYWUm65q73nsp9l832XpEtfarCRzBzvvpI11JxqPdugZ2nBA1QHW Q990VthQcENY5dL1DE+Hcigf8CSBz4FM+S12RYcgLSH7/wWtLXcEK7PrcF9TH/iA mN6ltLbQ0N5mkT0sY6yPW9X9r32vpDKpHaULgcriVvowOAd5GZAtmetbyM3cV6FT SsQKf8Po2jq5iJmItFWX7M9VT0m8vf/h1/LAVzAHthq2qhO8dIYWA3xKN3N0YZ1w NcJRNNi0D12729w9Ku9w== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wamvy8pfj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Feb 2024 15:45:07 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41HFj6w6032663 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Feb 2024 15:45:06 GMT Received: from [10.216.61.130] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sat, 17 Feb 2024 07:44:59 -0800 Message-ID: <74f585c2-d220-4324-96eb-1a945fef9608@quicinc.com> Date: Sat, 17 Feb 2024 21:14:55 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Content-Language: en-US To: Dmitry Baryshkov CC: Andrew Lunn , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , , , , , , References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> <7a69a68d-44c2-4589-b286-466d2f2a0809@lunn.ch> <11fda059-3d8d-4030-922a-8fef16349a65@quicinc.com> <17e2400e-6881-4e9e-90c2-9c4f77a0d41d@lunn.ch> <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: uxrDFjrn2vWVtpU3K4Bwl7Q9vQyozlnx X-Proofpoint-GUID: uxrDFjrn2vWVtpU3K4Bwl7Q9vQyozlnx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-17_13,2024-02-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 impostorscore=0 clxscore=1015 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0 mlxlogscore=804 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402170128 >> Reason being, to access the NSSCC clocks, these GCC clocks >> (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk) >> should be turned ON. But CCF disables these clocks as well due to the >> lack of consumer. > > This means that NSSCC is also a consumer of those clocks. Please fix > both DT and nsscc driver to handle NSSNOC clocks. Thanks Dmitry. I shall include these clocks in the NSSCC DT node and enable the same in the NSSCC driver probe. > >>> Once you have actual drivers, this should solve itself, the drivers >>> will consume the clocks. >> >> >> Given that, NSSCC is being built as module, there is no issue in booting >> the kernel. But if you do insmod of the nsscc-ipq5332.ko, system will >> reset. >> >> Without the networking drivers, there is no need to install this module. >> And as you stated, once the drivers are available, there will be no issues. >> >> So can I explain the shortcomings of installing this module without the >> networking drivers in cover letter and drop this patch all together? > > No. Using allyesconfig or allmodconfig and installing the full modules > set should work. > Okay, Got it. Thanks for the information. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 984ECC48BC4 for ; Sat, 17 Feb 2024 15:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wBxgVrnScGVWDYee39Q7jn5jsCGC36jpf73AmJWhnjQ=; b=ydoq2QQUTy2wF6 rUiubP3bNF/s/aOfJWpwYhLHKu7yj+wJIi4k8V55hF04+t5nxs7g9Sl1Up2NFyoGrqo0dPSUGiiDu 2iKRpWZ/XcfYZz+KMo2Al2YWzgDKh8V35XzZt89MwjcDiUCK0HcLMRrB4GdtwvoBg5MM6XtIQc7gl 5ExOOisY1rR2m3+IzmBXTkbPwRn817aw3GMh0FzY8yOCwfj+d+aiEc+ulk46Xd/7LdnULfVLRS/Dq fRHV9mKMfGoIc5TI3WqWYcosfGeoX6IhxZBp2VD8bg8a0igxmTRrhEbR2evFWDAmN8KRn0uSv6bVi 6VG0+cWaS6W3DKzmGRhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbMsV-00000005wBk-3vsY; Sat, 17 Feb 2024 15:45:23 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbMsS-00000005wAn-1DQ0 for linux-arm-kernel@lists.infradead.org; Sat, 17 Feb 2024 15:45:22 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41HErtwF021695; Sat, 17 Feb 2024 15:45:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=DXamrJ4SOCBYjAmqzjslC7fuieKptJ71ZD0J10qEzJY=; b=ok au/IxHG6vmukrkgzYuPL3h8FpnVdAmse3RBs0N4kUoriRkPEDdDk20DACTtX2OFP ZVreTFt1JcspCYWUm65q73nsp9l832XpEtfarCRzBzvvpI11JxqPdugZ2nBA1QHW Q990VthQcENY5dL1DE+Hcigf8CSBz4FM+S12RYcgLSH7/wWtLXcEK7PrcF9TH/iA mN6ltLbQ0N5mkT0sY6yPW9X9r32vpDKpHaULgcriVvowOAd5GZAtmetbyM3cV6FT SsQKf8Po2jq5iJmItFWX7M9VT0m8vf/h1/LAVzAHthq2qhO8dIYWA3xKN3N0YZ1w NcJRNNi0D12729w9Ku9w== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wamvy8pfj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Feb 2024 15:45:07 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41HFj6w6032663 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Feb 2024 15:45:06 GMT Received: from [10.216.61.130] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sat, 17 Feb 2024 07:44:59 -0800 Message-ID: <74f585c2-d220-4324-96eb-1a945fef9608@quicinc.com> Date: Sat, 17 Feb 2024 21:14:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Content-Language: en-US To: Dmitry Baryshkov CC: Andrew Lunn , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , , , , , , References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> <7a69a68d-44c2-4589-b286-466d2f2a0809@lunn.ch> <11fda059-3d8d-4030-922a-8fef16349a65@quicinc.com> <17e2400e-6881-4e9e-90c2-9c4f77a0d41d@lunn.ch> <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> From: Kathiravan Thirumoorthy In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: uxrDFjrn2vWVtpU3K4Bwl7Q9vQyozlnx X-Proofpoint-GUID: uxrDFjrn2vWVtpU3K4Bwl7Q9vQyozlnx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-17_13,2024-02-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 impostorscore=0 clxscore=1015 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0 mlxlogscore=804 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402170128 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240217_074520_485911_758CAA84 X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >> Reason being, to access the NSSCC clocks, these GCC clocks >> (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk) >> should be turned ON. But CCF disables these clocks as well due to the >> lack of consumer. > > This means that NSSCC is also a consumer of those clocks. Please fix > both DT and nsscc driver to handle NSSNOC clocks. Thanks Dmitry. I shall include these clocks in the NSSCC DT node and enable the same in the NSSCC driver probe. > >>> Once you have actual drivers, this should solve itself, the drivers >>> will consume the clocks. >> >> >> Given that, NSSCC is being built as module, there is no issue in booting >> the kernel. But if you do insmod of the nsscc-ipq5332.ko, system will >> reset. >> >> Without the networking drivers, there is no need to install this module. >> And as you stated, once the drivers are available, there will be no issues. >> >> So can I explain the shortcomings of installing this module without the >> networking drivers in cover letter and drop this patch all together? > > No. Using allyesconfig or allmodconfig and installing the full modules > set should work. > Okay, Got it. Thanks for the information. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel