From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 2/2] arch: ensure idle domain is not left privileged
Date: Tue, 5 Apr 2022 08:24:50 -0400 [thread overview]
Message-ID: <74f71b63-d8da-d920-a679-e53340152b80@apertussolutions.com> (raw)
In-Reply-To: <f1c3923a-9201-c200-1b1e-9a258d47e64a@suse.com>
On 4/5/22 04:26, Jan Beulich wrote:
> On 31.03.2022 01:05, Daniel P. Smith wrote:
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -589,6 +589,9 @@ static void noinline init_done(void)
>> void *va;
>> unsigned long start, end;
>>
>> + /* Ensure idle domain was not left privileged */
>> + ASSERT(current->domain->is_privileged == false) ;
>
> I think this should be stronger than ASSERT(); I'd recommend calling
> panic(). Also please don't compare against "true" or "false" - use
> ordinary boolean operations instead (here it would be
> "!current->domain->is_privileged").
Ack.
v/r,
dps
prev parent reply other threads:[~2022-04-05 12:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 23:05 [PATCH 0/2] Introduce XSM ability for domain privilege escalation Daniel P. Smith
2022-03-30 23:05 ` [PATCH 1/2] xsm: add ability to elevate a domain to privileged Daniel P. Smith
2022-03-31 12:36 ` Roger Pau Monné
2022-04-01 17:52 ` Julien Grall
2022-04-04 8:08 ` Roger Pau Monné
2022-04-04 12:24 ` Jan Beulich
2022-04-04 14:21 ` Daniel P. Smith
2022-04-04 15:12 ` Roger Pau Monné
2022-04-04 15:17 ` Jan Beulich
2022-04-04 16:08 ` Daniel P. Smith
2022-04-05 7:42 ` Roger Pau Monné
2022-04-05 12:06 ` Daniel P. Smith
2022-04-05 15:01 ` Roger Pau Monné
2022-03-31 13:16 ` Jason Andryuk
2022-04-04 15:33 ` Daniel P. Smith
2022-04-05 17:17 ` Jason Andryuk
2022-04-05 19:05 ` Daniel P. Smith
2022-04-06 7:06 ` Jan Beulich
2022-04-06 8:46 ` Roger Pau Monné
2022-04-06 8:48 ` Jan Beulich
2022-04-06 9:09 ` Roger Pau Monné
2022-04-06 9:16 ` Jan Beulich
2022-04-06 9:40 ` Roger Pau Monné
2022-04-06 12:31 ` Jason Andryuk
2022-04-01 17:53 ` Julien Grall
2022-03-30 23:05 ` [PATCH 2/2] arch: ensure idle domain is not left privileged Daniel P. Smith
2022-03-31 12:46 ` Roger Pau Monné
2022-03-31 12:54 ` Julien Grall
2022-03-31 20:30 ` Stefano Stabellini
2022-04-04 14:56 ` Daniel P. Smith
2022-04-05 8:26 ` Jan Beulich
2022-04-05 12:24 ` Daniel P. Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74f71b63-d8da-d920-a679-e53340152b80@apertussolutions.com \
--to=dpsmith@apertussolutions.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=jandryuk@gmail.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=scott.davis@starlab.io \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.