From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BEB1C4708D for ; Fri, 28 May 2021 12:54:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE5A16124B for ; Fri, 28 May 2021 12:54:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE5A16124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 560C882F13; Fri, 28 May 2021 14:54:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="CFJYz+yT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C9BA782F19; Fri, 28 May 2021 14:54:45 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1BBBC82F0D for ; Fri, 28 May 2021 14:54:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrice.chotard@foss.st.com Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14SCqL4a013196; Fri, 28 May 2021 14:54:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=BCAHnStUh9RGXkDxYnww0R+Yc9FwmuFdml0aE1dym5I=; b=CFJYz+yT1YXsyUP7Ybxiqc8mtWamHEwmrQhXsP4rw/DCJLQkn+FMH5OJs3MY3QpynPUw wUyjNrnRCH7+0KO48Xmpb2ITNivzTIyrohvj8a6Ft//iN8Se/kAhwpD9uKe4QVibAh1+ uh46NBgDz26RyLy7KkaTMSn2WzjZC/W4EFdZziM00IDiLwOZYnVLYi29hNtIQSSGHlbz /jYoE2hwbLrmx1NvGiy9EahHzMH5HwnfqsTb10Mnas7imSw3lSQyTEaZrHJ9MY94ubXI CkR5CnjKqVtAacf33sD/CC3E1wf2XaFPgqN6v3Lmqo37RCERYaNbAuSSGRKVHLndF55+ 9w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38tsq0jhw6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 14:54:42 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 12A3210002A; Fri, 28 May 2021 14:54:42 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 082672291B2; Fri, 28 May 2021 14:54:42 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.45) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 14:54:41 +0200 Subject: Re: [Uboot-stm32] [PATCH 09/10] dfu: add error callback To: Patrick Delaunay , CC: U-Boot STM32 , Lukasz Majewski References: <20210518131213.20343-1-patrick.delaunay@foss.st.com> <20210518151206.9.I36ae186249a121969b9ab6d3a7f62752091cf472@changeid> From: Patrice CHOTARD Message-ID: <74fc52e5-33f3-7256-6efe-b8160a1532fd@foss.st.com> Date: Fri, 28 May 2021 14:54:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210518151206.9.I36ae186249a121969b9ab6d3a7f62752091cf472@changeid> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-28_04:2021-05-27, 2021-05-28 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Patrick On 5/18/21 3:12 PM, Patrick Delaunay wrote: > Add error callback in dfu stack to manage some board specific > behavior on DFU targets. > > Signed-off-by: Patrick Delaunay > --- > > drivers/dfu/dfu.c | 12 ++++++++++++ > include/dfu.h | 11 +++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c > index 213a20e7bc..ff1859d946 100644 > --- a/drivers/dfu/dfu.c > +++ b/drivers/dfu/dfu.c > @@ -44,6 +44,14 @@ __weak void dfu_initiated_callback(struct dfu_entity *dfu) > { > } > > +/* > + * The purpose of the dfu_error_callback() function is to > + * provide callback for dfu user > + */ > +__weak void dfu_error_callback(struct dfu_entity *dfu, const char *msg) > +{ > +} > + > /* > * The purpose of the dfu_usb_get_reset() function is to > * provide information if after USB_DETACH request > @@ -342,6 +350,7 @@ int dfu_write(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) > printf("%s: Wrong sequence number! [%d] [%d]\n", > __func__, dfu->i_blk_seq_num, blk_seq_num); > dfu_transaction_cleanup(dfu); > + dfu_error_callback(dfu, "Wrong sequence number"); > return -1; > } > > @@ -366,6 +375,7 @@ int dfu_write(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) > ret = dfu_write_buffer_drain(dfu); > if (ret) { > dfu_transaction_cleanup(dfu); > + dfu_error_callback(dfu, "DFU write error"); > return ret; > } > } > @@ -375,6 +385,7 @@ int dfu_write(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) > pr_err("Buffer overflow! (0x%p + 0x%x > 0x%p)\n", dfu->i_buf, > size, dfu->i_buf_end); > dfu_transaction_cleanup(dfu); > + dfu_error_callback(dfu, "Buffer overflow"); > return -1; > } > > @@ -386,6 +397,7 @@ int dfu_write(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) > ret = dfu_write_buffer_drain(dfu); > if (ret) { > dfu_transaction_cleanup(dfu); > + dfu_error_callback(dfu, "DFU write error"); > return ret; > } > } > diff --git a/include/dfu.h b/include/dfu.h > index d18b701728..1963e9ffb9 100644 > --- a/include/dfu.h > +++ b/include/dfu.h > @@ -383,6 +383,17 @@ void dfu_initiated_callback(struct dfu_entity *dfu); > */ > void dfu_flush_callback(struct dfu_entity *dfu); > > +/** > + * dfu_error_callback() - weak callback called at the DFU write error > + * > + * It is a callback function called by DFU stack after DFU write error. > + * This function allows to manage some board specific behavior on DFU targets > + * > + * @dfu: pointer to the dfu_entity which cause the error > + * @msg: the message of the error > + */ > +void dfu_error_callback(struct dfu_entity *dfu, const char *msg); > + > int dfu_transaction_initiate(struct dfu_entity *dfu, bool read); > void dfu_transaction_cleanup(struct dfu_entity *dfu); > > Reviewed-by: Patrice Chotard Thanks Patrice