From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335C7C433DB for ; Fri, 12 Mar 2021 21:04:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81E3164F2A for ; Fri, 12 Mar 2021 21:04:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81E3164F2A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ESuso+jbgZAJd48Y+oBmcBFcNPPrtARSnRB6HfSyytA=; b=qqXZUEHSTebj/d6RhXwGNZ0JK kpMzk9m4R39nZ8YxJOzOQ2uHivMdFhEGGmYeBTPhEERMPMW5m7ioCfjCV3ghTj0Vys5l2VNAqfpHZ Zh6YuI6zH/z9vlurraTMDl1njnbgfdS4qu7SvEaDYAY+DAzuL/6Beg6FzfEeq1uSqv2B9MZCB8v4K 6cvr3ErRgQllgE+dgCzQsYQ1VeK/3/pMBsv/ZTFJcBn86MUsyZC4gC+Tw5dyWJMS/JAaKezg9QsXV sw3b653jjxekcCcmAMyFpiIVXAlY/p4O2uYrF5012ewyds73FgjBn25SlnUB/bB3YlP2m1r4zGBbs SB1CWS+Bg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKouc-00CPXk-8Z; Fri, 12 Mar 2021 21:01:34 +0000 Received: from mail-out.m-online.net ([212.18.0.9]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKouQ-00CPVA-Rw for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 21:01:30 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DxysY3HwTz1qs3D; Fri, 12 Mar 2021 22:01:21 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DxysY2gcSz1qr5L; Fri, 12 Mar 2021 22:01:21 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id EzMvmnkDGqup; Fri, 12 Mar 2021 22:01:19 +0100 (CET) X-Auth-Info: AiP1nTuJos6/PPbqVqZSKDq6GNDatk0GM6tOh3NzwTw= Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 12 Mar 2021 22:01:19 +0100 (CET) Subject: Re: [PATCH] ARM: dts: stm32: Fill GPIO line names on AV96 To: Christoph Niedermaier , "linux-arm-kernel@lists.infradead.org" , "linus.walleij@linaro.org" Cc: Alexandre Torgue , Patrice Chotard , Patrick Delaunay , Maxime Coquelin , "linux-stm32@st-md-mailman.stormreply.com" References: <20200724101610.146403-1-marex@denx.de> <495b2f6b-04b7-c1eb-7aed-cd55636bef46@denx.de> <4530980295044f8ab9c1cfe14e02f90f@dh-electronics.com> <6616e8b0-2b7d-a157-c24f-0493ce03c45b@denx.de> <86beeb51e9594b14ac0f449495b46736@dh-electronics.com> From: Marek Vasut Message-ID: <7504da89-63a7-1b80-3159-a0346535137e@denx.de> Date: Fri, 12 Mar 2021 22:01:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <86beeb51e9594b14ac0f449495b46736@dh-electronics.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_210125_083035_AE308B0D X-CRM114-Status: GOOD ( 28.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/12/21 6:38 PM, Christoph Niedermaier wrote: > From: Marek Vasut [mailto:marex@denx.de] > Sent: Friday, March 12, 2021 5:17 PM >> To: Christoph Niedermaier ; linux-arm- >> kernel@lists.infradead.org; linus.walleij@linaro.org >> Cc: Alexandre Torgue ; Patrice Chotard >> ; Patrick Delaunay ; >> Maxime Coquelin ; linux-stm32@st-md- >> mailman.stormreply.com >> Subject: Re: [PATCH] ARM: dts: stm32: Fill GPIO line names on AV96 >> >> ACHTUNG: Diese E-Mail kommt aus dem Internet und nicht aus unserem >> Firmennetzwerk! >> >> >> >> On 3/12/21 4:17 PM, Christoph Niedermaier wrote: >>> From: Marek Vasut [mailto:marex@denx.de] >>> Sent: Thursday, August 6, 2020 9:30 AM >>> >>>> On 8/6/20 9:09 AM, Christoph Niedermaier wrote: >>>>> From: Marek Vasut >>>>> Sent: Friday, July 24, 2020 12:16 PM >>>>>> >>>>>> Fill in the custom GPIO line names used by DH. >>>>>> >>>>> [...] >>>>>> +&gpioa { >>>>>> + gpio-line-names = "", "", "", "", >>>>>> + "", "", "", "", >>>>>> + "", "", "", "DH-GPIO-K", >>>>>> + "DH-GPIO-I", "", "DH-GPIO-A", ""; >>>>>> +}; >>>>>> + >>>>> [...] >>>>> >>>>> We have been using the GPIO names at DH electronics for some time and also >>>>> on other SOMs, but have not yet streamed them. We started with the naming >>>>> only with a capital letter "A-W" since then without problems. To avoid a >>>>> hard cut or patching for us and our customers it would be good if we could >>>>> use the same naming in the mainline kernel as well. Marek, we would be >>>>> happy if you would adopt our valued GPIO naming in your patch. >>>> >>>> My counter-argument to this is that the naming should be unique and >>>> provide a hint where those GPIO lines come from, so maybe even DH-GPIO-n >>>> should rather be DHCOM-n . I can't say I'm particularly fond of the >>>> plain 'n' naming of GPIO lines, because then the GPIO label (and e.g. >>>> listing in libgpiod tools) does not give any hint what the GPIO is or >>>> where it comes from. Also, I worry a plain 'n' naming might clash with >>>> other GPIO IPs easily, while a more unique name can not. >>> >>> Hello Marek, >>> >>> after an internal discussion, we decided the following: >>> >>> Could you update the patch for the Avenger96 to the GPIO naming "AV96-n". >>> >>> Moreover for the SOM layer (stm32mp15xx-dhcom-som.dtsi) we would prefer >>> "DHCOM-n". It would be nice if you could create a patch for it. >> >> I don't think we should have any SoM-side gpio-line-names, because once >> you plug the SoM into new carrier board, the gpio-lane-names will no >> longer make sense. So, I think all the gpio-line-names should be >> implemented in the carrier board DTS. > > The idea is to define the GPIO names on the SOM layer and then > overwrite them on the carrier board DTS if needed. If there is no > naming on the carrier board, at least you have access via the DHCOM > GPIO names. The DHCOM GPIO names are standardized, so that you can > be sure that the assignment to a pin always fits. So I'll pose another question here to the GPIO maintainers. Is it OK to define gpio-line-names in SoM DTSI even for pins which will not be used as GPIOs e.g. because they are muxed differently in the carrier board DTS ? If that is OK, then the above approach is then also OK. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel