From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753200AbdGNCL5 convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Jul 2017 22:11:57 -0400
Received: from nat-hk.nvidia.com ([203.18.50.4]:65533 "EHLO nat-hk.nvidia.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752774AbdGNCL4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Jul 2017 22:11:56 -0400
X-PGP-Universal: processed;
        by hkpgpgate102.nvidia.com on Thu, 13 Jul 2017 19:11:55 -0700
Subject: Re: [PATCH 1/1 V2] media: usb: uvc: Fix incorrect timeout for Get
 Request
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
References: <1499669029-3412-1-git-send-email-jilin@nvidia.com>
 <3026364.oSOK2ZPSm0@avalon>
CC: <mchehab@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-media@vger.kernel.org>
From: Jim Lin <jilin@nvidia.com>
Message-ID: <75068995-ce49-dbac-76cb-f4fe911cb597@nvidia.com>
Date: Fri, 14 Jul 2017 10:11:53 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <3026364.oSOK2ZPSm0@avalon>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8BIT
X-Originating-IP: [10.19.108.129]
X-ClientProxiedBy: HKMAIL104.nvidia.com (10.18.16.13) To HKMAIL103.nvidia.com
 (10.18.16.12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017年07月11日 03:47, Laurent Pinchart wrote:
> Hi Jim,
>
> Thank you for the patch.
>
> On Monday 10 Jul 2017 14:43:49 Jim Lin wrote:
>> Section 9.2.6.4 of USB 2.0/3.x specification describes that
>> "device must be able to return the first data packet to host within
>> 500 ms of receipt of the request. For subsequent data packet, if any,
>> the device must be able to return them within 500 ms".
>>
>> This is to fix incorrect timeout and change it from 300 ms to 500 ms
>> to meet the timing specified by specification for Get Request.
>>
>> Signed-off-by: Jim Lin <jilin@nvidia.com>
>
> The patch looks good to me, so
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> but I'm curious, have you noticed issues with some devices in practice ?
>

Sometimes this device takes about 360 ms to respond.

usb 1-2: new high-speed USB device number 16
usb 1-2: New USB device found, idVendor=045e, idProduct=0772
usb 1-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
usb 1-2: Product: Microsoft�® LifeCam Studio(TM)
usb 1-2: Manufacturer: Microsoft
:
uvcvideo: Failed to query (GET_DEF) UVC control 2 on unit 4: -110 (exp. 2).

And it will be working well with correct timeout value.

--nvpublic