From: Marek Vasut <marek.vasut@gmail.com>
To: "Cyrille Pitchen" <cyrille.pitchen@atmel.com>,
"Joël Esponde" <joel.esponde@honeywell.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3] mtd: spi-nor: fix spansion quad enable
Date: Fri, 25 Nov 2016 16:08:15 +0100 [thread overview]
Message-ID: <751ced45-1d6c-2d2d-3ea8-bb6d6be1da4a@gmail.com> (raw)
In-Reply-To: <d08bf4d1-7667-1888-f9fa-ec63e4c9b249@atmel.com>
On 11/25/2016 03:50 PM, Cyrille Pitchen wrote:
> Hi Marek,
Hi,
> Le 25/11/2016 à 15:17, Marek Vasut a écrit :
>> On 11/23/2016 12:47 PM, Joël Esponde wrote:
>>> With the S25FL127S nor flash part, each writing to the configuration
>>> register takes hundreds of ms. During that time, no more accesses to
>>> the flash should be done (even reads).
>>>
>>> This commit adds a wait loop after the register writing until the flash
>>> finishes its work.
>>>
>>> This issue could make rootfs mounting fail when the latter was done too
>>> much closely to this quad enable bit setting step. And in this case, a
>>> driver as UBIFS may try to recover the filesystem and may broke it
>>> completely.
>>
>> Does this apply to all spansion chips or only to selected few ?
>>
>
> I've recently faced the very same issue with Winbond memories, which use
> the same procedure as Spansion to set the Quad Enable bit.
> More precisely, in my case it was some bare metal (bootloader) code but the
> issue was the same, there was no polling of busy bit from the Status
> Register after having set the QE bit in the Status Register 2 / Control
> Register 1. Then the next SPI command came too early and failed because the
> memory was actually still busy.
>
> I faced this issue with Winbond W25Q256 and W25M512.
So we can leave this code as is ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-11-25 15:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 13:43 [PATCH] mtd: spi-nor: fixed spansion quad enable Joël Esponde
2016-10-20 15:23 ` Cyrille Pitchen
2016-10-21 10:37 ` Esponde, Joel
2016-10-21 12:50 ` Cyrille Pitchen
2016-10-21 13:44 ` Cyrille Pitchen
2016-10-24 8:29 ` Esponde, Joel
2016-10-24 8:33 ` Esponde, Joel
2016-11-16 12:58 ` Cyrille Pitchen
2016-11-22 14:02 ` Esponde, Joel
2016-11-22 22:24 ` [PATCH v2] " Joël Esponde
2016-11-23 10:39 ` Cyrille Pitchen
2016-11-23 14:27 ` Esponde, Joel
2016-11-23 15:35 ` Marek Vasut
2016-11-23 18:21 ` Esponde, Joel
2016-11-23 11:47 ` [PATCH v3] mtd: spi-nor: fix " Joël Esponde
2016-11-23 14:35 ` Cyrille Pitchen
2016-11-25 14:17 ` Marek Vasut
2016-11-25 14:50 ` Cyrille Pitchen
2016-11-25 15:08 ` Marek Vasut [this message]
2016-11-25 16:01 ` Esponde, Joel
2016-11-25 16:43 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=751ced45-1d6c-2d2d-3ea8-bb6d6be1da4a@gmail.com \
--to=marek.vasut@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=joel.esponde@honeywell.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.