From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C744CCA479 for ; Mon, 4 Jul 2022 07:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232779AbiGDHHq (ORCPT ); Mon, 4 Jul 2022 03:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232631AbiGDHHl (ORCPT ); Mon, 4 Jul 2022 03:07:41 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B4A12717 for ; Mon, 4 Jul 2022 00:07:41 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o8GB2-0005bm-4f; Mon, 04 Jul 2022 09:07:24 +0200 Message-ID: <751e1ec6-2d34-44f6-a6c3-775df8a3cea2@pengutronix.de> Date: Mon, 4 Jul 2022 09:07:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support Content-Language: en-US To: Wei Fang , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: aisheng.dong@nxp.com, devicetree@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, sudeep.holla@arm.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org References: <20220704101056.24821-1-wei.fang@nxp.com> <20220704101056.24821-3-wei.fang@nxp.com> From: Ahmad Fatoum In-Reply-To: <20220704101056.24821-3-wei.fang@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Wei, On 04.07.22 12:10, Wei Fang wrote: > + clock_ext_rmii: clock-ext-rmii { > + compatible = "fixed-clock"; > + clock-frequency = <50000000>; > + #clock-cells = <0>; > + clock-output-names = "ext_rmii_clk"; > + }; > + > + clock_ext_ts: clock-ext-ts { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-output-names = "ext_ts_clk"; > + }; How are these SoC-specific? They sound like they belong into board DT. > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>, > + <&pcc4 IMX8ULP_CLK_ENET>, > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>, > + <&clock_ext_rmii>; > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref"; I think the default should be the other way round, assume MAC to provide reference clock and allow override on board-level if PHY does it instead. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E353C43334 for ; Mon, 4 Jul 2022 07:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RrpcOtN+5WgeAMv3aKM0GEia1BxsvqfR73u0va9aMx8=; b=Oes15lISRhXfa6 GP423pdTxdmkvR1uGJmuSZSJdPNyPdbUQ3pQ8d8vEVkNsj42JeVz2LjnQNN/FMWuuu/nlP4SsHc3a uLiJHVf/VCxrrLAf4KI9YDkbiPINJq5u0ofK6Kpp0zS/rIXhRa/pnPaDNOUjtiv/2CB2UP8+BQt4m 5dy8l77zwcRDFhlhAQIDmIHTuiihORDKhfxrxr2k1L7/fBQI6M8s71NBnyyE5DHZz+ypqwA2y+QDg kza72SIX8XMZFhNAIs8G3iLvGbdmNzQNFP40HNknw6qvjfVPvGBz2fqNBApLkeJc+NlxNx3f8kpFc daYqwUcHXTfAMHuypNhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8GBU-005Z1j-05; Mon, 04 Jul 2022 07:07:52 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8GBP-005YxX-O7 for linux-arm-kernel@lists.infradead.org; Mon, 04 Jul 2022 07:07:49 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o8GB2-0005bm-4f; Mon, 04 Jul 2022 09:07:24 +0200 Message-ID: <751e1ec6-2d34-44f6-a6c3-775df8a3cea2@pengutronix.de> Date: Mon, 4 Jul 2022 09:07:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support Content-Language: en-US To: Wei Fang , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: aisheng.dong@nxp.com, devicetree@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, sudeep.holla@arm.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org References: <20220704101056.24821-1-wei.fang@nxp.com> <20220704101056.24821-3-wei.fang@nxp.com> From: Ahmad Fatoum In-Reply-To: <20220704101056.24821-3-wei.fang@nxp.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_000747_831466_0149D952 X-CRM114-Status: GOOD ( 13.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Wei, On 04.07.22 12:10, Wei Fang wrote: > + clock_ext_rmii: clock-ext-rmii { > + compatible = "fixed-clock"; > + clock-frequency = <50000000>; > + #clock-cells = <0>; > + clock-output-names = "ext_rmii_clk"; > + }; > + > + clock_ext_ts: clock-ext-ts { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-output-names = "ext_ts_clk"; > + }; How are these SoC-specific? They sound like they belong into board DT. > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>, > + <&pcc4 IMX8ULP_CLK_ENET>, > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>, > + <&clock_ext_rmii>; > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref"; I think the default should be the other way round, assume MAC to provide reference clock and allow override on board-level if PHY does it instead. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel