From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FD2C433FE for ; Wed, 9 Dec 2020 16:38:00 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EA7A22210 for ; Wed, 9 Dec 2020 16:38:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EA7A22210 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.48585.85934 (Exim 4.92) (envelope-from ) id 1kn2TF-00087j-W1; Wed, 09 Dec 2020 16:37:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 48585.85934; Wed, 09 Dec 2020 16:37:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kn2TF-00087c-Sk; Wed, 09 Dec 2020 16:37:41 +0000 Received: by outflank-mailman (input) for mailman id 48585; Wed, 09 Dec 2020 16:37:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kn2TE-00087V-Ba for xen-devel@lists.xenproject.org; Wed, 09 Dec 2020 16:37:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kn2TB-0004kc-K3; Wed, 09 Dec 2020 16:37:37 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kn2TB-0001DO-CE; Wed, 09 Dec 2020 16:37:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=zq3qs2Y37oE2YD1FWHU1D6FEOZCIvFeODTkcNxNpPe0=; b=GEi5v+CU7P1Og1LNtjD5C36tJP CQfvxzQtU6B+2VNzXjKODp8yf7n3se3c2OoMdzQnkg8cPHpdyOerymW6oxMFE0NJdOuShuwXEeCkF 2qhVasAvWNQp0vTjl12n5Abp+lBVcM/tPXR6fm6L0Y0HSs3v+x8ZLToOKEnYytGxwcYI=; Subject: Re: [PATCH RFC 2/3] xen/domain: add domain hypfs directories To: Juergen Gross , xen-devel@lists.xenproject.org Cc: paul@xen.org, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20201209161618.309-1-jgross@suse.com> <20201209161618.309-3-jgross@suse.com> From: Julien Grall Message-ID: <75232058-4626-80cb-6f71-4ce5253f3ef6@xen.org> Date: Wed, 9 Dec 2020 16:37:35 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201209161618.309-3-jgross@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Juergen, On 09/12/2020 16:16, Juergen Gross wrote: > Add /domain/ directories to hypfs. Those are completely > dynamic, so the related hypfs access functions need to be implemented. > > Signed-off-by: Juergen Gross > --- > V3: > - new patch > --- > docs/misc/hypfs-paths.pandoc | 10 +++ > xen/common/Makefile | 1 + > xen/common/hypfs_dom.c | 137 +++++++++++++++++++++++++++++++++++ > 3 files changed, 148 insertions(+) > create mode 100644 xen/common/hypfs_dom.c > > diff --git a/docs/misc/hypfs-paths.pandoc b/docs/misc/hypfs-paths.pandoc > index e86f7d0dbe..116642e367 100644 > --- a/docs/misc/hypfs-paths.pandoc > +++ b/docs/misc/hypfs-paths.pandoc > @@ -34,6 +34,7 @@ not containing any '/' character. The names "." and ".." are reserved > for file system internal use. > > VALUES are strings and can take the following forms (note that this represents > +>>>>>>> patched This seems to be a left-over of a merge. > only the syntax used in this document): > > * STRING -- an arbitrary 0-delimited byte string. > @@ -191,6 +192,15 @@ The scheduling granularity of a cpupool. > Writing a value is allowed only for cpupools with no cpu assigned and if the > architecture is supporting different scheduling granularities. > [...] > + > +static int domain_dir_read(const struct hypfs_entry *entry, > + XEN_GUEST_HANDLE_PARAM(void) uaddr) > +{ > + int ret = 0; > + const struct domain *d; > + > + for_each_domain ( d ) This is definitely going to be an issue if you have a lot of domain running as Xen is not preemptible. I think the first step is to make sure that HYPFS can scale without hogging a pCPU for a long time. Cheers, -- Julien Grall