From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2668EC433EF for ; Tue, 22 Mar 2022 14:46:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238168AbiCVOrq (ORCPT ); Tue, 22 Mar 2022 10:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236277AbiCVOrj (ORCPT ); Tue, 22 Mar 2022 10:47:39 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEE176FA09; Tue, 22 Mar 2022 07:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1647960369; x=1679496369; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=zP725tvXUiO7zKOyNAbjmJfwuMlzSbKo9AwbYYlFB/U=; b=gxmJV7osb3tq9BvThiJENUb79TnL85WN3ES3AP6N44fswtIu+F8UVDkZ 2FlqtICeHbmk70FIa3kjvDZ0BrLDIEDiKlLoiS/N8wtwys4LlNLKiqkzt cslAjMA4p4yWehXQjcdxZqO5G0H5TucFXoVXc3WnC1o5ivCzspMw7fOhE fhSi4bQUvQh37+pgVeHQX6/PGJHfmzdBAouZWNQ7mUmzsa8z1QuSgILC3 O0JshWB2D83DIL6oJYWfFA6bCO6FNANVA76zUmZavqLZMJA0lg8YA3x+k kmoddcWSRCUEguCLDTVLdFz1tRrKOmPAv4Ph2I2+8FXHz8jPlpN4so+eg Q==; X-IronPort-AV: E=Sophos;i="5.90,201,1643698800"; d="scan'208";a="152834847" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Mar 2022 07:46:08 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 22 Mar 2022 07:46:08 -0700 Received: from CHE-LT-I21427LX.microchip.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Tue, 22 Mar 2022 07:46:02 -0700 Message-ID: <7526eff194e4dcfec1b8d88fc30b22aeb83e3100.camel@microchip.com> Subject: Re: [PATCH v9 net-next 02/11] dt-bindings: net: add mdio property From: Prasanna Vengateshan To: Rob Herring CC: , , , , , , , , , , , , Date: Tue, 22 Mar 2022 20:16:00 +0530 In-Reply-To: References: <20220318085540.281721-1-prasanna.vengateshan@microchip.com> <20220318085540.281721-3-prasanna.vengateshan@microchip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-03-21 at 18:27 -0500, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Mar 18, 2022 at 02:25:31PM +0530, Prasanna Vengateshan wrote: > > mdio bus is applicable to any switch hence it is added as per the below > > request, > > https://lore.kernel.org/netdev/1300f84832ef1c43ecb9edb311fb817e3aab5420.camel@microchip.com/ > > Quoting that thread: > > > Yes indeed, since this is a common property of all DSA switches, it can > > be defined or not depending on whether the switch does have an internal > > MDIO bus controller or not. > > Whether or not a switch has an MDIO controller or not is a property of > that switch and therefore 'mdio' needs to be documented in those switch > bindings. > > > > > Signed-off-by: Prasanna Vengateshan > > --- > >  Documentation/devicetree/bindings/net/dsa/dsa.yaml | 4 ++++ > >  1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml > > b/Documentation/devicetree/bindings/net/dsa/dsa.yaml > > index b9d48e357e77..0f8426e219eb 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml > > @@ -31,6 +31,10 @@ properties: > >        switch 1. <1 0> is cluster 1, switch 0. A switch not part of any > > cluster > >        (single device hanging off a CPU port) must not specify this property > >      $ref: /schemas/types.yaml#/definitions/uint32-array > > + > > +  mdio: > > +    $ref: /schemas/net/mdio.yaml# > > +    unevaluatedProperties: false > > From a schema standpoint, this bans every switch from adding additional > properties under an mdio node. Not likely what you want. > > Rob Thanks for the feedback. Do you mean that the 'unevaluatedProperties: false' to be removed, so that the additional properties can be added? or mdio is not supposed to be defined in the dsa.yaml ?