From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73263C433E0 for ; Wed, 24 Jun 2020 19:59:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 420CD20768 for ; Wed, 24 Jun 2020 19:59:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fYDfuA8w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 420CD20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joBYg-000402-Id for qemu-devel@archiver.kernel.org; Wed, 24 Jun 2020 15:59:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joBUe-0000Ej-A5 for qemu-devel@nongnu.org; Wed, 24 Jun 2020 15:55:36 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:60787 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joBUb-0005pN-Rb for qemu-devel@nongnu.org; Wed, 24 Jun 2020 15:55:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593028532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uZ6MlYtRovI2Ch+t/I8qWwlonBQhQemax8sG+PT10k0=; b=fYDfuA8wSX1hbTb+4qv47n2CdDKkeLiHBcRDcUwZiJO2fPfer3qw2rTzzxJJl2Ooo9XRSb yIurP7f30V8zRSTUFZDSUnU0CF2t4MfOe10FI5wmERn1IRaa6q1SE9yM/xnn5o+qf5wFe1 ByBzoEAvRVjevUaruW+ThygW4gYUx4M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-ciJbjozuOnW08vqU31radg-1; Wed, 24 Jun 2020 15:55:31 -0400 X-MC-Unique: ciJbjozuOnW08vqU31radg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1806100CCC0; Wed, 24 Jun 2020 19:55:29 +0000 (UTC) Received: from [10.3.114.107] (ovpn-114-107.phx2.redhat.com [10.3.114.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43D395BAC4; Wed, 24 Jun 2020 19:55:29 +0000 (UTC) Subject: Re: [PATCH 16/46] qemu-option: Make functions taking Error ** return bool, not void To: Markus Armbruster , qemu-devel@nongnu.org References: <20200624164344.3778251-1-armbru@redhat.com> <20200624164344.3778251-17-armbru@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <75354a5a-acb9-b937-be69-ff9ae82da17c@redhat.com> Date: Wed, 24 Jun 2020 14:55:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200624164344.3778251-17-armbru@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/24 01:59:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, vsementsov@virtuozzo.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/24/20 11:43 AM, Markus Armbruster wrote: > See recent commit "error: Document Error API usage rules" for > rationale. > > Signed-off-by: Markus Armbruster > --- > include/qemu/option.h | 16 ++++---- > blockdev.c | 5 ++- > util/qemu-option.c | 92 +++++++++++++++++++++++++------------------ > 3 files changed, 64 insertions(+), 49 deletions(-) > > -static void qemu_opts_from_qdict_entry(QemuOpts *opts, > +static bool qemu_opts_from_qdict_entry(QemuOpts *opts, > const QDictEntry *entry, > Error **errp) > { > const char *key = qdict_entry_key(entry); > QObject *obj = qdict_entry_value(entry); > - char buf[32], *tmp = NULL; > + char buf[32]; > + g_autofree char *tmp = NULL; A bit fancier than a straight mechanical conversion here, but it works. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org