From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F09C433E0 for ; Thu, 7 Jan 2021 22:51:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EE28235FA for ; Thu, 7 Jan 2021 22:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727858AbhAGWvN (ORCPT ); Thu, 7 Jan 2021 17:51:13 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:50948 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727722AbhAGWvM (ORCPT ); Thu, 7 Jan 2021 17:51:12 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 107MnUtN023753; Thu, 7 Jan 2021 16:49:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1610059770; bh=51yABxhCeAmEePY6q8Lluk9jwTGYnWzQRyoK2i9Ziv8=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=d/fCjMt0G30a1P6t/yUjo+j0I6KfhUGU3eixrTlkiNrNIdgH8rWlFHP4ir01EDSsM 6GJeb2hVM4fw61KS4pSpGcgIM0a1BOWb0v+vZtbbYshESRrq8z99p9TvABzRj5myGQ wQUZ+2R2EB5LGsUPUoVIO3TLbTGUDOBVcoaCj4nQ= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 107MnUDK083642 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Jan 2021 16:49:30 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 7 Jan 2021 16:49:29 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 7 Jan 2021 16:49:29 -0600 Received: from [10.250.33.36] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 107MnTKk110118; Thu, 7 Jan 2021 16:49:29 -0600 Subject: Re: [PATCH v2 0/5] Introduce PRU remoteproc consumer API To: Mathieu Poirier CC: Grzegorz Jaszczyk , , , , , , , , , , , , References: <20201216165239.2744-1-grzegorz.jaszczyk@linaro.org> <20210106232704.GE9149@xps15> <11303a1b-5ab4-def5-77b1-c500894c9c87@ti.com> <20210107224448.GB43045@xps15> From: Suman Anna Message-ID: <75365443-57e3-e2e0-5865-f78af9d5890b@ti.com> Date: Thu, 7 Jan 2021 16:49:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210107224448.GB43045@xps15> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 1/7/21 4:44 PM, Mathieu Poirier wrote: > On Wed, Jan 06, 2021 at 06:03:25PM -0600, Suman Anna wrote: >> Hi Mathieu, >> >> On 1/6/21 5:27 PM, Mathieu Poirier wrote: >>> On Wed, Dec 16, 2020 at 05:52:34PM +0100, Grzegorz Jaszczyk wrote: >>>> Hi All, >>>> >>>> The Programmable Real-Time Unit and Industrial Communication Subsystem >>>> (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit >>>> RISC cores (Programmable Real-Time Units, or PRUs) for program execution. >>>> >>>> There are 3 foundation components for PRUSS subsystem: the PRUSS platform >>>> driver, the PRUSS INTC driver and the PRUSS remoteproc driver. All were >>>> already merged and can be found under: >>>> 1) drivers/soc/ti/pruss.c >>>> Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >>>> 2) drivers/irqchip/irq-pruss-intc.c >>>> Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml >>>> 3) drivers/remoteproc/pru_rproc.c >>>> Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml >>>> >>>> The programmable nature of the PRUs provide flexibility to implement custom >>>> peripheral interfaces, fast real-time responses, or specialized data handling. >>>> Example of a PRU consumer drivers will be: >>>> - Software UART over PRUSS >>>> - PRU-ICSS Ethernet EMAC >>>> >>>> In order to make usage of common PRU resources and allow the consumer drivers to >>>> configure the PRU hardware for specific usage the PRU API is introduced. >>>> >>>> Patch #3 of this series depends on one not merged remteproc related patch [1]. >>>> >>>> Please see the individual patches for exact changes in each patch, following is >>>> the only change from v1: >>>> - Change the 'prus' property name to 'ti,prus' as suggested by Rob Herring, >>>> which influences patch #1 and patch #2 >>>> >>>> [1] https://patchwork.kernel.org/project/linux-remoteproc/patch/20201121030156.22857-3-s-anna@ti.com/ >>>> >>>> Best regards, >>>> Grzegorz >>>> >>>> Roger Quadros (1): >>>> remoteproc: pru: Add pru_rproc_set_ctable() function >>>> >>>> Suman Anna (2): >>>> dt-bindings: remoteproc: Add PRU consumer bindings >>>> remoteproc: pru: Deny rproc sysfs ops for PRU client driven boots >>>> >>>> Tero Kristo (2): >>>> remoteproc: pru: Add APIs to get and put the PRU cores >>>> remoteproc: pru: Configure firmware based on client setup >>>> >>>> .../bindings/remoteproc/ti,pru-consumer.yaml | 64 +++++ >>>> drivers/remoteproc/pru_rproc.c | 221 +++++++++++++++++- >>>> include/linux/pruss.h | 78 +++++++ >>> >>> This patchset is giving checkpatch.pl errors and as such will not go further >>> with this revision. >> >> Yeah, I am aware of those. Greg has intentionally skipped the checkpatch >> warnings around ENOTSUPP, based on some similar discussion on a different patch, >> https://lkml.org/lkml/2020/11/10/764. > > I only see input from Andy and Lars in the thread you point out, nothing from > Greg. I have also taken a look at the patch [1] that made checkpatch complain > about ENOTSUPP. From what I see in that commit log the goal is to prevent new > additions of ENOTSUPP to the kernel. > > Please modify and resend, otherwise I'm sure someone will send another patch to > fix it before the end of the cycle. Yeah ok. I will send out a v3. regards Suman > > Thanks, > Mathieu > > [1]. 6b9ea5ff5abd checkpatch: warn about uses of ENOTSUPP >> >> Let me know if you prefer that we change these to EOPNOTSUPP. >> >> regards >> Suman >> >>> >>>> 3 files changed, 360 insertions(+), 3 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml >>>> create mode 100644 include/linux/pruss.h >>>> >>>> -- >>>> 2.29.0 >>>> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D61B8C433E0 for ; Thu, 7 Jan 2021 22:51:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8570B235FA for ; Thu, 7 Jan 2021 22:51:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8570B235FA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=li2PAa898H/Exd9fix2ZqP0+DOsFQdRJrSsJCAwJyT0=; b=Vh+UX3/heXDfTizEFl5FooJ7S IkTptKiWJMTaE2a58EJjqWS7bryu5pNKG0zUS8uOqI2wpzUtiRygz3dMdbaL17sNAWyOPycugmlMl nEimnas+FpFBHWETBCYmA6o3XO4kjw3mUSbzLudnaz1GnoHZZVLIhxMBk1+7JMbGBChkALYMtVjkZ 5BelgDj7fqwERIcw9RwLJiEkvV4/62lTUwXmlRekWnoR62NeNfn5g0uMciIUw5xarJlH9eXQuh1mv iFeFTvoRQ2hFjWZoKgv8ZZNHBP2ino4JTURLXIt9/GX5kf/Z9/X65nEbZmsJVj/rR0o+T6AXT7I51 lOQIwU8sg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxe66-0003Ux-2F; Thu, 07 Jan 2021 22:49:38 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxe63-0003UU-48 for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 22:49:36 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 107MnUtN023753; Thu, 7 Jan 2021 16:49:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1610059770; bh=51yABxhCeAmEePY6q8Lluk9jwTGYnWzQRyoK2i9Ziv8=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=d/fCjMt0G30a1P6t/yUjo+j0I6KfhUGU3eixrTlkiNrNIdgH8rWlFHP4ir01EDSsM 6GJeb2hVM4fw61KS4pSpGcgIM0a1BOWb0v+vZtbbYshESRrq8z99p9TvABzRj5myGQ wQUZ+2R2EB5LGsUPUoVIO3TLbTGUDOBVcoaCj4nQ= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 107MnUDK083642 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Jan 2021 16:49:30 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 7 Jan 2021 16:49:29 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 7 Jan 2021 16:49:29 -0600 Received: from [10.250.33.36] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 107MnTKk110118; Thu, 7 Jan 2021 16:49:29 -0600 Subject: Re: [PATCH v2 0/5] Introduce PRU remoteproc consumer API To: Mathieu Poirier References: <20201216165239.2744-1-grzegorz.jaszczyk@linaro.org> <20210106232704.GE9149@xps15> <11303a1b-5ab4-def5-77b1-c500894c9c87@ti.com> <20210107224448.GB43045@xps15> From: Suman Anna Message-ID: <75365443-57e3-e2e0-5865-f78af9d5890b@ti.com> Date: Thu, 7 Jan 2021 16:49:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210107224448.GB43045@xps15> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_174935_551275_0C43FF40 X-CRM114-Status: GOOD ( 23.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, devicetree@vger.kernel.org, Grzegorz Jaszczyk , praneeth@ti.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, rogerq@kernel.org, robh+dt@kernel.org, ssantosh@kernel.org, linux-omap@vger.kernel.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/7/21 4:44 PM, Mathieu Poirier wrote: > On Wed, Jan 06, 2021 at 06:03:25PM -0600, Suman Anna wrote: >> Hi Mathieu, >> >> On 1/6/21 5:27 PM, Mathieu Poirier wrote: >>> On Wed, Dec 16, 2020 at 05:52:34PM +0100, Grzegorz Jaszczyk wrote: >>>> Hi All, >>>> >>>> The Programmable Real-Time Unit and Industrial Communication Subsystem >>>> (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit >>>> RISC cores (Programmable Real-Time Units, or PRUs) for program execution. >>>> >>>> There are 3 foundation components for PRUSS subsystem: the PRUSS platform >>>> driver, the PRUSS INTC driver and the PRUSS remoteproc driver. All were >>>> already merged and can be found under: >>>> 1) drivers/soc/ti/pruss.c >>>> Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >>>> 2) drivers/irqchip/irq-pruss-intc.c >>>> Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml >>>> 3) drivers/remoteproc/pru_rproc.c >>>> Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml >>>> >>>> The programmable nature of the PRUs provide flexibility to implement custom >>>> peripheral interfaces, fast real-time responses, or specialized data handling. >>>> Example of a PRU consumer drivers will be: >>>> - Software UART over PRUSS >>>> - PRU-ICSS Ethernet EMAC >>>> >>>> In order to make usage of common PRU resources and allow the consumer drivers to >>>> configure the PRU hardware for specific usage the PRU API is introduced. >>>> >>>> Patch #3 of this series depends on one not merged remteproc related patch [1]. >>>> >>>> Please see the individual patches for exact changes in each patch, following is >>>> the only change from v1: >>>> - Change the 'prus' property name to 'ti,prus' as suggested by Rob Herring, >>>> which influences patch #1 and patch #2 >>>> >>>> [1] https://patchwork.kernel.org/project/linux-remoteproc/patch/20201121030156.22857-3-s-anna@ti.com/ >>>> >>>> Best regards, >>>> Grzegorz >>>> >>>> Roger Quadros (1): >>>> remoteproc: pru: Add pru_rproc_set_ctable() function >>>> >>>> Suman Anna (2): >>>> dt-bindings: remoteproc: Add PRU consumer bindings >>>> remoteproc: pru: Deny rproc sysfs ops for PRU client driven boots >>>> >>>> Tero Kristo (2): >>>> remoteproc: pru: Add APIs to get and put the PRU cores >>>> remoteproc: pru: Configure firmware based on client setup >>>> >>>> .../bindings/remoteproc/ti,pru-consumer.yaml | 64 +++++ >>>> drivers/remoteproc/pru_rproc.c | 221 +++++++++++++++++- >>>> include/linux/pruss.h | 78 +++++++ >>> >>> This patchset is giving checkpatch.pl errors and as such will not go further >>> with this revision. >> >> Yeah, I am aware of those. Greg has intentionally skipped the checkpatch >> warnings around ENOTSUPP, based on some similar discussion on a different patch, >> https://lkml.org/lkml/2020/11/10/764. > > I only see input from Andy and Lars in the thread you point out, nothing from > Greg. I have also taken a look at the patch [1] that made checkpatch complain > about ENOTSUPP. From what I see in that commit log the goal is to prevent new > additions of ENOTSUPP to the kernel. > > Please modify and resend, otherwise I'm sure someone will send another patch to > fix it before the end of the cycle. Yeah ok. I will send out a v3. regards Suman > > Thanks, > Mathieu > > [1]. 6b9ea5ff5abd checkpatch: warn about uses of ENOTSUPP >> >> Let me know if you prefer that we change these to EOPNOTSUPP. >> >> regards >> Suman >> >>> >>>> 3 files changed, 360 insertions(+), 3 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml >>>> create mode 100644 include/linux/pruss.h >>>> >>>> -- >>>> 2.29.0 >>>> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel