From: Juergen Gross <jgross@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 0/2] vpci/msi: fix updating already bound MSI interrupts
Date: Tue, 8 May 2018 11:30:18 +0200 [thread overview]
Message-ID: <75378768-2fb2-1ec3-3091-62380224fb96@suse.com> (raw)
In-Reply-To: <20180508092359.6829-1-roger.pau@citrix.com>
On 08/05/18 11:23, Roger Pau Monne wrote:
> Hello,
>
> There's a bug in current vpci code for MSI emulation when updating an
> already bound interrupt. The code will disable and enable the interrupt
> in order to update the binding, which calls unmap_domain_pirq that
> disables the global MSI enable flag in the control register.
>
> In order to fix this incorrect behavior introduce a new update helper
> that should be used to update the bindings of an already enabled group
> of MSI interrupts.
>
> Thanks, Roger.
>
> Roger Pau Monne (2):
> vpci/msi: split code to bind pirq
> vpci/msi: fix update of bound MSI interrupts
>
> xen/arch/x86/hvm/vmsi.c | 96 +++++++++++++++++++++++++++++------------
> xen/drivers/vpci/msi.c | 3 +-
> xen/include/xen/vpci.h | 2 +
> 3 files changed, 71 insertions(+), 30 deletions(-)
>
I guess this is 4.11 material?
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-08 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 9:23 [PATCH 0/2] vpci/msi: fix updating already bound MSI interrupts Roger Pau Monne
2018-05-08 9:25 ` [PATCH 1/2] vpci/msi: split code to bind pirq Roger Pau Monne
2018-05-14 12:24 ` Jan Beulich
2018-05-14 14:15 ` Roger Pau Monné
2018-05-14 14:56 ` Jan Beulich
2018-05-14 15:00 ` Roger Pau Monné
2018-05-14 15:07 ` Jan Beulich
2018-05-08 9:25 ` [PATCH 2/2] vpci/msi: fix update of bound MSI interrupts Roger Pau Monne
2018-05-14 12:29 ` Jan Beulich
2018-05-14 14:27 ` Roger Pau Monné
2018-05-14 14:59 ` Jan Beulich
2018-05-08 9:30 ` Juergen Gross [this message]
2018-05-08 9:40 ` [PATCH 0/2] vpci/msi: fix updating already " Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75378768-2fb2-1ec3-3091-62380224fb96@suse.com \
--to=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.