From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4pIE-0005Fu-CX for qemu-devel@nongnu.org; Thu, 01 Aug 2013 05:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4pIC-0008Pk-UB for qemu-devel@nongnu.org; Thu, 01 Aug 2013 05:35:34 -0400 Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:46313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4pIC-0008P4-Cc for qemu-devel@nongnu.org; Thu, 01 Aug 2013 05:35:32 -0400 Date: Thu, 01 Aug 2013 10:35:17 +0100 From: Alex Bligh Message-ID: <753B6C66578E71C12F9DFD2A@Ximines.local> In-Reply-To: <391717867.8023244.1375347472193.JavaMail.root@redhat.com> References: <1375067768-11342-1-git-send-email-pingfank@linux.vnet.ibm.com> <1375067768-11342-4-git-send-email-pingfank@linux.vnet.ibm.com> <51F60C02.6020008@redhat.com> <51F65044.4040706@redhat.com> <51F78491.708@redhat.com> <391717867.8023244.1375347472193.JavaMail.root@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb Reply-To: Alex Bligh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , liu ping fan Cc: Kevin Wolf , Alex Bligh , Jan Kiszka , Stefan Hajnoczi , qemu-devel@nongnu.org, Anthony Liguori --On 1 August 2013 04:57:52 -0400 Paolo Bonzini wrote: > True, qemu_event basically works only when a single thread resets it. But > there is no race condition here because qemu_run_timers cannot be executed > concurrently by multiple threads (like aio_poll in your bottom half > patches). ... or, if rebasing on top of my patches, qemu_run_timers *can* be executed concurrently by mulitple threads, but in respect of any given QEMUTimerList, it will only be executed by one thread. -- Alex Bligh