From mboxrd@z Thu Jan  1 00:00:00 1970
From: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/2] drm/amdgpu: cleanup the VM code a bit more
Date: Wed, 30 Aug 2017 17:02:40 -0400
Message-ID: <75424237-1204-1fd1-a699-47476dbb6235@amd.com>
References: <1504100904-1527-1-git-send-email-deathsimple@vodafone.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <1504100904-1527-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
Content-Language: en-CA
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

SSB3YXMganVzdCBhYm91dCB0byBzZW5kIHRoZSBzYW1lIHBhdGNoLiBSZXZpZXdlZC1ieTogRmVs
aXggS3VlaGxpbmcKPEZlbGl4Lkt1ZWhsaW5nQGFtZC5jb20+CgoKT24gMjAxNy0wOC0zMCAwOTo0
OCBBTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBGcm9tOiBDaHJpc3RpYW4gS8O2bmlnIDxj
aHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4KPiBUaGUgc3JjIGlzbid0IHVzZWQgYW55IG1vcmUg
YWZ0ZXIgR0FSVCBoYWNrIHJlbW92YWwuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2
bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9h
bWQvYW1kZ3B1L2FtZGdwdV92bS5jIHwgMjAgKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxl
IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMgYi9kcml2ZXJzL2dwdS9k
cm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+IGluZGV4IDRjZGZiNzAuLmIwOGYwMzEgMTAwNjQ0
Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiArKysgYi9k
cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+IEBAIC0xNDc1LDcgKzE0NzUs
NiBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9mcmFnX3B0ZXMoc3RydWN0IGFtZGdwdV9wdGVfdXBk
YXRlX3BhcmFtcwkqcGFyYW1zLAo+ICAgKgo+ICAgKiBAYWRldjogYW1kZ3B1X2RldmljZSBwb2lu
dGVyCj4gICAqIEBleGNsdXNpdmU6IGZlbmNlIHdlIG5lZWQgdG8gc3luYyB0bwo+IC0gKiBAc3Jj
OiBhZGRyZXNzIHdoZXJlIHRvIGNvcHkgcGFnZSB0YWJsZSBlbnRyaWVzIGZyb20KPiAgICogQHBh
Z2VzX2FkZHI6IERNQSBhZGRyZXNzZXMgdG8gdXNlIGZvciBtYXBwaW5nCj4gICAqIEB2bTogcmVx
dWVzdGVkIHZtCj4gICAqIEBzdGFydDogc3RhcnQgb2YgbWFwcGVkIHJhbmdlCj4gQEAgLTE0ODks
NyArMTQ4OCw2IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX2ZyYWdfcHRlcyhzdHJ1Y3QgYW1kZ3B1
X3B0ZV91cGRhdGVfcGFyYW1zCSpwYXJhbXMsCj4gICAqLwo+ICBzdGF0aWMgaW50IGFtZGdwdV92
bV9ib191cGRhdGVfbWFwcGluZyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCQkJCSAg
ICAgICBzdHJ1Y3QgZG1hX2ZlbmNlICpleGNsdXNpdmUsCj4gLQkJCQkgICAgICAgdWludDY0X3Qg
c3JjLAo+ICAJCQkJICAgICAgIGRtYV9hZGRyX3QgKnBhZ2VzX2FkZHIsCj4gIAkJCQkgICAgICAg
c3RydWN0IGFtZGdwdV92bSAqdm0sCj4gIAkJCQkgICAgICAgdWludDY0X3Qgc3RhcnQsIHVpbnQ2
NF90IGxhc3QsCj4gQEAgLTE1MDcsNyArMTUwNSw2IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX2Jv
X3VwZGF0ZV9tYXBwaW5nKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAJbWVtc2V0KCZw
YXJhbXMsIDAsIHNpemVvZihwYXJhbXMpKTsKPiAgCXBhcmFtcy5hZGV2ID0gYWRldjsKPiAgCXBh
cmFtcy52bSA9IHZtOwo+IC0JcGFyYW1zLnNyYyA9IHNyYzsKPiAgCj4gIAkvKiBzeW5jIHRvIGV2
ZXJ5dGhpbmcgb24gdW5tYXBwaW5nICovCj4gIAlpZiAoIShmbGFncyAmIEFNREdQVV9QVEVfVkFM
SUQpKQo+IEBAIC0xNTQ3LDEzICsxNTQ0LDcgQEAgc3RhdGljIGludCBhbWRncHVfdm1fYm9fdXBk
YXRlX21hcHBpbmcoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAkvKiBvbmUgUERFIHdy
aXRlIGZvciBlYWNoIGh1Z2UgcGFnZSAqLwo+ICAJbmR3ICs9ICgobnB0ZXMgPj4gYWRldi0+dm1f
bWFuYWdlci5ibG9ja19zaXplKSArIDEpICogNjsKPiAgCj4gLQlpZiAoc3JjKSB7Cj4gLQkJLyog
b25seSBjb3B5IGNvbW1hbmRzIG5lZWRlZCAqLwo+IC0JCW5kdyArPSBuY21kcyAqIDc7Cj4gLQo+
IC0JCXBhcmFtcy5mdW5jID0gYW1kZ3B1X3ZtX2RvX2NvcHlfcHRlczsKPiAtCj4gLQl9IGVsc2Ug
aWYgKHBhZ2VzX2FkZHIpIHsKPiArCWlmIChwYWdlc19hZGRyKSB7Cj4gIAkJLyogY29weSBjb21t
YW5kcyBuZWVkZWQgKi8KPiAgCQluZHcgKz0gbmNtZHMgKiA3Owo+ICAKPiBAQCAtMTU3OCw3ICsx
NTY5LDcgQEAgc3RhdGljIGludCBhbWRncHVfdm1fYm9fdXBkYXRlX21hcHBpbmcoc3RydWN0IGFt
ZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAo+ICAJcGFyYW1zLmliID0gJmpvYi0+aWJzWzBdOwo+ICAK
PiAtCWlmICghc3JjICYmIHBhZ2VzX2FkZHIpIHsKPiArCWlmIChwYWdlc19hZGRyKSB7Cj4gIAkJ
dWludDY0X3QgKnB0ZTsKPiAgCQl1bnNpZ25lZCBpOwo+ICAKPiBAQCAtMTY1NSw3ICsxNjQ2LDcg
QEAgc3RhdGljIGludCBhbWRncHVfdm1fYm9fc3BsaXRfbWFwcGluZyhzdHJ1Y3QgYW1kZ3B1X2Rl
dmljZSAqYWRldiwKPiAgCQkJCSAgICAgIHN0cnVjdCBkcm1fbW1fbm9kZSAqbm9kZXMsCj4gIAkJ
CQkgICAgICBzdHJ1Y3QgZG1hX2ZlbmNlICoqZmVuY2UpCj4gIHsKPiAtCXVpbnQ2NF90IHBmbiwg
c3JjID0gMCwgc3RhcnQgPSBtYXBwaW5nLT5zdGFydDsKPiArCXVpbnQ2NF90IHBmbiwgc3RhcnQg
PSBtYXBwaW5nLT5zdGFydDsKPiAgCWludCByOwo+ICAKPiAgCS8qIG5vcm1hbGx5LGJvX3ZhLT5m
bGFncyBvbmx5IGNvbnRpYW5zIFJFQURBQkxFIGFuZCBXSVJURUFCTEUgYml0IGdvIGhlcmUKPiBA
QCAtMTcxMCw4ICsxNzAxLDcgQEAgc3RhdGljIGludCBhbWRncHVfdm1fYm9fc3BsaXRfbWFwcGlu
ZyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCQlhZGRyICs9IHBmbiA8PCBQQUdFX1NI
SUZUOwo+ICAKPiAgCQlsYXN0ID0gbWluKCh1aW50NjRfdCltYXBwaW5nLT5sYXN0LCBzdGFydCAr
IG1heF9lbnRyaWVzIC0gMSk7Cj4gLQkJciA9IGFtZGdwdV92bV9ib191cGRhdGVfbWFwcGluZyhh
ZGV2LCBleGNsdXNpdmUsCj4gLQkJCQkJCXNyYywgcGFnZXNfYWRkciwgdm0sCj4gKwkJciA9IGFt
ZGdwdV92bV9ib191cGRhdGVfbWFwcGluZyhhZGV2LCBleGNsdXNpdmUsIHBhZ2VzX2FkZHIsIHZt
LAo+ICAJCQkJCQlzdGFydCwgbGFzdCwgZmxhZ3MsIGFkZHIsCj4gIAkJCQkJCWZlbmNlKTsKPiAg
CQlpZiAocikKPiBAQCAtMTk3Miw3ICsxOTYyLDcgQEAgaW50IGFtZGdwdV92bV9jbGVhcl9mcmVl
ZChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCQlpZiAodm0tPnB0ZV9zdXBwb3J0X2F0
cykKPiAgCQkJaW5pdF9wdGVfdmFsdWUgPSBBTURHUFVfUFRFX1NZU1RFTTsKPiAgCj4gLQkJciA9
IGFtZGdwdV92bV9ib191cGRhdGVfbWFwcGluZyhhZGV2LCBOVUxMLCAwLCBOVUxMLCB2bSwKPiAr
CQlyID0gYW1kZ3B1X3ZtX2JvX3VwZGF0ZV9tYXBwaW5nKGFkZXYsIE5VTEwsIE5VTEwsIHZtLAo+
ICAJCQkJCQltYXBwaW5nLT5zdGFydCwgbWFwcGluZy0+bGFzdCwKPiAgCQkJCQkJaW5pdF9wdGVf
dmFsdWUsIDAsICZmKTsKPiAgCQlhbWRncHVfdm1fZnJlZV9tYXBwaW5nKGFkZXYsIHZtLCBtYXBw
aW5nLCBmKTsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
CmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=