From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C1F1C07E96 for ; Tue, 13 Jul 2021 04:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3793E6120A for ; Tue, 13 Jul 2021 04:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231891AbhGMFBp (ORCPT ); Tue, 13 Jul 2021 01:01:45 -0400 Received: from mga11.intel.com ([192.55.52.93]:8072 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbhGMFBn (ORCPT ); Tue, 13 Jul 2021 01:01:43 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10043"; a="207080215" X-IronPort-AV: E=Sophos;i="5.84,235,1620716400"; d="scan'208";a="207080215" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2021 21:58:54 -0700 X-IronPort-AV: E=Sophos;i="5.84,235,1620716400"; d="scan'208";a="492567823" Received: from mckumar-mobl.gar.corp.intel.com (HELO [10.215.202.204]) ([10.215.202.204]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2021 21:58:51 -0700 Subject: Re: [PATCH] net: wwan: iosm: switch from 'pci_' to 'dma_' API To: Christophe JAILLET , linuxwwan@intel.com, loic.poulain@linaro.org, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: "Kumar, M Chetan" Message-ID: <754912a3-d1fe-516f-d64b-e8a70a93d570@intel.com> Date: Tue, 13 Jul 2021 10:28:48 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/11/2021 8:21 PM, Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'ipc_protocol_init()' GFP_KERNEL can be used > because this flag is already used a few lines above and no lock is > acquired in the between. > > When memory is allocated in 'ipc_protocol_msg_prepipe_open()' GFP_ATOMIC > should be used because this flag is already used a few lines above. Thanks, Reviewed-by: M Chetan Kumar Regards, Chetan