From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f194.google.com ([209.85.192.194]:41692 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751334AbeBZWzR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 26 Feb 2018 17:55:17 -0500
Received: by mail-pf0-f194.google.com with SMTP id f80so2041601pfa.8
        for <netdev@vger.kernel.org>; Mon, 26 Feb 2018 14:55:17 -0800 (PST)
Subject: Re: [PATCH RFC net-next 10/20] net/ipv6: move expires into rt6_info
To: Wei Wang <weiwan@google.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Ido Schimmel <idosch@idosch.org>, roopa@cumulusnetworks.com,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Martin KaFai Lau <kafai@fb.com>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
References: <20180225194730.30063-1-dsahern@gmail.com>
 <20180225194730.30063-11-dsahern@gmail.com>
 <CAEA6p_DM3QcwMrrz4N=wZNJkAs2CY5tuZNVz=u6=a-WmbiepdA@mail.gmail.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <754ecc89-3e65-c37f-b5e0-4226eda47a83@gmail.com>
Date: Mon, 26 Feb 2018 15:55:14 -0700
MIME-Version: 1.0
In-Reply-To: <CAEA6p_DM3QcwMrrz4N=wZNJkAs2CY5tuZNVz=u6=a-WmbiepdA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2/26/18 3:28 PM, Wei Wang wrote:
>> @@ -213,11 +234,6 @@ static inline void rt6_set_expires(struct rt6_info *rt, unsigned long expires)
>>
>>  static inline void rt6_update_expires(struct rt6_info *rt0, int timeout)
>>  {
>> -       struct rt6_info *rt;
>> -
>> -       for (rt = rt0; rt && !(rt->rt6i_flags & RTF_EXPIRES); rt = rt->from);
>> -       if (rt && rt != rt0)
>> -               rt0->dst.expires = rt->dst.expires;
> 
> I was wondering if we need to retain the above logic. It makes sure
> dst.expires gets synced to its "parent" route. But  it might be hard
> because after your change, we can no longer use rt->from to refer to
> the "parent".

As I understand it, the FIB entries are cloned into pcpu, uncached and
exception routes. We should never have an rt6_info that ever points back
more than 1 level -- ie., the dst rt6_info points to a from representing
the original FIB entry.

After my change 'from' will still point to the FIB entry as a fib6_info
which has its own expires.

When I looked this code I was really confused. At best, the for loop
above sets rt0->dst.expires to some value based on the 'from' but then
the very next line calls dst_set_expires with the passed in timeout value.


> 
>>         dst_set_expires(&rt0->dst, timeout);
>>         rt0->rt6i_flags |= RTF_EXPIRES;
>>  }