From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B20C4338F for ; Thu, 29 Jul 2021 00:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4C1E6103C for ; Thu, 29 Jul 2021 00:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232837AbhG2Afr (ORCPT ); Wed, 28 Jul 2021 20:35:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232727AbhG2Afq (ORCPT ); Wed, 28 Jul 2021 20:35:46 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 603ACC061757 for ; Wed, 28 Jul 2021 17:35:44 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id d131-20020a1c1d890000b02902516717f562so2816692wmd.3 for ; Wed, 28 Jul 2021 17:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A91VsRhxCCDIXtkfswtebSEJGkGdWMGW8PkmZnFfEqA=; b=SvncO4Q5IeNq+bdgnrabIUmkNm8M0cS+oXjh52oWxM6ucE1MgJgrpPpRzS6DfOWLhK +UMuvIZp8L1pAIpoWX3lcrSdQL7TGpie938D0Kjg2uk3YBltmP4EnEYvWXhbAuFEPL90 UW28LH6i40CmJ1nj7nzsyo6pVgJ8l0Qwtb/R5I8vJ76DZy/cHvkZaTFRtcC5636j+ZF/ kyn5krxJNmHzfoFc8O7PcVLenwCgWvpQc5f3dTWnZZb9M5FjqsK/ULvV/X8lxOSI0Uwa +7yWsSJwVSQ/WxXuBuD7EXFCFbHWsUWPYRXVsV4g4XnygTCYCMq2uGgRLMG4JtxaErII ysDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A91VsRhxCCDIXtkfswtebSEJGkGdWMGW8PkmZnFfEqA=; b=LeEPOg5/4RF1XlgHOL3jzaZhJwbFRDL26F3n1Lng4ZvUAws8tOgbAeFMGCy9b8pLQ1 TXDZt570cHHDeX22Qy+16BB5MRcFge4+PKSs0wjPYXJ85To38zE61m4+qi95ZSFx5OJR 3nr0u5uY85BknneU8waTsqZZfXkU98kYPHhJvk23SnH4kEJLENbWqzjjtMfRDFxYbi/1 fbI9PcvM2pgE/5PyQ0lnchgq7hmOMR8dCQFb13dG7VXc6dB/Lh6n6DfTdug8T7kWXD64 wf5cN9s06AfnXPJA7Pl2IfP0dtzhG2v7K+beL8p7lsxQ7DYFbWop+KVAO8nv7IxZz16o f8OA== X-Gm-Message-State: AOAM532+91ewgH0VRDAnB807szA6+o5hk+GwviJPFwMHBo4nlRU0qClQ TQsANpnLiCddDbzlRx/5gBLKGg== X-Google-Smtp-Source: ABdhPJxNnhr67/krO6Od73KqvFm2SWsrllggrEWrmt1dtZmyIJrwfJHmKsNApbDqElBq2VnfEKWdXw== X-Received: by 2002:a1c:f40a:: with SMTP id z10mr2073824wma.119.1627518942865; Wed, 28 Jul 2021 17:35:42 -0700 (PDT) Received: from [192.168.1.12] (host-80-41-121-59.as13285.net. [80.41.121.59]) by smtp.gmail.com with ESMTPSA id p5sm1628396wrd.25.2021.07.28.17.35.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 17:35:42 -0700 (PDT) Subject: Re: [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15 To: Rob Clark , Dave Airlie , Daniel Vetter Cc: freedreno , dri-devel , linux-arm-msm , Jordan Crouse , Abhinav Kumar , Dmitry Baryshkov References: From: Caleb Connolly Message-ID: <7553f3cd-61c8-3ece-14ec-6c0cf4ae0296@linaro.org> Date: Thu, 29 Jul 2021 01:35:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Rob, This series causes a fatal crash on my Oneplus 6, the device goes to Qualcomm crashdump mode shortly after reaching UI with the following errors: https://paste.ubuntu.com/p/HvjmzZYtgw/ I did a git bisect and the patch ("drm/msm: Devfreq tuning") seems to be the cause of the crash, reverting it resolves the issue. On 28/07/2021 21:52, Rob Clark wrote: > Hi Dave & Daniel, > > An early pull for v5.15 (there'll be more coming in a week or two), > consisting of the drm/scheduler conversion and a couple other small > series that one was based one. Mostly sending this now because IIUC > danvet wanted it in drm-next so he could rebase on it. (Daniel, if > you disagree then speak up, and I'll instead include this in the main > pull request once that is ready.) > > This also has a core patch to drop drm_gem_object_put_locked() now > that the last use of it is removed. > > The following changes since commit ff1176468d368232b684f75e82563369208bc371: > > Linux 5.14-rc3 (2021-07-25 15:35:14 -0700) > > are available in the Git repository at: > > https://gitlab.freedesktop.org/drm/msm.git drm-msm-next-2021-07-28 > > for you to fetch changes up to 4541e4f2225c30b0e9442be9eb2fb8b7086cdd1f: > > drm/msm/gem: Mark active before pinning (2021-07-28 09:19:00 -0700) > > ---------------------------------------------------------------- > Rob Clark (18): > drm/msm: Let fences read directly from memptrs > drm/msm: Signal fences sooner > drm/msm: Split out devfreq handling > drm/msm: Split out get_freq() helper > drm/msm: Devfreq tuning > drm/msm: Docs and misc cleanup > drm/msm: Small submitqueue creation cleanup > drm/msm: drop drm_gem_object_put_locked() > drm: Drop drm_gem_object_put_locked() > drm/msm/submit: Simplify out-fence-fd handling > drm/msm: Consolidate submit bo state > drm/msm: Track "seqno" fences by idr > drm/msm: Return ERR_PTR() from submit_create() > drm/msm: Conversion to drm scheduler > drm/msm: Drop submit bo_list > drm/msm: Drop struct_mutex in submit path > drm/msm: Utilize gpu scheduler priorities > drm/msm/gem: Mark active before pinning > > drivers/gpu/drm/drm_gem.c | 22 -- > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/msm/Makefile | 1 + > drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +- > drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- > drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 7 +- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 12 +- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 4 +- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 +- > drivers/gpu/drm/msm/msm_drv.c | 30 ++- > drivers/gpu/drm/msm/msm_fence.c | 53 +---- > drivers/gpu/drm/msm/msm_fence.h | 44 +++- > drivers/gpu/drm/msm/msm_gem.c | 94 +------- > drivers/gpu/drm/msm/msm_gem.h | 47 ++-- > drivers/gpu/drm/msm/msm_gem_submit.c | 344 +++++++++++++++++----------- > drivers/gpu/drm/msm/msm_gpu.c | 220 ++++-------------- > drivers/gpu/drm/msm/msm_gpu.h | 139 ++++++++++- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 203 ++++++++++++++++ > drivers/gpu/drm/msm/msm_rd.c | 6 +- > drivers/gpu/drm/msm/msm_ringbuffer.c | 69 +++++- > drivers/gpu/drm/msm/msm_ringbuffer.h | 12 + > drivers/gpu/drm/msm/msm_submitqueue.c | 53 +++-- > include/drm/drm_gem.h | 2 - > include/uapi/drm/msm_drm.h | 14 +- > 26 files changed, 865 insertions(+), 536 deletions(-) > create mode 100644 drivers/gpu/drm/msm/msm_gpu_devfreq.c > -- Kind Regards, Caleb (they/them) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A4BDC4338F for ; Thu, 29 Jul 2021 06:21:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33FE160F02 for ; Thu, 29 Jul 2021 06:21:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 33FE160F02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B44B06EC8C; Thu, 29 Jul 2021 06:21:26 +0000 (UTC) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65DBC6E51C for ; Thu, 29 Jul 2021 00:35:44 +0000 (UTC) Received: by mail-wm1-x32b.google.com with SMTP id n28-20020a05600c3b9cb02902552e60df56so2796762wms.0 for ; Wed, 28 Jul 2021 17:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A91VsRhxCCDIXtkfswtebSEJGkGdWMGW8PkmZnFfEqA=; b=SvncO4Q5IeNq+bdgnrabIUmkNm8M0cS+oXjh52oWxM6ucE1MgJgrpPpRzS6DfOWLhK +UMuvIZp8L1pAIpoWX3lcrSdQL7TGpie938D0Kjg2uk3YBltmP4EnEYvWXhbAuFEPL90 UW28LH6i40CmJ1nj7nzsyo6pVgJ8l0Qwtb/R5I8vJ76DZy/cHvkZaTFRtcC5636j+ZF/ kyn5krxJNmHzfoFc8O7PcVLenwCgWvpQc5f3dTWnZZb9M5FjqsK/ULvV/X8lxOSI0Uwa +7yWsSJwVSQ/WxXuBuD7EXFCFbHWsUWPYRXVsV4g4XnygTCYCMq2uGgRLMG4JtxaErII ysDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A91VsRhxCCDIXtkfswtebSEJGkGdWMGW8PkmZnFfEqA=; b=fGrNU5rwpbyFGXgO1aBWntlJrLOTHOILQYJWnfP1kBVKNs4WKqC0cW01jqKZCQ5Xqr ofe476ufL09NMKHv1HMuG8cfbH7ukMZrc+Bmn8MrNydX0taSzkvryb1NIm8Oiu0HGCAw 8K76cwLcWbZIs+t1C8UYkg9adrTi6jDcp36BdZlVVlzlseFUb+Ax5rOpC7w0DB5ULlMu nAicP5lldN7rQaq2SsFoiKR2qf9KhNyqU42kKuHhcwz87yv2bn/8DPj87fh4x0/wSGsc mFtCZA4VW5+nc+CtNjrzShxf0P92ghLbwE8CPMCfPJL3mWHpItaHLqnZAUkUuTiFMjCg mOKg== X-Gm-Message-State: AOAM531gx8DYxuzyVwH9psuWI7BcNxOp9dhbG3DWBkVsLA0yVk7Rg7m6 mSSYRSGWQ8vfuqxzadHTdKVOTA== X-Google-Smtp-Source: ABdhPJxNnhr67/krO6Od73KqvFm2SWsrllggrEWrmt1dtZmyIJrwfJHmKsNApbDqElBq2VnfEKWdXw== X-Received: by 2002:a1c:f40a:: with SMTP id z10mr2073824wma.119.1627518942865; Wed, 28 Jul 2021 17:35:42 -0700 (PDT) Received: from [192.168.1.12] (host-80-41-121-59.as13285.net. [80.41.121.59]) by smtp.gmail.com with ESMTPSA id p5sm1628396wrd.25.2021.07.28.17.35.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 17:35:42 -0700 (PDT) Subject: Re: [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15 To: Rob Clark , Dave Airlie , Daniel Vetter References: From: Caleb Connolly Message-ID: <7553f3cd-61c8-3ece-14ec-6c0cf4ae0296@linaro.org> Date: Thu, 29 Jul 2021 01:35:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Thu, 29 Jul 2021 06:21:25 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm , Abhinav Kumar , Jordan Crouse , dri-devel , Dmitry Baryshkov , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Rob, This series causes a fatal crash on my Oneplus 6, the device goes to Qualcomm crashdump mode shortly after reaching UI with the following errors: https://paste.ubuntu.com/p/HvjmzZYtgw/ I did a git bisect and the patch ("drm/msm: Devfreq tuning") seems to be the cause of the crash, reverting it resolves the issue. On 28/07/2021 21:52, Rob Clark wrote: > Hi Dave & Daniel, > > An early pull for v5.15 (there'll be more coming in a week or two), > consisting of the drm/scheduler conversion and a couple other small > series that one was based one. Mostly sending this now because IIUC > danvet wanted it in drm-next so he could rebase on it. (Daniel, if > you disagree then speak up, and I'll instead include this in the main > pull request once that is ready.) > > This also has a core patch to drop drm_gem_object_put_locked() now > that the last use of it is removed. > > The following changes since commit ff1176468d368232b684f75e82563369208bc371: > > Linux 5.14-rc3 (2021-07-25 15:35:14 -0700) > > are available in the Git repository at: > > https://gitlab.freedesktop.org/drm/msm.git drm-msm-next-2021-07-28 > > for you to fetch changes up to 4541e4f2225c30b0e9442be9eb2fb8b7086cdd1f: > > drm/msm/gem: Mark active before pinning (2021-07-28 09:19:00 -0700) > > ---------------------------------------------------------------- > Rob Clark (18): > drm/msm: Let fences read directly from memptrs > drm/msm: Signal fences sooner > drm/msm: Split out devfreq handling > drm/msm: Split out get_freq() helper > drm/msm: Devfreq tuning > drm/msm: Docs and misc cleanup > drm/msm: Small submitqueue creation cleanup > drm/msm: drop drm_gem_object_put_locked() > drm: Drop drm_gem_object_put_locked() > drm/msm/submit: Simplify out-fence-fd handling > drm/msm: Consolidate submit bo state > drm/msm: Track "seqno" fences by idr > drm/msm: Return ERR_PTR() from submit_create() > drm/msm: Conversion to drm scheduler > drm/msm: Drop submit bo_list > drm/msm: Drop struct_mutex in submit path > drm/msm: Utilize gpu scheduler priorities > drm/msm/gem: Mark active before pinning > > drivers/gpu/drm/drm_gem.c | 22 -- > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/msm/Makefile | 1 + > drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +- > drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- > drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 7 +- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 12 +- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 4 +- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 +- > drivers/gpu/drm/msm/msm_drv.c | 30 ++- > drivers/gpu/drm/msm/msm_fence.c | 53 +---- > drivers/gpu/drm/msm/msm_fence.h | 44 +++- > drivers/gpu/drm/msm/msm_gem.c | 94 +------- > drivers/gpu/drm/msm/msm_gem.h | 47 ++-- > drivers/gpu/drm/msm/msm_gem_submit.c | 344 +++++++++++++++++----------- > drivers/gpu/drm/msm/msm_gpu.c | 220 ++++-------------- > drivers/gpu/drm/msm/msm_gpu.h | 139 ++++++++++- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 203 ++++++++++++++++ > drivers/gpu/drm/msm/msm_rd.c | 6 +- > drivers/gpu/drm/msm/msm_ringbuffer.c | 69 +++++- > drivers/gpu/drm/msm/msm_ringbuffer.h | 12 + > drivers/gpu/drm/msm/msm_submitqueue.c | 53 +++-- > include/drm/drm_gem.h | 2 - > include/uapi/drm/msm_drm.h | 14 +- > 26 files changed, 865 insertions(+), 536 deletions(-) > create mode 100644 drivers/gpu/drm/msm/msm_gpu_devfreq.c > -- Kind Regards, Caleb (they/them)