From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF785C352AA for ; Tue, 1 Oct 2019 14:36:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7CF32054F for ; Tue, 1 Oct 2019 14:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389022AbfJAOgB (ORCPT ); Tue, 1 Oct 2019 10:36:01 -0400 Received: from foss.arm.com ([217.140.110.172]:51124 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387781AbfJAOgB (ORCPT ); Tue, 1 Oct 2019 10:36:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8FD471000; Tue, 1 Oct 2019 07:36:00 -0700 (PDT) Received: from [10.37.8.149] (unknown [10.37.8.149]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2217B3F71A; Tue, 1 Oct 2019 07:35:58 -0700 (PDT) Subject: Re: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC To: Will Deacon Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, ndesaulniers@google.com, tglx@linutronix.de References: <20190920142738.qlsjwguc6bpnez63@willie-the-truck> <20190926214342.34608-1-vincenzo.frascino@arm.com> <20190926214342.34608-2-vincenzo.frascino@arm.com> <20191001131420.y3fsydlo7pg6ykfs@willie-the-truck> <20191001132731.GG41399@arrakis.emea.arm.com> <20191001142038.ptwyfbesfrz3kkoz@willie-the-truck> From: Vincenzo Frascino Message-ID: <7558914c-fc2d-d05a-ccbe-76ef451670ae@arm.com> Date: Tue, 1 Oct 2019 15:37:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191001142038.ptwyfbesfrz3kkoz@willie-the-truck> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/1/19 3:20 PM, Will Deacon wrote: > On Tue, Oct 01, 2019 at 03:20:35PM +0100, Vincenzo Frascino wrote: >> On 10/1/19 2:27 PM, Catalin Marinas wrote: >>> On Tue, Oct 01, 2019 at 02:14:23PM +0100, Will Deacon wrote: >>>> On Thu, Sep 26, 2019 at 10:43:38PM +0100, Vincenzo Frascino wrote: >>>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>>>> index 37c610963eee..0e5beb928af5 100644 >>>>> --- a/arch/arm64/Kconfig >>>>> +++ b/arch/arm64/Kconfig >>>>> @@ -110,7 +110,7 @@ config ARM64 >>>>> select GENERIC_STRNLEN_USER >>>>> select GENERIC_TIME_VSYSCALL >>>>> select GENERIC_GETTIMEOFDAY >>>>> - select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT) >>>>> + select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_ARM_GCC) >>>>> select HANDLE_DOMAIN_IRQ >>>>> select HARDIRQS_SW_RESEND >>>>> select HAVE_PCI >>>>> @@ -313,6 +313,9 @@ config KASAN_SHADOW_OFFSET >>>>> default 0xeffffff900000000 if ARM64_VA_BITS_36 && KASAN_SW_TAGS >>>>> default 0xffffffffffffffff >>>>> >>>>> +config COMPATCC_IS_ARM_GCC >>>>> + def_bool $(success,$(COMPATCC) --version | head -n 1 | grep -q "arm-.*-gcc") >>>> >>>> I've seen toolchains where the first part of the tuple is "armv7-", so they >>>> won't get detected here. However, do we really need to detect this? If >>>> somebody passes a duff compiler, then the build will fail in the same way as >>>> if they passed it to CROSS_COMPILE=. >>> >>> Not sure what happens if we pass an aarch64 compiler. Can we end up with >>> a 64-bit compat vDSO? >>> >> >> I agree with Catalin here. The problem is not only when you pass and aarch64 >> toolchain but even an x86 and so on. > > I disagree. What happens if you do: > > $ make ARCH=arm64 CROSS_COMPILE=x86_64-linux-gnu- > > on your x86 box? > The kernel compilation breaks as follows: x86_64-linux-gnu-gcc: error: unrecognized command line option ‘-mlittle-endian’; did you mean ‘-fconvert=little-endian’? /data1/Projects/LinuxKernel/linux/scripts/Makefile.build:265: recipe for target 'scripts/mod/empty.o' failed make[2]: *** [scripts/mod/empty.o] Error 1 /data1/Projects/LinuxKernel/linux/Makefile:1128: recipe for target 'prepare0' failed make[1]: *** [prepare0] Error 2 make[1]: Leaving directory '/data1/Projects/LinuxKernel/linux-out' Makefile:179: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Similar issue in the compat vdso library compilation if I do (without the check): $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CROSS_COMPILE_COMPAT=x86_64-linux-gnu- With this check the compilation completes correctly but the compat vdso does not get built (unless my environment is playing me tricks ;) ). >> If the problem is related to armv7- we can change the rule as "arm.*-gcc" which >> should detect them as well. Do you know what is the triple that an armv7- >> toolchain prints? > > 'fraid not, since I don't have one to hand. I think you'd end up matching > arm*-gcc, which is pretty broad. > If we all agree I can extend this rule then. > Will > -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D157FC352AA for ; Tue, 1 Oct 2019 14:36:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A67202070B for ; Tue, 1 Oct 2019 14:36:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gybnYUbd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A67202070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YkvV3WxdSb8vj5eAuskcEm4ZAyMPb81oHzidYoo9QkQ=; b=gybnYUbdWxpcBJ RLHLFU5+6JvARj61lPZr1EhHtekmh5ctVurxbu46gDWYx1xha8THlfuLw7SntB2UXG+0+H/jOnslH B2SQ/tswKTkDNB9Zx7PW/LUs1yAAyojIJKvsDDROC77BfEboTFwdJUbE7SFPrRTj8r8V/EFHPbDw6 4/anwuGvyS47CEX99MOE2qaFTm/1QXFRumil+8lqY/8rLOLHRBxiXY92DXzgjottATooCw1GGfLcd Zl33L9ZCYfJ7BxW5tflxQNyN13XrYHmIaEk+jIpdLGnq8YOHKsrSW8TxYJcCuNImCtpV0hM7RszLc SOpjolpaaZMej+pUWdwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFJG0-00076j-8o; Tue, 01 Oct 2019 14:36:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFJFx-00076I-ES for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2019 14:36:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8FD471000; Tue, 1 Oct 2019 07:36:00 -0700 (PDT) Received: from [10.37.8.149] (unknown [10.37.8.149]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2217B3F71A; Tue, 1 Oct 2019 07:35:58 -0700 (PDT) Subject: Re: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC To: Will Deacon References: <20190920142738.qlsjwguc6bpnez63@willie-the-truck> <20190926214342.34608-1-vincenzo.frascino@arm.com> <20190926214342.34608-2-vincenzo.frascino@arm.com> <20191001131420.y3fsydlo7pg6ykfs@willie-the-truck> <20191001132731.GG41399@arrakis.emea.arm.com> <20191001142038.ptwyfbesfrz3kkoz@willie-the-truck> From: Vincenzo Frascino Message-ID: <7558914c-fc2d-d05a-ccbe-76ef451670ae@arm.com> Date: Tue, 1 Oct 2019 15:37:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191001142038.ptwyfbesfrz3kkoz@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_073601_574144_1FF023AB X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ard.biesheuvel@linaro.org, Catalin Marinas , ndesaulniers@google.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxMC8xLzE5IDM6MjAgUE0sIFdpbGwgRGVhY29uIHdyb3RlOgo+IE9uIFR1ZSwgT2N0IDAx LCAyMDE5IGF0IDAzOjIwOjM1UE0gKzAxMDAsIFZpbmNlbnpvIEZyYXNjaW5vIHdyb3RlOgo+PiBP biAxMC8xLzE5IDI6MjcgUE0sIENhdGFsaW4gTWFyaW5hcyB3cm90ZToKPj4+IE9uIFR1ZSwgT2N0 IDAxLCAyMDE5IGF0IDAyOjE0OjIzUE0gKzAxMDAsIFdpbGwgRGVhY29uIHdyb3RlOgo+Pj4+IE9u IFRodSwgU2VwIDI2LCAyMDE5IGF0IDEwOjQzOjM4UE0gKzAxMDAsIFZpbmNlbnpvIEZyYXNjaW5v IHdyb3RlOgo+Pj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9LY29uZmlnIGIvYXJjaC9hcm02 NC9LY29uZmlnCj4+Pj4+IGluZGV4IDM3YzYxMDk2M2VlZS4uMGU1YmViOTI4YWY1IDEwMDY0NAo+ Pj4+PiAtLS0gYS9hcmNoL2FybTY0L0tjb25maWcKPj4+Pj4gKysrIGIvYXJjaC9hcm02NC9LY29u ZmlnCj4+Pj4+IEBAIC0xMTAsNyArMTEwLDcgQEAgY29uZmlnIEFSTTY0Cj4+Pj4+ICAJc2VsZWN0 IEdFTkVSSUNfU1RSTkxFTl9VU0VSCj4+Pj4+ICAJc2VsZWN0IEdFTkVSSUNfVElNRV9WU1lTQ0FM TAo+Pj4+PiAgCXNlbGVjdCBHRU5FUklDX0dFVFRJTUVPRkRBWQo+Pj4+PiAtCXNlbGVjdCBHRU5F UklDX0NPTVBBVF9WRFNPIGlmICghQ1BVX0JJR19FTkRJQU4gJiYgQ09NUEFUKQo+Pj4+PiArCXNl bGVjdCBHRU5FUklDX0NPTVBBVF9WRFNPIGlmICghQ1BVX0JJR19FTkRJQU4gJiYgQ09NUEFUICYm IENPTVBBVENDX0lTX0FSTV9HQ0MpCj4+Pj4+ICAJc2VsZWN0IEhBTkRMRV9ET01BSU5fSVJRCj4+ Pj4+ICAJc2VsZWN0IEhBUkRJUlFTX1NXX1JFU0VORAo+Pj4+PiAgCXNlbGVjdCBIQVZFX1BDSQo+ Pj4+PiBAQCAtMzEzLDYgKzMxMyw5IEBAIGNvbmZpZyBLQVNBTl9TSEFET1dfT0ZGU0VUCj4+Pj4+ ICAJZGVmYXVsdCAweGVmZmZmZmY5MDAwMDAwMDAgaWYgQVJNNjRfVkFfQklUU18zNiAmJiBLQVNB Tl9TV19UQUdTCj4+Pj4+ICAJZGVmYXVsdCAweGZmZmZmZmZmZmZmZmZmZmYKPj4+Pj4gIAo+Pj4+ PiArY29uZmlnIENPTVBBVENDX0lTX0FSTV9HQ0MKPj4+Pj4gKwlkZWZfYm9vbCAkKHN1Y2Nlc3Ms JChDT01QQVRDQykgLS12ZXJzaW9uIHwgaGVhZCAtbiAxIHwgZ3JlcCAtcSAiYXJtLS4qLWdjYyIp Cj4+Pj4KPj4+PiBJJ3ZlIHNlZW4gdG9vbGNoYWlucyB3aGVyZSB0aGUgZmlyc3QgcGFydCBvZiB0 aGUgdHVwbGUgaXMgImFybXY3LSIsIHNvIHRoZXkKPj4+PiB3b24ndCBnZXQgZGV0ZWN0ZWQgaGVy ZS4gSG93ZXZlciwgZG8gd2UgcmVhbGx5IG5lZWQgdG8gZGV0ZWN0IHRoaXM/IElmCj4+Pj4gc29t ZWJvZHkgcGFzc2VzIGEgZHVmZiBjb21waWxlciwgdGhlbiB0aGUgYnVpbGQgd2lsbCBmYWlsIGlu IHRoZSBzYW1lIHdheSBhcwo+Pj4+IGlmIHRoZXkgcGFzc2VkIGl0IHRvIENST1NTX0NPTVBJTEU9 Lgo+Pj4KPj4+IE5vdCBzdXJlIHdoYXQgaGFwcGVucyBpZiB3ZSBwYXNzIGFuIGFhcmNoNjQgY29t cGlsZXIuIENhbiB3ZSBlbmQgdXAgd2l0aAo+Pj4gYSA2NC1iaXQgY29tcGF0IHZEU08/Cj4+Pgo+ Pgo+PiBJIGFncmVlIHdpdGggQ2F0YWxpbiBoZXJlLiBUaGUgcHJvYmxlbSBpcyBub3Qgb25seSB3 aGVuIHlvdSBwYXNzIGFuZCBhYXJjaDY0Cj4+IHRvb2xjaGFpbiBidXQgZXZlbiBhbiB4ODYgYW5k IHNvIG9uLgo+IAo+IEkgZGlzYWdyZWUuIFdoYXQgaGFwcGVucyBpZiB5b3UgZG86Cj4gCj4gJCBt YWtlIEFSQ0g9YXJtNjQgQ1JPU1NfQ09NUElMRT14ODZfNjQtbGludXgtZ251LQo+IAo+IG9uIHlv dXIgeDg2IGJveD8KPgoKVGhlIGtlcm5lbCBjb21waWxhdGlvbiBicmVha3MgYXMgZm9sbG93czoK Cng4Nl82NC1saW51eC1nbnUtZ2NjOiBlcnJvcjogdW5yZWNvZ25pemVkIGNvbW1hbmQgbGluZSBv cHRpb24g4oCYLW1saXR0bGUtZW5kaWFu4oCZOwpkaWQgeW91IG1lYW4g4oCYLWZjb252ZXJ0PWxp dHRsZS1lbmRpYW7igJk/Ci9kYXRhMS9Qcm9qZWN0cy9MaW51eEtlcm5lbC9saW51eC9zY3JpcHRz L01ha2VmaWxlLmJ1aWxkOjI2NTogcmVjaXBlIGZvciB0YXJnZXQKJ3NjcmlwdHMvbW9kL2VtcHR5 Lm8nIGZhaWxlZAptYWtlWzJdOiAqKiogW3NjcmlwdHMvbW9kL2VtcHR5Lm9dIEVycm9yIDEKL2Rh dGExL1Byb2plY3RzL0xpbnV4S2VybmVsL2xpbnV4L01ha2VmaWxlOjExMjg6IHJlY2lwZSBmb3Ig dGFyZ2V0ICdwcmVwYXJlMCcgZmFpbGVkCm1ha2VbMV06ICoqKiBbcHJlcGFyZTBdIEVycm9yIDIK bWFrZVsxXTogTGVhdmluZyBkaXJlY3RvcnkgJy9kYXRhMS9Qcm9qZWN0cy9MaW51eEtlcm5lbC9s aW51eC1vdXQnCk1ha2VmaWxlOjE3OTogcmVjaXBlIGZvciB0YXJnZXQgJ3N1Yi1tYWtlJyBmYWls ZWQKbWFrZTogKioqIFtzdWItbWFrZV0gRXJyb3IgMgoKU2ltaWxhciBpc3N1ZSBpbiB0aGUgY29t cGF0IHZkc28gbGlicmFyeSBjb21waWxhdGlvbiBpZiBJIGRvICh3aXRob3V0IHRoZSBjaGVjayk6 CgokIG1ha2UgQVJDSD1hcm02NCBDUk9TU19DT01QSUxFPWFhcmNoNjQtbGludXgtZ251LQpDUk9T U19DT01QSUxFX0NPTVBBVD14ODZfNjQtbGludXgtZ251LQoKV2l0aCB0aGlzIGNoZWNrIHRoZSBj b21waWxhdGlvbiBjb21wbGV0ZXMgY29ycmVjdGx5IGJ1dCB0aGUgY29tcGF0IHZkc28gZG9lcyBu b3QKZ2V0IGJ1aWx0ICh1bmxlc3MgbXkgZW52aXJvbm1lbnQgaXMgcGxheWluZyBtZSB0cmlja3Mg OykgKS4KCj4+IElmIHRoZSBwcm9ibGVtIGlzIHJlbGF0ZWQgdG8gYXJtdjctIHdlIGNhbiBjaGFu Z2UgdGhlIHJ1bGUgYXMgImFybS4qLWdjYyIgd2hpY2gKPj4gc2hvdWxkIGRldGVjdCB0aGVtIGFz IHdlbGwuIERvIHlvdSBrbm93IHdoYXQgaXMgdGhlIHRyaXBsZSB0aGF0IGFuIGFybXY3LQo+PiB0 b29sY2hhaW4gcHJpbnRzPwo+IAo+ICdmcmFpZCBub3QsIHNpbmNlIEkgZG9uJ3QgaGF2ZSBvbmUg dG8gaGFuZC4gSSB0aGluayB5b3UnZCBlbmQgdXAgbWF0Y2hpbmcKPiBhcm0qLWdjYywgd2hpY2gg aXMgcHJldHR5IGJyb2FkLgo+IAoKSWYgd2UgYWxsIGFncmVlIEkgY2FuIGV4dGVuZCB0aGlzIHJ1 bGUgdGhlbi4KCj4gV2lsbAo+IAoKLS0gClJlZ2FyZHMsClZpbmNlbnpvCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==