From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD76DC4707F for ; Thu, 27 May 2021 14:26:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CF5260233 for ; Thu, 27 May 2021 14:26:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CF5260233 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eldorado.org.br Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmGy9-0000RK-IA for qemu-devel@archiver.kernel.org; Thu, 27 May 2021 10:26:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmGvX-0004yD-C6; Thu, 27 May 2021 10:23:59 -0400 Received: from [201.28.113.2] (port=22005 helo=outlook.eldorado.org.br) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmGvV-00043x-4r; Thu, 27 May 2021 10:23:59 -0400 Received: from power9a ([10.10.71.235]) by outlook.eldorado.org.br with Microsoft SMTPSVC(8.5.9600.16384); Thu, 27 May 2021 11:23:52 -0300 Received: from [127.0.0.1] (unknown [10.10.71.235]) by power9a (Postfix) with ESMTPS id AB6238013E1; Thu, 27 May 2021 11:23:52 -0300 (-03) Subject: Re: [PATCH 0/5] stop collection of instruction usage statistics To: =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210526202104.127910-1-bruno.larsen@eldorado.org.br> <87v9741djt.fsf@linaro.org> From: Bruno Piazera Larsen Message-ID: <7561689d-022d-1981-329f-e843fb4bbc4b@eldorado.org.br> Date: Thu, 27 May 2021 11:23:52 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87v9741djt.fsf@linaro.org> Content-Type: multipart/alternative; boundary="------------C14663A8074BB8813DB55803" Content-Language: en-US X-OriginalArrivalTime: 27 May 2021 14:23:53.0031 (UTC) FILETIME=[EB69DD70:01D75303] X-Host-Lookup-Failed: Reverse DNS lookup failed for 201.28.113.2 (failed) Received-SPF: pass client-ip=201.28.113.2; envelope-from=bruno.larsen@eldorado.org.br; helo=outlook.eldorado.org.br X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, richard.henderson@linaro.org, lucas.araujo@eldorado.org.br, qemu-devel@nongnu.org, luis.pires@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------C14663A8074BB8813DB55803 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 27/05/2021 10:57, Alex Bennée wrote: > "Bruno Larsen (billionai)" writes: > >> Based-on: <20210525115355.8254-1-bruno.larsen@eldorado.org.br> >> >> The functionality of counting how many instructions were being executed and >> being able to show it through the monitor, although neat, was only >> supported by ppc, and now that it is migrating to use decodetree (at >> least partially), those statistics won't be used anymore. Therefore, >> this patch removes that functinality completely. > I have no particular comment to make about the PPC stuff but with the > common translator loop we have hooks across all converted front ends to > identify the start of each instruction. It's needed for the TCG plugin > instrumentation and we could in theory use it for more integrated stats > across the board. > > Out of interest what was the main aim of this code - a view of total > executed instructions or something more detailed like a breakdown of > types and ops? I'm pretty new to qemu, so I'm not sure what the original intent was, but what it did was count how many times the handler of the instruction was called, so you knew how many times each individual opcode was used. At least, that's what I think it should do, since the code doesn't even compile anymore for me to check > >> This series was suggested by Richard Henderson >> >> Bruno Larsen (billionai) (5): >> target/ppc: fixed GEN_OPCODE behavior when PPC_DUMP_CPU is set >> target/ppc: remove ppc_cpu_dump_statistics >> target/ppc: removed mentions to DO_PPC_STATISTICS >> monitor: removed cpustats command >> hw/core/cpu: removed cpu_dump_statistics function >> >> hmp-commands-info.hx | 13 -------- >> hw/core/cpu.c | 9 ------ >> include/hw/core/cpu.h | 12 -------- >> monitor/misc.c | 11 ------- >> target/ppc/cpu.h | 1 - >> target/ppc/cpu_init.c | 3 -- >> target/ppc/translate.c | 69 +++--------------------------------------- >> 7 files changed, 5 insertions(+), 113 deletions(-) > -- Bruno Piazera Larsen Instituto de Pesquisas ELDORADO Departamento Computação Embarcada Analista de Software Trainee Aviso Legal - Disclaimer --------------C14663A8074BB8813DB55803 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 27/05/2021 10:57, Alex Bennée wrote:
"Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> writes:


Based-on: <20210525115355.8254-1-bruno.larsen@eldorado.org.br>

The functionality of counting how many instructions were being executed and
being able to show it through the monitor, although neat, was only
supported by ppc, and now that it is migrating to use decodetree (at
least partially), those statistics won't be used anymore. Therefore,
this patch removes that functinality completely.

I have no particular comment to make about the PPC stuff but with the
common translator loop we have hooks across all converted front ends to
identify the start of each instruction. It's needed for the TCG plugin
instrumentation and we could in theory use it for more integrated stats
across the board.

Out of interest what was the main aim of this code - a view of total
executed instructions or something more detailed like a breakdown of
types and ops?

I'm pretty new to qemu, so I'm not sure what the original intent was, but what it did was count how many times the handler of the instruction was called, so you knew how many times each individual opcode was used. At least, that's what I think it should do, since the code doesn't even compile anymore for me to check



This series was suggested by Richard Henderson

Bruno Larsen (billionai) (5):
  target/ppc: fixed GEN_OPCODE behavior when PPC_DUMP_CPU is set
  target/ppc: remove ppc_cpu_dump_statistics
  target/ppc: removed mentions to DO_PPC_STATISTICS
  monitor: removed cpustats command
  hw/core/cpu: removed cpu_dump_statistics function

 hmp-commands-info.hx   | 13 --------
 hw/core/cpu.c          |  9 ------
 include/hw/core/cpu.h  | 12 --------
 monitor/misc.c         | 11 -------
 target/ppc/cpu.h       |  1 -
 target/ppc/cpu_init.c  |  3 --
 target/ppc/translate.c | 69 +++---------------------------------------
 7 files changed, 5 insertions(+), 113 deletions(-)
--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer
--------------C14663A8074BB8813DB55803--