From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: dhowells@redhat.com,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
lucas.de.marchi@gmail.com,
James Morris <james.l.morris@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] KEYS: split call to call_usermodehelper_fns()
Date: Mon, 25 Mar 2013 12:55:19 +0000 [thread overview]
Message-ID: <7566.1364216119@warthog.procyon.org.uk> (raw)
In-Reply-To: <20130309202537.GD16399@redhat.com>
Oleg Nesterov <oleg@redhat.com> wrote:
> Looks correct, but can't we simpluify it a bit?
>
> info = call_usermodehelper_setup(session_keyring);
> if (!info)
> return ENOMEM;
-ENOMEM;-)
> key_get(session_keyring));
> return call_usermodehelper_exec(info);
Looks reasonable. I like it better this way as it makes working out how to
deal with all the error cases so much simpler:-).
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2013-03-25 12:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 6:15 [PATCH v2 0/7] kmod/usermodehelper changes Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 1/7] kernel/sys.c: Use the simpler call_usermodehelper() Lucas De Marchi
2013-03-09 20:17 ` Oleg Nesterov
2013-03-08 6:15 ` [PATCH v2 2/7] usermodehelper: Export _exec() and _setup() functions Lucas De Marchi
2013-03-09 20:21 ` Oleg Nesterov
2013-03-08 6:15 ` [PATCH v2 3/7] kmod: split call to call_usermodehelper_fns() Lucas De Marchi
2013-03-09 20:23 ` Oleg Nesterov
2013-03-09 23:54 ` Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 4/7] KEYS: " Lucas De Marchi
2013-03-09 20:25 ` Oleg Nesterov
2013-03-09 23:55 ` Lucas De Marchi
2013-03-25 12:55 ` David Howells [this message]
2013-03-25 13:11 ` Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 5/7] coredump: remove trailling whitespaces Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 6/7] Split remaining calls to call_usermodehelper_fns() Lucas De Marchi
2013-03-09 20:42 ` Oleg Nesterov
2013-03-09 23:57 ` Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 7/7] kmod: remove call_usermodehelper_fns() Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7566.1364216119@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@profusion.mobi \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.