From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4087C433DF for ; Mon, 8 Jun 2020 15:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1536207ED for ; Mon, 8 Jun 2020 15:21:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="Wg5tn5H1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730213AbgFHPVb (ORCPT ); Mon, 8 Jun 2020 11:21:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729668AbgFHPVb (ORCPT ); Mon, 8 Jun 2020 11:21:31 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BBFAC08C5C2; Mon, 8 Jun 2020 08:21:31 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id D311822EDB; Mon, 8 Jun 2020 17:21:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1591629687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w5/wFYr0WrHR2BGw4sUPuRmTmyyZEDrBDXp7xE6Rcqs=; b=Wg5tn5H1faOtr0XnIGPDSGd5kyucCSnasem9z0pro05j+LKp9YmcltmJYSntceVYHtAZHW CWFWp/mjoJ2xvRoKRmfTvpANiM8L6SG62R4HTUanniYR0aE0wa6xqFpGLIlU1qOlaKndyr yx9pmn5kqLEjpxuBMngTNYuCFJX99fM= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 08 Jun 2020 17:21:20 +0200 From: Michael Walle To: Lee Jones Cc: Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 03/16] mfd: mfd-core: match device tree node against reg property In-Reply-To: <20200608142413.GA4106@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-4-michael@walle.cc> <67e90dafd67c285158c2c6f67f92edb7@walle.cc> <20200515102848.GH271301@dell> <159e68b4ce53630ef906b2fcbca925bd@walle.cc> <20200608142413.GA4106@dell> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <7566ef30fea9740f427f392aabde0eac@walle.cc> X-Sender: michael@walle.cc Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Am 2020-06-08 16:24, schrieb Lee Jones: > On Mon, 25 May 2020, Michael Walle wrote: >> Am 2020-05-15 12:28, schrieb Lee Jones: >> > On Thu, 30 Apr 2020, Michael Walle wrote: >> > >> > > Hi Lee, >> > > >> > > Am 2020-04-23 19:45, schrieb Michael Walle: >> > > > There might be multiple children with the device tree compatible, for >> > > > example if a MFD has multiple instances of the same function. In this >> > > > case only the first is matched and the other children get a wrong >> > > > of_node reference. >> > > > Add a new option to match also against the unit address of the child >> > > > node. Additonally, a new helper OF_MFD_CELL_REG is added. > > [...] > >> > > > diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h >> > > > index d01d1299e49d..c2c0ad6b14f3 100644 >> > > > --- a/include/linux/mfd/core.h >> > > > +++ b/include/linux/mfd/core.h >> > > > @@ -13,8 +13,11 @@ >> > > > #include >> > > > >> > > > #define MFD_RES_SIZE(arr) (sizeof(arr) / sizeof(struct resource)) >> > > > +#define MFD_OF_REG_VALID BIT(31) >> > >> > What about 64bit platforms? >> >> The idea was to have this as a logical number. I.e. for now you may >> only >> have one subdevice per unique compatible string. In fact, if you have >> a >> look at the ab8500.c, there are multiple "stericsson,ab8500-pwm" >> subdevices. But there is only one DT node for all three of it. I guess >> this works as long as you don't use phandles to reference the pwm node >> in the device tree. Or you don't want to use device tree properties >> per subdevice (for example the "timeout-sec" of a watchdog device). > > This is not a good example, as the "stericsson,ab8500-pwm" is > legitimate. Here we are registering 3 potential devices, but only > instantiating 1 of them. Mh? static const struct mfd_cell ab8500_devs[] = { .. OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 1, "stericsson,ab8500-pwm"), OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 2, "stericsson,ab8500-pwm"), OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 3, "stericsson,ab8500-pwm"), .. } And in pwm-ab8500.c there are three offsets based on the pdev->id. Am I missing something here? -- -michael From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Walle Subject: Re: [PATCH v3 03/16] mfd: mfd-core: match device tree node against reg property Date: Mon, 08 Jun 2020 17:21:20 +0200 Message-ID: <7566ef30fea9740f427f392aabde0eac@walle.cc> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-4-michael@walle.cc> <67e90dafd67c285158c2c6f67f92edb7@walle.cc> <20200515102848.GH271301@dell> <159e68b4ce53630ef906b2fcbca925bd@walle.cc> <20200608142413.GA4106@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200608142413.GA4106@dell> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pwm@vger.kernel.org Am 2020-06-08 16:24, schrieb Lee Jones: > On Mon, 25 May 2020, Michael Walle wrote: >> Am 2020-05-15 12:28, schrieb Lee Jones: >> > On Thu, 30 Apr 2020, Michael Walle wrote: >> > >> > > Hi Lee, >> > > >> > > Am 2020-04-23 19:45, schrieb Michael Walle: >> > > > There might be multiple children with the device tree compatible, for >> > > > example if a MFD has multiple instances of the same function. In this >> > > > case only the first is matched and the other children get a wrong >> > > > of_node reference. >> > > > Add a new option to match also against the unit address of the child >> > > > node. Additonally, a new helper OF_MFD_CELL_REG is added. > > [...] > >> > > > diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h >> > > > index d01d1299e49d..c2c0ad6b14f3 100644 >> > > > --- a/include/linux/mfd/core.h >> > > > +++ b/include/linux/mfd/core.h >> > > > @@ -13,8 +13,11 @@ >> > > > #include >> > > > >> > > > #define MFD_RES_SIZE(arr) (sizeof(arr) / sizeof(struct resource)) >> > > > +#define MFD_OF_REG_VALID BIT(31) >> > >> > What about 64bit platforms? >> >> The idea was to have this as a logical number. I.e. for now you may >> only >> have one subdevice per unique compatible string. In fact, if you have >> a >> look at the ab8500.c, there are multiple "stericsson,ab8500-pwm" >> subdevices. But there is only one DT node for all three of it. I guess >> this works as long as you don't use phandles to reference the pwm node >> in the device tree. Or you don't want to use device tree properties >> per subdevice (for example the "timeout-sec" of a watchdog device). > > This is not a good example, as the "stericsson,ab8500-pwm" is > legitimate. Here we are registering 3 potential devices, but only > instantiating 1 of them. Mh? static const struct mfd_cell ab8500_devs[] = { .. OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 1, "stericsson,ab8500-pwm"), OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 2, "stericsson,ab8500-pwm"), OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 3, "stericsson,ab8500-pwm"), .. } And in pwm-ab8500.c there are three offsets based on the pdev->id. Am I missing something here? -- -michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3ED1C433DF for ; Mon, 8 Jun 2020 15:21:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5E77206D5 for ; Mon, 8 Jun 2020 15:21:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="keujk6xM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="Wg5tn5H1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5E77206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fL/rjNlc5k39InuyUWmDL2qyuPxvn/F9spw9NBdq5es=; b=keujk6xMpSahz6uUeaBxdcvlm rbalUs7JpMCISVmL2l/6rEtrPEQDxC2xqCVqHeyXcBybBOy1aysNFaQcZQAA38ym7/CArA3rMNtlD Ug8COY7ZvY3fkdIumEIg1FE/LU8cHxzNYmOLJCx7u1KYZaqKs5PaGDJavHIi9HhJpnDohCoBWpL+f ackDgXhEujv1+djhm/j5MoaHx+j6/AOr72eJXw3bDn+RmLFwAfweVLf3a9VKhS8TdzPDj+s6gc2iO hY+AfW34yOpdwLdSuayIhiUQgRuirWl4H4zm8Isu3K2Med7WNsFVBgZgjLDHNpcWgGB2U78Z8zSQV Ix94eCAbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiJao-0001yi-Jc; Mon, 08 Jun 2020 15:21:42 +0000 Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiJal-0001wd-KK for linux-arm-kernel@lists.infradead.org; Mon, 08 Jun 2020 15:21:41 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id D311822EDB; Mon, 8 Jun 2020 17:21:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1591629687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w5/wFYr0WrHR2BGw4sUPuRmTmyyZEDrBDXp7xE6Rcqs=; b=Wg5tn5H1faOtr0XnIGPDSGd5kyucCSnasem9z0pro05j+LKp9YmcltmJYSntceVYHtAZHW CWFWp/mjoJ2xvRoKRmfTvpANiM8L6SG62R4HTUanniYR0aE0wa6xqFpGLIlU1qOlaKndyr yx9pmn5kqLEjpxuBMngTNYuCFJX99fM= MIME-Version: 1.0 Date: Mon, 08 Jun 2020 17:21:20 +0200 From: Michael Walle To: Lee Jones Subject: Re: [PATCH v3 03/16] mfd: mfd-core: match device tree node against reg property In-Reply-To: <20200608142413.GA4106@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-4-michael@walle.cc> <67e90dafd67c285158c2c6f67f92edb7@walle.cc> <20200515102848.GH271301@dell> <159e68b4ce53630ef906b2fcbca925bd@walle.cc> <20200608142413.GA4106@dell> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <7566ef30fea9740f427f392aabde0eac@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200608_082139_829708_5D374A41 X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , linux-watchdog@vger.kernel.org, Andy Shevchenko , Marc Zyngier , Bartosz Golaszewski , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Guenter Roeck , devicetree@vger.kernel.org, Jean Delvare , Jason Cooper , linux-gpio@vger.kernel.org, Rob Herring , Thomas Gleixner , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Li Yang , Mark Brown , Shawn Guo Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 2020-06-08 16:24, schrieb Lee Jones: > On Mon, 25 May 2020, Michael Walle wrote: >> Am 2020-05-15 12:28, schrieb Lee Jones: >> > On Thu, 30 Apr 2020, Michael Walle wrote: >> > >> > > Hi Lee, >> > > >> > > Am 2020-04-23 19:45, schrieb Michael Walle: >> > > > There might be multiple children with the device tree compatible, for >> > > > example if a MFD has multiple instances of the same function. In this >> > > > case only the first is matched and the other children get a wrong >> > > > of_node reference. >> > > > Add a new option to match also against the unit address of the child >> > > > node. Additonally, a new helper OF_MFD_CELL_REG is added. > > [...] > >> > > > diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h >> > > > index d01d1299e49d..c2c0ad6b14f3 100644 >> > > > --- a/include/linux/mfd/core.h >> > > > +++ b/include/linux/mfd/core.h >> > > > @@ -13,8 +13,11 @@ >> > > > #include >> > > > >> > > > #define MFD_RES_SIZE(arr) (sizeof(arr) / sizeof(struct resource)) >> > > > +#define MFD_OF_REG_VALID BIT(31) >> > >> > What about 64bit platforms? >> >> The idea was to have this as a logical number. I.e. for now you may >> only >> have one subdevice per unique compatible string. In fact, if you have >> a >> look at the ab8500.c, there are multiple "stericsson,ab8500-pwm" >> subdevices. But there is only one DT node for all three of it. I guess >> this works as long as you don't use phandles to reference the pwm node >> in the device tree. Or you don't want to use device tree properties >> per subdevice (for example the "timeout-sec" of a watchdog device). > > This is not a good example, as the "stericsson,ab8500-pwm" is > legitimate. Here we are registering 3 potential devices, but only > instantiating 1 of them. Mh? static const struct mfd_cell ab8500_devs[] = { .. OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 1, "stericsson,ab8500-pwm"), OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 2, "stericsson,ab8500-pwm"), OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 3, "stericsson,ab8500-pwm"), .. } And in pwm-ab8500.c there are three offsets based on the pdev->id. Am I missing something here? -- -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel