From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F086C433E0 for ; Tue, 26 Jan 2021 17:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 700A322472 for ; Tue, 26 Jan 2021 17:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389613AbhAZRui (ORCPT ); Tue, 26 Jan 2021 12:50:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38713 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390134AbhAZIaN (ORCPT ); Tue, 26 Jan 2021 03:30:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611649726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bhV4Mq5/sBWiSQk3XJm+QtpJxWDhek1THdWB8YUzVxE=; b=gDVwcKsOHAPEnXI7g+VHzM/wEB6hZ3IMrTylTl5dXzr6xzfO/tI95kKzs0wz9O9P48GbNt 9HAjX5e6xiklSk5WjkO7/DgkSCgSj5vuz8eslTZhaYmRmO6gS43HhpqhEwEZpIP7XZ6VVQ VYexVSihAwQdRv7ne0eEEhLKxW4vSeY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83--4Inxhf7N6asR7JiI5xpBw-1; Tue, 26 Jan 2021 03:28:44 -0500 X-MC-Unique: -4Inxhf7N6asR7JiI5xpBw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFFA310054FF; Tue, 26 Jan 2021 08:28:42 +0000 (UTC) Received: from [10.72.12.70] (ovpn-12-70.pek2.redhat.com [10.72.12.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B76672168; Tue, 26 Jan 2021 08:28:35 +0000 (UTC) Subject: Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call To: Cindy Lu , mst@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: stable@vger.kernel.org References: <20210126071607.31487-1-lulu@redhat.com> From: Jason Wang Message-ID: <757a05d2-c82e-e957-1b7c-55eb64495f1b@redhat.com> Date: Tue, 26 Jan 2021 16:28:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210126071607.31487-1-lulu@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/1/26 下午3:16, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Cc: stable@vger.kernel.org > Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") > Signed-off-by: Cindy Lu Acked-by: Jason Wang > --- > drivers/vhost/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index ef688c8c0e0e..3fbb9c1f49da 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -319,7 +319,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp) > struct eventfd_ctx *ctx; > > cb.callback = vhost_vdpa_config_cb; > - cb.private = v->vdpa; > + cb.private = v; > if (copy_from_user(&fd, argp, sizeof(fd))) > return -EFAULT; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 299FAC433E0 for ; Tue, 26 Jan 2021 08:28:51 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6AB722242 for ; Tue, 26 Jan 2021 08:28:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6AB722242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4C39787016; Tue, 26 Jan 2021 08:28:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j1sEUKdzg6ER; Tue, 26 Jan 2021 08:28:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id D70528700A; Tue, 26 Jan 2021 08:28:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B8F01C08A1; Tue, 26 Jan 2021 08:28:49 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7BB0CC013A for ; Tue, 26 Jan 2021 08:28:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5C85D20386 for ; Tue, 26 Jan 2021 08:28:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jDWTOAeUfliI for ; Tue, 26 Jan 2021 08:28:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by silver.osuosl.org (Postfix) with ESMTPS id 7CAB920101 for ; Tue, 26 Jan 2021 08:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611649726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bhV4Mq5/sBWiSQk3XJm+QtpJxWDhek1THdWB8YUzVxE=; b=gDVwcKsOHAPEnXI7g+VHzM/wEB6hZ3IMrTylTl5dXzr6xzfO/tI95kKzs0wz9O9P48GbNt 9HAjX5e6xiklSk5WjkO7/DgkSCgSj5vuz8eslTZhaYmRmO6gS43HhpqhEwEZpIP7XZ6VVQ VYexVSihAwQdRv7ne0eEEhLKxW4vSeY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83--4Inxhf7N6asR7JiI5xpBw-1; Tue, 26 Jan 2021 03:28:44 -0500 X-MC-Unique: -4Inxhf7N6asR7JiI5xpBw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFFA310054FF; Tue, 26 Jan 2021 08:28:42 +0000 (UTC) Received: from [10.72.12.70] (ovpn-12-70.pek2.redhat.com [10.72.12.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B76672168; Tue, 26 Jan 2021 08:28:35 +0000 (UTC) Subject: Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call To: Cindy Lu , mst@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org References: <20210126071607.31487-1-lulu@redhat.com> From: Jason Wang Message-ID: <757a05d2-c82e-e957-1b7c-55eb64495f1b@redhat.com> Date: Tue, 26 Jan 2021 16:28:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210126071607.31487-1-lulu@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Cc: stable@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Ck9uIDIwMjEvMS8yNiDkuIvljYgzOjE2LCBDaW5keSBMdSB3cm90ZToKPiBJbiB2aG9zdF92ZHBh X3NldF9jb25maWdfY2FsbCwgdGhlIGNiLnByaXZhdGUgc2hvdWxkIGJlIHZob3N0X3ZkcGEuCj4g dGhpcyBjYi5wcml2YXRlIHdpbGwgZmluYWxseSB1c2UgaW4gdmhvc3RfdmRwYV9jb25maWdfY2Ig YXMKPiB2aG9zdF92ZHBhLiBGaXggdGhpcyBpc3N1ZS4KPgo+IENjOiBzdGFibGVAdmdlci5rZXJu ZWwub3JnCj4gRml4ZXM6IDc3NmYzOTUwMDRkODIgKCJ2aG9zdF92ZHBhOiBTdXBwb3J0IGNvbmZp ZyBpbnRlcnJ1cHQgaW4gdmRwYSIpCj4gU2lnbmVkLW9mZi1ieTogQ2luZHkgTHUgPGx1bHVAcmVk aGF0LmNvbT4KCgpBY2tlZC1ieTogSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4KCgo+ IC0tLQo+ICAgZHJpdmVycy92aG9zdC92ZHBhLmMgfCAyICstCj4gICAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Zo b3N0L3ZkcGEuYyBiL2RyaXZlcnMvdmhvc3QvdmRwYS5jCj4gaW5kZXggZWY2ODhjOGMwZTBlLi4z ZmJiOWMxZjQ5ZGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy92aG9zdC92ZHBhLmMKPiArKysgYi9k cml2ZXJzL3Zob3N0L3ZkcGEuYwo+IEBAIC0zMTksNyArMzE5LDcgQEAgc3RhdGljIGxvbmcgdmhv c3RfdmRwYV9zZXRfY29uZmlnX2NhbGwoc3RydWN0IHZob3N0X3ZkcGEgKnYsIHUzMiBfX3VzZXIg KmFyZ3ApCj4gICAJc3RydWN0IGV2ZW50ZmRfY3R4ICpjdHg7Cj4gICAKPiAgIAljYi5jYWxsYmFj ayA9IHZob3N0X3ZkcGFfY29uZmlnX2NiOwo+IC0JY2IucHJpdmF0ZSA9IHYtPnZkcGE7Cj4gKwlj Yi5wcml2YXRlID0gdjsKPiAgIAlpZiAoY29weV9mcm9tX3VzZXIoJmZkLCBhcmdwLCBzaXplb2Yo ZmQpKSkKPiAgIAkJcmV0dXJuICAtRUZBVUxUOwo+ICAgCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmly dHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51 eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=