From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752247AbdHNNqT (ORCPT ); Mon, 14 Aug 2017 09:46:19 -0400 Received: from mail-sn1nam01on0074.outbound.protection.outlook.com ([104.47.32.74]:33328 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751510AbdHNNqR (ORCPT ); Mon, 14 Aug 2017 09:46:17 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 2/2] video: fbdev: Enable Xilinx FB for ZynqMP To: Linus Walleij , Michal Simek CC: "linux-kernel@vger.kernel.org" , "monstr@monstr.eu" , Daniel Vetter , Benjamin Gaignard , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Arnd Bergmann , "linux-fbdev@vger.kernel.org" , Krzysztof Kozlowski , Paul Burton References: From: Michal Simek Message-ID: <757d86d1-cca5-3a99-a371-a4c7e1c76f9b@xilinx.com> Date: Mon, 14 Aug 2017 15:46:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23256.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(24454002)(199003)(189002)(377454003)(64126003)(6246003)(86362001)(53546010)(626005)(4326008)(36756003)(31696002)(50986999)(478600001)(76176999)(54356999)(23676002)(31686004)(33646002)(54906002)(189998001)(2950100002)(6666003)(50466002)(77096006)(106466001)(63266004)(229853002)(36386004)(83506001)(65826007)(5660300001)(7416002)(2906002)(4001350100001)(81156014)(230700001)(81166006)(65806001)(356003)(65956001)(8676002)(47776003)(8936002)(305945005)(9786002)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR02MB2256;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT049;1:waEIL6xyD/byewyssA5QKZW8yraRyuTizkFfi1uQFrD104U3h7kFpJVEaXzmV/2CFY0CEEBM6XPeML+y01TYHxuowVvt30AGLQdk8thHoZiyl1W1wJ4JJsihZgQ1GlcOeS+rvu8wdqbHf0IstUYUc8QE9nvEFfExtPw7ZARdhJGENdq1OkDxoMN2pf4r2BhYDBySXyWU6FJVXbvDcJdtgoyUh2ebHZypD0W7JCMy+9HNIJdoE0+M34wx3LReuM8i5y3T5LitfRK0ZCLQ1tM7NxSedqw5pW7QIFC+IPg9vEbn6PV0yjJ+AmITvoilv5pMjNrYd8e2a5aphWE3u4J4ivBw+o7oiDZ10iYBSIDwEqhdy8ivBLKGXQbuN684PqHEPEfp9iyNs/cJ1cQ3N5zdXzWkIm4dDWkkhdXAU4hsVCStUr9tHnvvUqqALI8kvpYBdiZBiB7IhvxorWt6twqtwtjxu0UU9iqG/Eu6MUnkcMuYDNGNNP/XiX1ZRW4+ILGM83KF8dR8isHLbCvznGkB8p6hfPTnI7b5GCv0Hj4GUXgghkxxkyQ2lMh+4VDhZk5xulxaIca5qbohpQiFQgcCc74EtZ7sHCiUpYLpC13RG5i6juORoJX4mrXVw7hhUhmJj/yPfKB9FcQYfDdmmG5kQF/VPT5pkMW0EWe6T77vhUL6RCwB59tBt5HDNXaHsdFvY0l1AocWCPWaVYKb07xIUBjogMlu2zG7vTp7KAtW05flaAv8TS4MpFO02kNpR8xmNCMqbUWqJV7R8/SyZHQnP3YpSV9RW8lTnjDeL0bRKVAFIdOzKcEAw7NtoOwCfmLAw/kn41JUzTDHC+YzJL1uIQ== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 642a8e6b-80e1-4e39-c6ef-08d4e31ad3f3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR02MB2256; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2256;3:jDAXZiIp2XKqqxuMxkYkXs2nZDmww3JhnjHrI37kcPTxOFHVgvhGC0XbeOANP0Bqy52CXjQTofFRMYyhXmP3i7Gd0j1amw2/TJDFZORmo9QC7Z3Sw53zz2fL9BExvp9mV4If83jXdZ9kaidbK9L1zd2LDoxQ2CzYXQ/W3VCJy9ZVCt/Koy4rElUsE9JACQoNTGoQKzMb7klElOzifNo3TrL1RXQJUXIBF7A/egGcDYyTR96PDHJfalz2DeK5qXO969+rUkj+v5WTwzpcVnYSRhxbU4PTQoK9v4mv7MSb/E520du2GzLcYNtA7eZ3tZIjBX64W/FJ21FzQ7IV2HexNNdLvXuhiW9H8LG9RaKQ7uE=;25:vfqmogrL+ZIhl31ZXjM3kjJ+l6XazscUaM0wW6AO7NKFe0BMRV2vFLQIuc7kw/BjlYMZv6hAPwbVxnoTmYVi7Aokp1v+IQFPUzw5+i/8NSQQU70jXpboQO3Nn0ft3U8Rjr7MoDskanQKYPwLZ7nwUn+/49V6+77j1keLpSuwCtPE4Tpg4Rewdbd6t6ILkY+sPNCeUiol5sv+0tNa4vlgJZ21K0nJYwCbkHJj3p4a6vEXQtIZM3ikQ5KRXZ48t5VTOW4C2b6F3hsgOnUmFnbLej8hzklFvZVqnzUbXRQGkmbR3fBTJ10qQjo4QEmObWRXAkHbmNU5ZR2OVZ+CKSdB5w== X-MS-TrafficTypeDiagnostic: MWHPR02MB2256: X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2256;31:vHzeouOStnLSdSGviRpcRVxmu2LHQNe02l4pwvPZdpXkkyghKlMBq40JO23HInQ8a71yseQRKyRMslmAvHuMH3AxocnTlPx+EAAuQjD5NSOjDs66cxMfq6AlgjcCC0uezYRztYrjKCDG4+kDtKvCtq2Mcp5i+SeiH3wBpatYabIxqiuS+qG1n0XZ9t71L2BVXgAxyyCwPyzLlw+JebYRG85Wt0ppBwTT0B0uH3WH7rM=;20:xrg7bQ32duHRlfftWScjg5oOdPY7+uwrCm4XuihgQBgr5iB5f4CIvt4jndmQ7L6XLvcBK8ws66RvH9hUokviaWHH4ohdRBFvNAeCJ2SGkzggxuTb14Q7zbHFZbZ6tXBVRZq1lqj8uI8aKSZXwPh0ZuPihLuKI1ipio6lzRbfkEFsoVdeUYrGCB8/pxuWZcbmKK/F6Pp+ptfQHj6fzauorO2+0hNsLV7DnxzoU0VRaj4c2jWHa/laJd+A88zY2ZGlMGzqZf/ZcCzTP5ACR0FZUhA88OE1jmNZgk8PwxA4aQNy0vIA9LaAU1MCCpMf+AtnzMZctZd0aLn5ltdQj3QYzrLgjkteNaRmorU4YSK7URnIrLPIJXFF1vBUgVj49Y5zaf3ehoZqp1/10fT4T3w7fb3epikFkV/M/NmDPVF4zp6KDflr+4iYa35UMpLxqHSPkIsfD27CXdE8vd0aJQnlMhhKD7lblYcVo2C2EitI240Xqm0MiYCy57RFVCHfnXIG X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93004095)(6055026)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR02MB2256;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR02MB2256; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2256;4:9CxDERbh7cIaA3Idzx0WlTXKQuuMoqJn1tJPOZ+jIwu5rjv+zgEm9kEmv1x3kjefbnJnqM8/d5ZeMv3QBnvSd00hkj1NAPPlhkIt8EwByKdg8twkmzoHpAefQO3ejb1KhILqTkcLZJIZ23O6uDUHmDLq+sGxREV3cinqpFvlr7opmda8t5SFDsFU5XJoCK67DiZN4O1p36R3WJMDIXm/2DovLvAjKdu/1Jp0jlYUm+uNzBOS22gJZAlYh/Xwi8L4mg7PwJ6C1UhJWAjtgi8NVZvFBq2LKmkCgpJUKhJbh34= X-Forefront-PRVS: 039975700A X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAyTUIyMjU2OzIzOlMrY3A2SHZFU29mMFVNS3A3dk44eDloY292?= =?utf-8?B?Y01LcDROejhZV1IyWm5oZ2N0c1ZsNlNvUyt1bDJVWEtTcERRR0U2dlVlakY0?= =?utf-8?B?Ujk4SnRPejhIeU9CWGZSbmNoNW9qckNlQWlCSFhBRmIwS1pjWE1qdUFvdk1C?= =?utf-8?B?WUxYY3pDMkh3NkwvUGFmS2FWYmJEWFlieUVrK0IwZUlUeUNDcTN5am4waDVu?= =?utf-8?B?aUFqV0FuL0FqdFVCWlFDSTZnSW1HOVA3Rk5sL3ZwWnUwWWtQZGRmZGVuaEF2?= =?utf-8?B?NlErZm5pRUFhYm41VGlpMjJTS2E2TFVMQmlGT3hyVzNkVG5iSnZKdXF1QWsy?= =?utf-8?B?WS9Uc21IWXZRWUhEY2hsZ2JLcmpBUDQ2Mnl4VHl4aUlwakF4eGFYRGVPV2x4?= =?utf-8?B?NE02clY5Qld6eHhZNjgwZGxvSFN5NjdiTzJKbjFubC8wcUgzQWtwNTBFTjMx?= =?utf-8?B?bktWWXBGNWRHbkVQV1hlMFZlTGVEUkY4SnBVMzJEWEZkOXVobC9TOWJxSFpt?= =?utf-8?B?QUk5bVA3UXY4ZTU4Z2trdmVsd3NjWTlGZEduNXgzc1U4cVdvRnFXc1ZKUDdr?= =?utf-8?B?NmR3bktVaTVrQmRYck9YWWlPQ0Ryd2w2UjgvTS9QY1VEdFpIWUdjUlg1UDZI?= =?utf-8?B?dnJGWXV2RUlJOW9SYUh5NklTVU1HbCs2M29tcE9STXJkSGZ2T1JvcFRlMG1x?= =?utf-8?B?SlNMNDY2bmpyK3NOZDg4OWM5NEFWVUFMbm1iUEhYdCtndUNzZFJSeXNGZWVs?= =?utf-8?B?L2U1SklUZ1FzSlN3V2pFSzFoVFNZQzVrWWlNbGRyQk1LVGZ4SGZPbHlKVHEy?= =?utf-8?B?cnpma1hYWW1yTnZnR09tN1JUNk1obDd3enNkZUowaG01RERCMmFjMFNrRmVo?= =?utf-8?B?SVhnczUvN0gyc21vU3U0UTFyUjhGN1Z6aXJpR1gwRWpQZFNhNkdGMWhkTGk4?= =?utf-8?B?T3hYcElGWU5hcnFzcXVPdG1UZGI3bDJXMVc2dUIzSWcrQmozY0ZpVXdYZnpH?= =?utf-8?B?OC85V2xUWXV1aFB5ZVhySjhjN3pTcWNneVlkSVRtMS9zT0hBbG9hWkp3cXVr?= =?utf-8?B?M2xwNVMxTUUwa050NVQ4VmwxT2RPc0hXY0V4eTB6dXFNVkdaelM2d1JQekdt?= =?utf-8?B?dmxkOXdLbkpvTWFPbjZsc2hHK2RYMlNzQ2QvSkJGM0hkM0xaeGhtUjZuVGNI?= =?utf-8?B?T2twbjl2bnQ5RzU1dG10dnYrOWtxYkxta3hEWWJkbUVhQnltVlhMTmVCZEtY?= =?utf-8?B?eWdQT3ZEdTV5U3FHbUFPc1NsUFpmb2RGZGo1eGtBSEhJSWpQVXpUZXllSThw?= =?utf-8?B?ZXczZTZBeFFqdWI0NDQzMDNWbHZENTUxWE1GbUc4ZEdMRFMrSjhMSjExRWFV?= =?utf-8?B?SGhrdlhDQUlpNTRTck5hMU9NNkhwazRvUEswNUl5WC9adEdkd0JzZEh5UUVx?= =?utf-8?B?dlpOeVZ3UzZjT2dsejRoQlFtaUFkbmFreE9naENSN2Zkcmh4ZUdYMXAxYWJr?= =?utf-8?B?N0hPRkRKYkxGV1JvL28xbG5pNkNmYWRRZ0JMdk52OWZuNUZRbGVuVHlsb1pE?= =?utf-8?B?eitHTEhIcmh0ZDZwcHBEUkxZRFF2dDNEb29URXU4ckcwRXY4ZkNRL0FQV1Rv?= =?utf-8?B?RmpKWkVOQW82UE1hY0dKRmVPUkZKdHBoYlU4a2h0RVc0eUR2bzB3QTEwMHZW?= =?utf-8?Q?mbCqunLKklniVEtD8Y=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2256;6:onTkgHoUdLg0PCklRJFVQg6qhpGk8wp6A+rx2CsgsQgNHonXBnsed75i44XDYKiRBRPSXyvw1DkKAaZj1iOhCmzAIjL+NyGNE04BI6QogSmEzjvutFpjqefLtQuH0MGR1kQfRWw2onYMqDTJgbwLgszbjPiNXetnEpjnTAkN0BBvqbv0bitt/VSaUNfsK7/NoW9Ovx/jkiFp8HOZMo8BxqyIeUQHMEoru159muU59dAOulrrp0JTSYlt1d1+WQ/fvBhb6w/zIUIXsUshP2HFvTrMMQjce21T1irasAKBR3f0OfJbPvBsQeuohCxZHdnQGC7Ow62amFpXyPgjnHHtEA==;5:dzYQlmCXgVi8U0XJf/jG1Ee9NBVUd9ICjcYGtgzYSLyp2+eXtV3EJng2+GsWk4+z6wmVkV6CCwKyi9KFSualCUFQsW2kB+fFPgnpZnhHEhJAFLYSJtQvGzLFjVCqxX4t4GBoZAfFDh4zd6+p7C+T5g==;24:eR4PkhjvByrg24Edz15I4URZu4p7xEJ+1MzvTFeOjJ/wN7GDR4fI7tqV5m14kmADGNiZ7wRuBq9RDhroSwy7kargA/t/xczxoAdQcnrGNlQ=;7:z/3iX1pQ0NwGZoygrbYn+ifngnMTgzHSA3dCM8CsSUK3zbWR0ljIY55o92ODqEFVuNsr4V6p/rMb2fLWsrW+eQt+7roT9EEe/JySNjbyo11Q/Rxw0Ru0pwGUojSt7tfOog1R8ZrdPljHad81lmR2t2Exl3J3vK78nYJ+j4VdyjhtIHrFgzpBe0BXtZO70oHvArv93xMmYibE0rcx625YGzgH7KIDHgZw0CBtKTOXsws= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2017 13:46:12.3518 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2256 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.8.2017 15:42, Linus Walleij wrote: > On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek wrote: > >> Enable this driver for Xilinx ZynqMP. >> >> Signed-off-by: Michal Simek > > Not a comment on the patch per se, but I would advice you to look into > migrating the Xilinx frame buffer to DRI/DRM/KMS. > > The recent CMA helpers has made it very simple and focused to write > DRM drivers. See for example drivers/gpu/drm/pl111 There is a lot of work done by xilinx in this area gpu/drm/kms. I am trying to upstream what xilinx has in soc tree and this change is there. Maybe in this case it is useless and none is using it but it is there and I don't want to break user. There shouldn't be any technical problem to run this old fb driver in pl on arm64. Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 14 Aug 2017 13:46:00 +0000 Subject: Re: [PATCH 2/2] video: fbdev: Enable Xilinx FB for ZynqMP Message-Id: <757d86d1-cca5-3a99-a371-a4c7e1c76f9b@xilinx.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Walleij , Michal Simek Cc: "linux-kernel@vger.kernel.org" , "monstr@monstr.eu" , Daniel Vetter , Benjamin Gaignard , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Arnd Bergmann , "linux-fbdev@vger.kernel.org" , Krzysztof Kozlowski , Paul Burton On 14.8.2017 15:42, Linus Walleij wrote: > On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek wrote: > >> Enable this driver for Xilinx ZynqMP. >> >> Signed-off-by: Michal Simek > > Not a comment on the patch per se, but I would advice you to look into > migrating the Xilinx frame buffer to DRI/DRM/KMS. > > The recent CMA helpers has made it very simple and focused to write > DRM drivers. See for example drivers/gpu/drm/pl111 There is a lot of work done by xilinx in this area gpu/drm/kms. I am trying to upstream what xilinx has in soc tree and this change is there. Maybe in this case it is useless and none is using it but it is there and I don't want to break user. There shouldn't be any technical problem to run this old fb driver in pl on arm64. Thanks, Michal