From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85B77C433F5 for ; Wed, 20 Apr 2022 19:27:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C950910F1AC; Wed, 20 Apr 2022 19:27:02 +0000 (UTC) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4932310F1AC for ; Wed, 20 Apr 2022 19:27:02 +0000 (UTC) Received: by mail-lf1-x12b.google.com with SMTP id x17so4735822lfa.10 for ; Wed, 20 Apr 2022 12:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=RIUBFkbZrZkxS27rBDUvLlFldg+VYqMH2xYhKesN9xk=; b=hmiGe+xLzHjl+QbCVNJdlb49oLldlGxCylsU7/0wC/HDBfUQxRIYwiUQgTLZOLkbul duKTlQlnsjOIh6Buy8N8MucThrjEVKiR+rnTj8UDuNtTLblkVYvIg0MlAjEHvqyyvNnI nEx7jRZkpwC6otS1ibfSxxtbzvwjDKMcOJdql+acP2y48ljsi6RKrfFMdlk9aZxBS0PT HWXP7nusUyrkY6OjaYhzkDoA1HmXMwcg8o63vkK8ezIOe4MTPM5S4IOBi1s8uKyDYfHx MLQmFnJ50Fz3oRWpQhIWXel7JT3TIRUPFKv3ElPmtkE1y4KVXzWiAy0yRkF/gMM9uXYv /tBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=RIUBFkbZrZkxS27rBDUvLlFldg+VYqMH2xYhKesN9xk=; b=UiW36iuqonH12KsauqjF1wFXgnKvUlo2jU5GcRSvZ75aLQPnZujOZwRvtyK26m9iSl 2WRcAOxcDaXsgzoPiUG73tme4s1P4iEGkPmDuRREkhjLKiSa0IPX61bA8qCGlQY8d37x 9DgakKpPP7M0T5ZzZiOBlRMDuGf/hya4YSj3t+Mvyg6KkrvKExYo6TRhOcuImm+FX5+m BHrqLLcV6on7Z++mxkIxJTMrxOpPB3hxVMmF/JcYiXRcWDnASk7Dxh2eo4hGgW44c3cG g6N15eV7Te0JDfeIMuG7Ja2KPvKYuD9IprdWeU5RqQ/1Js/NAdofENHTcT022tLyeYpX v2jQ== X-Gm-Message-State: AOAM530GCREQSPRGBKZo8/g7IBZ2LzqRWS5jnMPryyfWpmpoYVsDgWCK fGY4us48VNXDLNs5CtMdIT5uyw== X-Google-Smtp-Source: ABdhPJyvXV91q3XBpUnZ9wA9wvVxSI+iJ2lUYdCBzfe+nEQXaXT70tM92BJkt/jm46kudeZwjInQ4A== X-Received: by 2002:a05:6512:110a:b0:471:9b68:34e3 with SMTP id l10-20020a056512110a00b004719b6834e3mr9962184lfg.150.1650482820601; Wed, 20 Apr 2022 12:27:00 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x23-20020a056512131700b004486c863c8esm1923628lfu.257.2022.04.20.12.26.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Apr 2022 12:27:00 -0700 (PDT) Message-ID: <7591cb3a-3887-2b47-e48c-4f370b33c310@linaro.org> Date: Wed, 20 Apr 2022 22:26:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 14/17] drm/msm/dpu: add the writeback connector layer Content-Language: en-GB To: Abhinav Kumar , freedreno@lists.freedesktop.org References: <1650419169-13760-1-git-send-email-quic_abhinavk@quicinc.com> <1650419169-13760-15-git-send-email-quic_abhinavk@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <1650419169-13760-15-git-send-email-quic_abhinavk@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: markyacoub@chromium.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, swboyd@chromium.org, seanpaul@chromium.org, laurent.pinchart@ideasonboard.com, quic_jesszhan@quicinc.com, quic_aravindh@quicinc.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 20/04/2022 04:46, Abhinav Kumar wrote: > Introduce the dpu_writeback module which serves as the > interface between dpu operations and the drm_writeback. > > This module manages the connector related operations for > dpu writeback. > > changes in v2: > - start using drm_writeback_connector_init_with_encoder() > - drop unnecessary arguments from dpu_writeback_init() > - rebase on msm-next tip and remove usage of priv->connectors > > Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/Makefile | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 68 +++++++++++++++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.h | 25 ++++++++++ > 3 files changed, 94 insertions(+) > create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c > create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.h > > diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile > index 0387f22..66395ee 100644 > --- a/drivers/gpu/drm/msm/Makefile > +++ b/drivers/gpu/drm/msm/Makefile > @@ -80,6 +80,7 @@ msm-$(CONFIG_DRM_MSM_DPU) += \ > disp/dpu1/dpu_plane.o \ > disp/dpu1/dpu_rm.o \ > disp/dpu1/dpu_vbif.o \ > + disp/dpu1/dpu_writeback.o > > msm-$(CONFIG_DRM_MSM_MDSS) += \ > msm_mdss.o \ > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c > new file mode 100644 > index 0000000..526d884 > --- /dev/null > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c > @@ -0,0 +1,68 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#include "dpu_writeback.h" > + > +static int dpu_wb_conn_get_modes(struct drm_connector *connector) > +{ > + struct drm_device *dev = connector->dev; > + > + return drm_add_modes_noedid(connector, dev->mode_config.max_width, > + dev->mode_config.max_height); > +} > + > +static const struct drm_connector_funcs dpu_wb_conn_funcs = { > + .reset = drm_atomic_helper_connector_reset, > + .fill_modes = drm_helper_probe_single_connector_modes, > + .destroy = drm_connector_cleanup, > + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, > + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > +}; > + > +static int dpu_wb_conn_prepare_job(struct drm_writeback_connector *connector, > + struct drm_writeback_job *job) > +{ > + if (!job->fb) > + return 0; > + > + dpu_encoder_prepare_wb_job(connector->encoder, job); > + > + return 0; > +} > + > +static void dpu_wb_conn_cleanup_job(struct drm_writeback_connector *connector, > + struct drm_writeback_job *job) > +{ > + if (!job->fb) > + return; > + > + dpu_encoder_cleanup_wb_job(connector->encoder, job); > +} > + > +static const struct drm_connector_helper_funcs dpu_wb_conn_helper_funcs = { > + .get_modes = dpu_wb_conn_get_modes, > + .prepare_writeback_job = dpu_wb_conn_prepare_job, > + .cleanup_writeback_job = dpu_wb_conn_cleanup_job, > +}; > + > +int dpu_writeback_init(struct drm_device *dev, struct drm_encoder *enc, > + const u32 *format_list, u32 num_formats) > +{ > + struct dpu_wb_connector *dpu_wb_conn; > + int rc = 0; > + > + dpu_wb_conn = devm_kzalloc(dev->dev, sizeof(*dpu_wb_conn), GFP_KERNEL); > + > + drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_funcs); > + > + /* DPU initializes the encoder and sets it up completely for writeback > + * cases and hence should use the new API drm_writeback_connector_init_with_encoder > + * to initialize the writeback connector > + */ > + rc = drm_writeback_connector_init_with_encoder(dev, &dpu_wb_conn->base, enc, > + &dpu_wb_conn_funcs, format_list, num_formats); > + > + return rc; > +} > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.h > new file mode 100644 > index 0000000..05aff05 > --- /dev/null > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.h > @@ -0,0 +1,25 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#ifndef _DPU_WRITEBACK_H > +#define _DPU_WRITEBACK_H > + > +#include > +#include > +#include > +#include > + > +#include "msm_drv.h" > +#include "dpu_kms.h" > +#include "dpu_encoder_phys.h" > + > +struct dpu_wb_connector { > + struct drm_writeback_connector base; > +}; > + > +int dpu_writeback_init(struct drm_device *dev, struct drm_encoder *enc, > + const u32 *format_list, u32 num_formats); > + > +#endif /*_DPU_WRITEBACK_H */ -- With best wishes Dmitry