From: Luben Tuikov <luben.tuikov@amd.com>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Pelloux-prayer,
Pierre-eric" <Pierre-eric.Pelloux-prayer@amd.com>,
"Olsak, Marek" <Marek.Olsak@amd.com>,
"Liu, Aaron" <Aaron.Liu@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests
Date: Tue, 11 Feb 2020 18:28:36 -0500 [thread overview]
Message-ID: <759679d7-6e14-84a9-8334-7a591b35a92c@amd.com> (raw)
In-Reply-To: <CH2PR12MB3912CCDC4F15E6B7B1E92543F7180@CH2PR12MB3912.namprd12.prod.outlook.com>
Looks fine to me as well. Just as Christian said, would have to be approved by
Marek.
Regards,
Luben
On 2020-02-11 9:57 a.m., Deucher, Alexander wrote:
> Yes, correct.
>
> Alex
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Huang, Ray <Ray.Huang@amd.com>
> *Sent:* Tuesday, February 11, 2020 9:35 AM
> *To:* Deucher, Alexander <Alexander.Deucher@amd.com>; Christian König <ckoenig.leichtzumerken@gmail.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
> *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer@amd.com>; Olsak, Marek <Marek.Olsak@amd.com>; Liu, Aaron <Aaron.Liu@amd.com>; Tuikov, Luben <Luben.Tuikov@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>
> *Subject:* RE: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests
>
>
> [AMD Public Use]
>
>
>
> Hi Alex,
>
>
>
> MR = merge request? Should I create account to send merge request in the freedesktop gitlab?
>
>
>
> Thanks,
>
> Ray
>
>
>
> *From:* Deucher, Alexander <Alexander.Deucher@amd.com>
> *Sent:* Tuesday, February 11, 2020 10:30 PM
> *To:* Christian König <ckoenig.leichtzumerken@gmail.com>; Huang, Ray <Ray.Huang@amd.com>; amd-gfx@lists.freedesktop.org
> *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer@amd.com>; Olsak, Marek <Marek.Olsak@amd.com>; Liu, Aaron <Aaron.Liu@amd.com>; Tuikov, Luben <Luben.Tuikov@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>
> *Subject:* Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests
>
>
>
> [AMD Public Use]
>
>
>
> Also, libdrm changes should go through a gitlab MR now.
>
>
>
> Alex
>
>
>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> *From:*Christian König <ckoenig.leichtzumerken@gmail.com <mailto:ckoenig.leichtzumerken@gmail.com>>
> *Sent:* Tuesday, February 11, 2020 6:39 AM
> *To:* Huang, Ray <Ray.Huang@amd.com <mailto:Ray.Huang@amd.com>>; amd-gfx@lists.freedesktop.org <mailto:amd-gfx@lists.freedesktop.org><amd-gfx@lists.freedesktop.org <mailto:amd-gfx@lists.freedesktop.org>>
> *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer@amd.com <mailto:Pierre-eric.Pelloux-prayer@amd.com>>; Olsak, Marek <Marek.Olsak@amd.com <mailto:Marek.Olsak@amd.com>>; Liu, Aaron <Aaron.Liu@amd.com <mailto:Aaron.Liu@amd.com>>; Tuikov, Luben <Luben.Tuikov@amd.com <mailto:Luben.Tuikov@amd.com>>; Deucher, Alexander <Alexander.Deucher@amd.com <mailto:Alexander.Deucher@amd.com>>; Koenig, Christian <Christian.Koenig@amd.com <mailto:Christian.Koenig@amd.com>>
> *Subject:* Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests
>
>
>
> Looks good on first glance, but Marek and/or Pierre can probably better
> judge than me.
>
> Christian.
>
> Am 11.02.20 um 12:22 schrieb Huang Rui:
>> So far, the amdgpu_cs_submit_raw2 is used for MesaGL, however the amdgpu tests
>> still use the legacy interface. So we would like to make amdgpu tests verify the
>> amdgpu_cs_submit_raw2 API.
>>
>> Thanks,
>> Ray
>>
>> Huang Rui (4):
>> amdgpu: use alloca for dependencies and sem_dependencies
>> amdgpu: use amdgpu_cs_submit_raw2 in amdgpu_cs_submit
>> amdgpu: remove the un-used chunk_array
>> amdgpu: clean up the cs structure variable
>>
>> amdgpu/amdgpu_cs.c | 36 +++++++++++++-----------------------
>> 1 file changed, 13 insertions(+), 23 deletions(-)
>>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-02-11 23:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 11:22 [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests Huang Rui
2020-02-11 11:23 ` [PATCH libdrm 1/4] amdgpu: use alloca for dependencies and sem_dependencies Huang Rui
2020-02-11 11:23 ` [PATCH libdrm 2/4] amdgpu: use amdgpu_cs_submit_raw2 in amdgpu_cs_submit Huang Rui
2020-02-11 11:23 ` [PATCH libdrm 3/4] amdgpu: remove the un-used chunk_array Huang Rui
2020-02-11 11:23 ` [PATCH libdrm 4/4] amdgpu: clean up the cs structure variable Huang Rui
2020-02-11 11:39 ` [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests Christian König
2020-02-11 14:29 ` Deucher, Alexander
2020-02-11 14:35 ` Huang, Ray
2020-02-11 14:57 ` Deucher, Alexander
2020-02-11 23:28 ` Luben Tuikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=759679d7-6e14-84a9-8334-7a591b35a92c@amd.com \
--to=luben.tuikov@amd.com \
--cc=Aaron.Liu@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Marek.Olsak@amd.com \
--cc=Pierre-eric.Pelloux-prayer@amd.com \
--cc=Ray.Huang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ckoenig.leichtzumerken@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.