From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77860C433FE for ; Thu, 6 Jan 2022 13:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239248AbiAFNK6 (ORCPT ); Thu, 6 Jan 2022 08:10:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238990AbiAFNK5 (ORCPT ); Thu, 6 Jan 2022 08:10:57 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5338EC061245; Thu, 6 Jan 2022 05:10:57 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id D8F9341F5D; Thu, 6 Jan 2022 13:10:47 +0000 (UTC) Subject: Re: [PATCH v2 12/35] brcmfmac: pcie: Fix crashes due to early IRQs To: Andy Shevchenko Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Dmitry Osipenko , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Linus Walleij , Hans de Goede , "John W. Linville" , "brian m. carlson" , "open list:TI WILINK WIRELES..." , netdev , devicetree , Linux Kernel Mailing List , ACPI Devel Maling List , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , SHA-cyfmac-dev-list@infineon.com References: <20220104072658.69756-1-marcan@marcan.st> <20220104072658.69756-13-marcan@marcan.st> From: Hector Martin Message-ID: <759f46bd-bfc2-62c6-6257-a2a0d702e2b6@marcan.st> Date: Thu, 6 Jan 2022 22:10:45 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: es-ES Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 04/01/2022 23.12, Andy Shevchenko wrote: > On Tue, Jan 4, 2022 at 9:29 AM Hector Martin wrote: >> >> The driver was enabling IRQs before the message processing was >> initialized. This could cause IRQs to come in too early and crash the >> driver. Instead, move the IRQ enable and hostready to a bus preinit >> function, at which point everything is properly initialized. >> >> Fixes: 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.") > > You should gather fixes at the beginning of the series, and even > possible to send them as a separate series. In the current state it's > unclear if there are dependencies on your new feature (must not be for > fixes that meant to be backported). > Thanks, I wasn't sure what order you wanted those in. I'll put them at the top for v3. I think none of those should have any dependencies on the rest of the patches, modulo some trivial rebase wrangling. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub