From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4778DC433F5 for ; Wed, 2 Mar 2022 11:16:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 671BB10E80C; Wed, 2 Mar 2022 11:16:29 +0000 (UTC) Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [81.169.146.165]) by gabe.freedesktop.org (Postfix) with ESMTPS id 492D110E905 for ; Wed, 2 Mar 2022 11:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1646219750; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=2E590GVKdRoZozo5tkYYbYzrccF+vxFAdL/JT2FI09M=; b=tozWRQmYDCzObU5/ZjhaM7E0SuLk6lsx38bX05TwJ41FYWhK3TxpIQtirgACLZwyWK bZ25sDR8MCOIccNxsb3TrhTIi2d8Q2c9J/zPRp3L3/ppfWVRjcBsi/7yM7sVFi0sNAvM e97CQ2/Vkm2WLzOKACbbrKn58iXR2E7T2+/2T+LvkutuITlwYkQA6yt+P2N78XZ6IvK3 8IN/wHeDTUA9/cEbaABSM7cjbiaj/pWUqI5FOvgbBNmmDVoCZPVB1QlEIjnT8vFF3Q0B DJcOh5oZqHBxz6H+pmILrm6qtv7ruVXsLLg5RLcwl/hVQGfw6TIHd533EfnqU55wHKEH /Ctw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHWElw43oQ+E=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.40.1 DYNA|AUTH) with ESMTPSA id V41e6fy22BFnToO (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 2 Mar 2022 12:15:49 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 2 Mar 2022 12:15:48 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <75CBD357-577A-402D-9E3B-DBE82A84BC43@goldelico.com> References: <169afe64b4985c3f420177cd6f4e1e72feeb2449.1645895582.git.hns@goldelico.com> <5da069b6-8a99-79c2-109c-c85715165857@baylibre.com> To: Neil Armstrong X-Mailer: Apple Mail (2.3445.104.21) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Boddie , Jonas Karlman , David Airlie , Robert Foss , linux-mips , dri-devel , linux-kernel , Paul Cercueil , Kieran Bingham , Maxime Ripard , Andrzej Hajda , Discussions about the Letux Kernel , Jernej Skrabec , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Neil, > Am 02.03.2022 um 11:25 schrieb Neil Armstrong = : >=20 >> I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO = is to be expected >> since I am using a HDMI connector and panel... So your patch will = still add the UYVY formats. >> Either the synposys module inside the jz4780 or the panel does not = understand them. >=20 > By selecting the UYVY formats, the driver will enable the colorspace = converters in the dw-hdmi IP, > I don't see why it doesn't work here... >=20 > There is a bit called `Support Color Space Converter` in config0_id: > bit | Name | R/W | Desc > 2 | csc | R | Indicates if Color Space = Conversion block is present >=20 > Could you dump all the config0 bits: >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D><=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c = b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 54d8fdad395f..547731482da8 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -3431,6 +3431,7 @@ struct dw_hdmi *dw_hdmi_probe(struct = platform_device *pdev, > pdevinfo.id =3D PLATFORM_DEVID_AUTO; >=20 > config0 =3D hdmi_readb(hdmi, HDMI_CONFIG0_ID); > + dev_info(dev, "config0: %x\n", config0); > config3 =3D hdmi_readb(hdmi, HDMI_CONFIG3_ID); >=20 > if (iores && config3 & HDMI_CONFIG3_AHBAUDDMA) { > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D><=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >=20 > If this bit is missing, this would explain the black screen. [ 9.291011] dw-hdmi-ingenic 10180000.hdmi: config0: bf Hm. Or is the color-space conversion of the sw-hdmi module inside the = jz4780 broken or not configured properly? (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi =3D = false) BR and thanks, Nikolaus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C48C433EF for ; Wed, 2 Mar 2022 11:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238366AbiCBLTS (ORCPT ); Wed, 2 Mar 2022 06:19:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241790AbiCBLSt (ORCPT ); Wed, 2 Mar 2022 06:18:49 -0500 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4885960A8C; Wed, 2 Mar 2022 03:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1646219750; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=2E590GVKdRoZozo5tkYYbYzrccF+vxFAdL/JT2FI09M=; b=tozWRQmYDCzObU5/ZjhaM7E0SuLk6lsx38bX05TwJ41FYWhK3TxpIQtirgACLZwyWK bZ25sDR8MCOIccNxsb3TrhTIi2d8Q2c9J/zPRp3L3/ppfWVRjcBsi/7yM7sVFi0sNAvM e97CQ2/Vkm2WLzOKACbbrKn58iXR2E7T2+/2T+LvkutuITlwYkQA6yt+P2N78XZ6IvK3 8IN/wHeDTUA9/cEbaABSM7cjbiaj/pWUqI5FOvgbBNmmDVoCZPVB1QlEIjnT8vFF3Q0B DJcOh5oZqHBxz6H+pmILrm6qtv7ruVXsLLg5RLcwl/hVQGfw6TIHd533EfnqU55wHKEH /Ctw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHWElw43oQ+E=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.40.1 DYNA|AUTH) with ESMTPSA id V41e6fy22BFnToO (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 2 Mar 2022 12:15:49 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 2 Mar 2022 12:15:48 +0100 Cc: Paul Boddie , Maxime Ripard , Jonas Karlman , David Airlie , dri-devel , linux-mips , Jernej Skrabec , linux-kernel , Paul Cercueil , Kieran Bingham , Robert Foss , Andrzej Hajda , Discussions about the Letux Kernel , Laurent Pinchart Content-Transfer-Encoding: quoted-printable Message-Id: <75CBD357-577A-402D-9E3B-DBE82A84BC43@goldelico.com> References: <169afe64b4985c3f420177cd6f4e1e72feeb2449.1645895582.git.hns@goldelico.com> <5da069b6-8a99-79c2-109c-c85715165857@baylibre.com> To: Neil Armstrong X-Mailer: Apple Mail (2.3445.104.21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, > Am 02.03.2022 um 11:25 schrieb Neil Armstrong = : >=20 >> I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO = is to be expected >> since I am using a HDMI connector and panel... So your patch will = still add the UYVY formats. >> Either the synposys module inside the jz4780 or the panel does not = understand them. >=20 > By selecting the UYVY formats, the driver will enable the colorspace = converters in the dw-hdmi IP, > I don't see why it doesn't work here... >=20 > There is a bit called `Support Color Space Converter` in config0_id: > bit | Name | R/W | Desc > 2 | csc | R | Indicates if Color Space = Conversion block is present >=20 > Could you dump all the config0 bits: >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D><=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c = b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 54d8fdad395f..547731482da8 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -3431,6 +3431,7 @@ struct dw_hdmi *dw_hdmi_probe(struct = platform_device *pdev, > pdevinfo.id =3D PLATFORM_DEVID_AUTO; >=20 > config0 =3D hdmi_readb(hdmi, HDMI_CONFIG0_ID); > + dev_info(dev, "config0: %x\n", config0); > config3 =3D hdmi_readb(hdmi, HDMI_CONFIG3_ID); >=20 > if (iores && config3 & HDMI_CONFIG3_AHBAUDDMA) { > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D><=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >=20 > If this bit is missing, this would explain the black screen. [ 9.291011] dw-hdmi-ingenic 10180000.hdmi: config0: bf Hm. Or is the color-space conversion of the sw-hdmi module inside the = jz4780 broken or not configured properly? (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi =3D = false) BR and thanks, Nikolaus