From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F10C433EF for ; Thu, 14 Apr 2022 15:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350229AbiDNQBG (ORCPT ); Thu, 14 Apr 2022 12:01:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359760AbiDNPrR (ORCPT ); Thu, 14 Apr 2022 11:47:17 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A745F61D1; Thu, 14 Apr 2022 08:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=6sMmhzgZCrm6waVxP9z2dHOgrG0ZsUX1GrMhTQVx3XE=; b=htOTffnGnm8zSygfrWwW7s68j+ o/8A7s8CcStsUleAWtAwwdPLZY/dteSvmaaQX4ry8g/5oxsjKrcHjIjKJaObrZkKO0TnnAYy4SMSG 0LMpl7n9rrVyNcd1hjDQY2gH2tqd11Ucwh8e0jXl5zD1vfUdG0FPyAhadJkYta7tb0LVrXN7/Z8hl HN5VyZ6/Xcwd/ftPW5Lm24MGgTcRIJ/z6niVxOXyErPQukcxB30fXaEIJFO3lLp8O8h4MZ3xMU1d4 W/P4+Fvka0a6Ih4HY/loN5mIzgyG6FyybT9Zdr/ANuW302BJ8MYsG/Q7LZsUmhNXKahgbUfaZc/8N i//ObZjA==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nf1ST-00536t-Fi; Thu, 14 Apr 2022 15:32:33 +0000 Message-ID: <75a7b583-187d-569d-5ed0-2bb0e1b1ec7b@infradead.org> Date: Thu, 14 Apr 2022 08:32:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 5.4 004/475] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build Content-Language: en-US To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, kernel test robot , Arnd Bergmann , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , linux-hyperv@vger.kernel.org, Michael Kelley , =?UTF-8?Q?Petr_=c5=a0tetiar?= References: <20220414110855.141582785@linuxfoundation.org> <20220414110855.274446341@linuxfoundation.org> From: Randy Dunlap In-Reply-To: <20220414110855.274446341@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/22 06:06, Greg Kroah-Hartman wrote: > From: Randy Dunlap > > commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 upstream. > > The hyperv utilities use PTP clock interfaces and should depend a > a kconfig symbol such that they will be built as a loadable module or > builtin so that linker errors do not happen. > > Prevents these build errors: > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' > ld: drivers/hv/hv_util.o: in function `hv_timesync_init': > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' > > Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Arnd Bergmann > Cc: "K. Y. Srinivasan" > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Cc: Wei Liu > Cc: Dexuan Cui > Cc: linux-hyperv@vger.kernel.org > Cc: Greg Kroah-Hartman > Reviewed-by: Michael Kelley > Link: https://lore.kernel.org/r/20211126023316.25184-1-rdunlap@infradead.org > Signed-off-by: Wei Liu > Cc: Petr Štetiar > Signed-off-by: Greg Kroah-Hartman > --- > drivers/hv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/hv/Kconfig > +++ b/drivers/hv/Kconfig > @@ -17,6 +17,7 @@ config HYPERV_TIMER > config HYPERV_UTILS > tristate "Microsoft Hyper-V Utilities driver" > depends on HYPERV && CONNECTOR && NLS > + depends on PTP_1588_CLOCK_OPTIONAL AFAICT PTP_1588_CLOCK_OPTIONAL does not exist in 5.4 kernels, so this should not be used there. > help > Select this option to enable the Hyper-V Utilities. > > > -- ~Randy