From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB1AC4338F for ; Tue, 24 Aug 2021 05:03:36 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79EC761248 for ; Tue, 24 Aug 2021 05:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 79EC761248 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B4F7C82C03; Tue, 24 Aug 2021 07:03:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 9AA5B82D95; Tue, 24 Aug 2021 07:03:30 +0200 (CEST) Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 51D0081BC0 for ; Tue, 24 Aug 2021 07:03:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=christophe.leroy@csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Gtxp548XMz9sVk; Tue, 24 Aug 2021 07:03:25 +0200 (CEST) Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fg3tjCU-c49f; Tue, 24 Aug 2021 07:03:25 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Gtxp537bmz9sVd; Tue, 24 Aug 2021 07:03:25 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 46B3F8B7BA; Tue, 24 Aug 2021 07:03:25 +0200 (CEST) Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id k58jLbAAZYgO; Tue, 24 Aug 2021 07:03:25 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 930B08B764; Tue, 24 Aug 2021 07:03:24 +0200 (CEST) Subject: Re: [PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Christophe Leroy Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Bin Meng , =?UTF-8?Q?Marek_Beh=c3=ban?= , Tom Rini , u-boot@lists.denx.de References: <20210802131838.21097-8-pali@kernel.org> <20210808112038.7942-1-pali@kernel.org> <20210808113651.tatdo2zm24clrmxk@pali> From: Christophe Leroy Message-ID: <75ae39aa-3762-6b90-c39a-7595fc417870@csgroup.eu> Date: Tue, 24 Aug 2021 07:03:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210808113651.tatdo2zm24clrmxk@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Le 08/08/2021 à 13:36, Pali Rohár a écrit : > Christophe, could you please review this change? According to your commit > https://source.denx.de/u-boot/u-boot/-/commit/907208c452999427cb2f43450308045bf8b42958 > mpc8xx code will have to be maintained until at least 2027. > > On Sunday 08 August 2021 13:20:38 Pali Rohár wrote: >> It is unknown why version string is placed at specific position on these >> powerpc mpc platforms. > > Also, could you look at this, why version string is at specific location > of u-boot.bin header? I have no idea. AFAIKS it's been like that since the first version in git in 2002. Maybe Wolfgang has the answer ? Christophe