From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F32C433F5 for ; Thu, 13 Jan 2022 13:32:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235272AbiAMNcT (ORCPT ); Thu, 13 Jan 2022 08:32:19 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:56392 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233516AbiAMNcR (ORCPT ); Thu, 13 Jan 2022 08:32:17 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DD239402A6 for ; Thu, 13 Jan 2022 13:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642080735; bh=t1fGsqpmZOTRML60TK0WG2DkdgMd68nNzRyjYpnjGrc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jYsOTEgE3KfenEN846ufUBSnZscWv6h6ToOyACG77/eCrIvIYHxKiibwzUx+KNzWf 6oW+RVXUTnA95igJtm/KeuwSGMxCGkZufyX/7DCEdncZ+UTt/dKYazp6BmEN4ixj4v WD3RkFmrxJoHsaHKBg2A6embbrEp34Sxbn1OxRM/lrxku+lGGrEcXuRedLm4n8ugrP lP9Wgu1On4pA0qiEMRQnLH2+iidLP94WYRLHuGSXrf6YEIOi1vGXrwCvUP1RM2GgI2 TosSz2bfKHKNxxa13/w0XCTB8/+00ybc2QS8VzOW90U1k+Brj+A8Tcr4STfzKxlnlb 8vI5PO8Go/q9Q== Received: by mail-wm1-f69.google.com with SMTP id z13-20020a05600c0a0d00b003457d6619f8so3620095wmp.1 for ; Thu, 13 Jan 2022 05:32:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=t1fGsqpmZOTRML60TK0WG2DkdgMd68nNzRyjYpnjGrc=; b=0H0cpRncReenhbJopWZr8XoYaPZWvDpEeswAEhjmNk46YEcCJ3z5OSO7C3LYELNeFP CERF52b3e3sk3kqPX/1tnGMFRXs0doYIArOEIAnCP8hlhIg6AxG/fsF2uSVIk8RtEGsG ORY1/p2/833QP4HGkq9CznDgSLyvoKn+Vj/Su/oJFtATva4aEQvlNCQpH85PSBtrHwmW ndXcNo3uHFxaPlLPY4qdbJFi1rkFBD4TBB+6W7t8jKJVbZZsJwnAzQ/qb9pEz8G9cqOn eyHjB8AlTCsYh+m3NAn4U0KNR/o3OyJ8Ll62t08sVh08+3aWd18pn9pCmP5s0z0D3a6M rm7A== X-Gm-Message-State: AOAM532qA9X7XxiOLfm4I62tEGGyYMzlcfyO4ionJrepfy7mSABWtnNo 15Aj2q4EI3/mlUINypfFYhRHGhZFI+eqy5J+XOgkWGe98/bHa752bA2zRtzwyT95W2mDw5du44j li6VgI/aQCiuEMrYZARBLfIsy9h0jsgzsbT9kCkiUcQ== X-Received: by 2002:a05:6000:18af:: with SMTP id b15mr4109162wri.616.1642080733698; Thu, 13 Jan 2022 05:32:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGbdSMulTQPsY60UuoLAuZAuY6P+aX+jB+ZR3YiMMLRRXKaWDybBcgGidUepwKg+fmquMeJg== X-Received: by 2002:a05:6000:18af:: with SMTP id b15mr4109138wri.616.1642080733499; Thu, 13 Jan 2022 05:32:13 -0800 (PST) Received: from [192.168.0.30] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id h10sm3615799wmh.0.2022.01.13.05.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 05:32:13 -0800 (PST) Message-ID: <75ae8b8c-e416-5007-b995-f1317ef207d4@canonical.com> Date: Thu, 13 Jan 2022 14:32:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 20/23] dt-bindings: iio: adc: exynos-adc: Add ADC-V3 variant Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com, Tamseel Shams References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-21-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220113121143.22280-21-alim.akhtar@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/01/2022 13:11, Alim Akhtar wrote: > This patch adds a new compatible string for exynos's ADC-V3 variant. > > Cc: linux-fsd@tesla.com > Signed-off-by: Tamseel Shams > Signed-off-by: Alim Akhtar > --- > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 81c87295912c..9303053759ca 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - samsung,exynos-adc-v1 # Exynos5250 > - samsung,exynos-adc-v2 > + - samsung,exynos-adc-v3 Please use SoC-specific compatible. IP block versions are tricky because: 1. Documentation/datasheet mentioning which SoC has which block version are not public. 2. Neither are public the datasheets for ADC blocks. 3. The versioning of IP blocks can be inaccurate. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A9E7C433FE for ; Thu, 13 Jan 2022 13:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+y4q7uiEsYI+a+veqL0knfF6Na1Oha1tNyy0XJ9wXEA=; b=BNxNsZVT6z4vFh K5Moy4VVluolmPmX1/jC8tXedqUoCFV0RZLEURimco2rwcSHKqz34PYLQXGl1fw14PL/AZMy+fbmf XX3CyHS+HMtNiez3ATjMBVeFuXLTthoD3FNnR406tNYhlmHuJCwhmRH8gsLTrwpekjJ8UK4EYLL6J LTqozLte4j5rJ8mzsMrjNmew/SV5oDpIC7EazBEJcmtc7653xkkvRhW2f2T0O43c8aNXvbm1swSBZ 0CDQ+il0KMJjbfOWxFgZPZCLGwNdNtcjNOUqsrdUTDBV/iOS3l1io5UCckF291LHW47u+9zPylqKO 51CNeD7OSF6L/crz0LYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n80DE-0067a1-SE; Thu, 13 Jan 2022 13:32:21 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n80DB-0067YD-1V for linux-arm-kernel@lists.infradead.org; Thu, 13 Jan 2022 13:32:18 +0000 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id B302D3F1C7 for ; Thu, 13 Jan 2022 13:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642080734; bh=t1fGsqpmZOTRML60TK0WG2DkdgMd68nNzRyjYpnjGrc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JdTe0HjpBKeiHtoKTTGYN/6gc3GVMayZIU7r4Bf/hdPlrbZRT+7Fvit6nFvNxKDLT Ujh8ellczpq54clq9mYlMo7WouyRlr7F6M2wG6LTybiH/pCa6LdR5sYQdQXghTXHHx YDd+HYCZbV4eyRlDOG6+Seh2Q1kl8XT0P8D/IOCrd59yKDoiKEqyPlkY6mpSfNN4el LKDlDsNYwcIA6VjYiWceye+VkmzksDVK638FXx0cAIkNAvZsdmj7ckcAVHj+PvDvE/ AXbjk6Qa6Sc+TRCzjXH9YexZaAbIebmWnWyEirPveCfzylmtFENzwD3Ows82AaIDeM f6hxsYs2e/h1w== Received: by mail-wm1-f70.google.com with SMTP id n14-20020a7bcbce000000b003488820f0d9so3611035wmi.8 for ; Thu, 13 Jan 2022 05:32:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=t1fGsqpmZOTRML60TK0WG2DkdgMd68nNzRyjYpnjGrc=; b=u4dOv2tqyYDBjc2dG9/8GBSQUQoXNoUAbOjxOW4mvD10R4k/UZoKOmvpOW50uCJBI/ QCVIqtElH6PwbMp3bDezR9+BHPUqgaK5vR9rVbQEFsGlkMvN05KM+lvIh5aA0pqgC4v4 tduzpHGGPdhJIdXJ1ktoOeaV6qStvRPPxSB2lLao7jB4E/VSbsUUbQ72UbRiGJ4YNCIi g42j0vdxW45nEIdYyfZq+8emx7KCyrjkNULfmWpR0kEkP3X8gl8Muh8FZ7XOnXQb8q/2 T2fI4namCejoy1lzfW/z07a7/nbsQ5tcijrcy3hXUPDs0ZNOSDsvbz/2aP8K3G+I+hdu SKXA== X-Gm-Message-State: AOAM533IM0589m08d8gPTjM+HnP+Gzd/U5VD+Gu+3DGuVYZ0Arf9RlGj OX/gpzn7I+Z1X8JwThzp9ud5SWnBi9pd9Ks5aydcySueuxLf6GuYDOvgJfVJvtv8TZC3c/CpBQG dZVRIXXBjkNzFykiPfSpSMUrq/dp0nRIlzrKJCZwtL+uqlFNYZG+1 X-Received: by 2002:a05:6000:18af:: with SMTP id b15mr4109156wri.616.1642080733637; Thu, 13 Jan 2022 05:32:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGbdSMulTQPsY60UuoLAuZAuY6P+aX+jB+ZR3YiMMLRRXKaWDybBcgGidUepwKg+fmquMeJg== X-Received: by 2002:a05:6000:18af:: with SMTP id b15mr4109138wri.616.1642080733499; Thu, 13 Jan 2022 05:32:13 -0800 (PST) Received: from [192.168.0.30] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id h10sm3615799wmh.0.2022.01.13.05.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 05:32:13 -0800 (PST) Message-ID: <75ae8b8c-e416-5007-b995-f1317ef207d4@canonical.com> Date: Thu, 13 Jan 2022 14:32:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 20/23] dt-bindings: iio: adc: exynos-adc: Add ADC-V3 variant Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com, Tamseel Shams References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-21-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220113121143.22280-21-alim.akhtar@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_053217_270055_FCF7183B X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/01/2022 13:11, Alim Akhtar wrote: > This patch adds a new compatible string for exynos's ADC-V3 variant. > > Cc: linux-fsd@tesla.com > Signed-off-by: Tamseel Shams > Signed-off-by: Alim Akhtar > --- > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 81c87295912c..9303053759ca 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - samsung,exynos-adc-v1 # Exynos5250 > - samsung,exynos-adc-v2 > + - samsung,exynos-adc-v3 Please use SoC-specific compatible. IP block versions are tricky because: 1. Documentation/datasheet mentioning which SoC has which block version are not public. 2. Neither are public the datasheets for ADC blocks. 3. The versioning of IP blocks can be inaccurate. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel