All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Sakoman" <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][dunfell v2 02/14] kernel-yocto.bbclass: Fix deps when externalsrc is used
Date: Thu, 30 Apr 2020 12:30:07 -1000	[thread overview]
Message-ID: <75b47388fb18aaf58db311e570c009350d64084f.1588285073.git.steve@sakoman.com> (raw)
In-Reply-To: <cover.1588285073.git.steve@sakoman.com>

From: Paul Barker <pbarker@konsulko.com>

do_kernel_configme was recently removed from SRCTREECOVEREDTASKS so this
task still runs when externalsrc is used. This task normally runs after
do_patch but when externalsrc is used, do_patch is removed and this ordering
restriction does nothing. This allows bitbake to execute do_kernel_configme
too early, causing races with do_unpack.

This is fixed by adding in a dependency on do_unpack when externalsrc is
used.

Signed-off-by: Paul Barker <pbarker@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/classes/kernel-yocto.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 6792c9a233..5bc627066e 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -489,6 +489,12 @@ python () {
     # If diffconfig is available, ensure it runs after kernel_configme
     if 'do_diffconfig' in d:
         bb.build.addtask('do_diffconfig', None, 'do_kernel_configme', d)
+
+    externalsrc = d.getVar('EXTERNALSRC')
+    if externalsrc:
+        # If we deltask do_patch, do_kernel_configme is left without
+        # dependencies and runs too early
+        d.setVarFlag('do_kernel_configme', 'deps', (d.getVarFlag('do_kernel_configme', 'deps', False) or []) + ['do_unpack'])
 }
 
 # extra tasks
-- 
2.17.1


  parent reply	other threads:[~2020-04-30 22:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 22:30 [OE-core][dunfell v2 00/14] Patch review Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 01/14] u-boot.inc: install u-boot-initial-env as ${PN}-initial-env in $D and $DEPLOYDIR Steve Sakoman
2020-04-30 22:30 ` Steve Sakoman [this message]
2020-04-30 22:30 ` [OE-core][dunfell v2 03/14] qemu-system-native: Fix commented out PACKAGECONFIG Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 04/14] nativesdk-gcc-runtime: enable building libstdc++.a Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 05/14] buildtools-extended-tarball: Add libstc++.a Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 06/14] libucontext: Bring in mips/mips64 support Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 07/14] ruby: Link with libucontext on musl Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 08/14] tzdata: remove exit 0 from pkg_postinst Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 09/14] gnutls: upgrade 3.6.12 -> 3.6.13 Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 10/14] ell: upgrade 0.30 -> 0.31 Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 11/14] python3-manifest.json: add pathlib to core Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 12/14] alsa-state: ignore 'No soundcards found' error in pkg_postinst Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 13/14] buildtools-tarball: add nativesdk-mtools for `wic ls' Steve Sakoman
2020-04-30 22:30 ` [OE-core][dunfell v2 14/14] parselogs.py: ignore pulseaudio startup warning messages Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75b47388fb18aaf58db311e570c009350d64084f.1588285073.git.steve@sakoman.com \
    --to=steve@sakoman.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.