From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40FDC433FE for ; Fri, 29 Apr 2022 14:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377150AbiD2OT5 (ORCPT ); Fri, 29 Apr 2022 10:19:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359769AbiD2OT4 (ORCPT ); Fri, 29 Apr 2022 10:19:56 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 960B18FFBB for ; Fri, 29 Apr 2022 07:16:36 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id j6so15686662ejc.13 for ; Fri, 29 Apr 2022 07:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UdINARUtzcFoW7h6RyjDI8lgOBSw6WOSOqD14X2CFJU=; b=R3GZ3IwUpu5UUm3UrgEWZ4yVRf5jvXz7GwFUllasFjFFL0aBEmLKNpewMp+KpvazTf g8p8hr+kOKGqyfgS7Y6uQhzrVoBaclahGzEyJPahetcB4lmaLSZiOEXz2JI6zFxDHQpC maW0lcQI5+oePb8/E6eX0hAdKzV8yvr+mZ4vk1i/OguhilfBrgpfSdkLeZzOH/QGszCI RH2NayuUkJaUmwHXmH4I6VtjsZF4R1jZUbZ8lGtIMUIXu5uVYHzuEr+3e8Zq7RWXMNWD XG+381AkVI2TTgKMvdTb9CLibCPzJlooCB/siw0KduRzu5GuQpMZWdmfj293jx06HRzp Ng6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UdINARUtzcFoW7h6RyjDI8lgOBSw6WOSOqD14X2CFJU=; b=DwjuqiRpxCK8fK565jRi68Kn8Kc00TWwbRU+lqVJxURTbphtgIar3eQMylMF7zdF1D ciWkij/CbI0o2KqvzGrKeWJg25h7K0A1NXBQKfNNXxQRbYd4QP92qbrdpUWG4YrKtAi1 r4B7EeFZ/Yuxynliurlx9L6iwYnH+XhJmhYQg7WwA7M1/U9HI8JkjNJ5U0y/SMYYc41X PTf/IdKVLdmzO8eCenuKOXMFMkVJnhA6jNdqzd0l+r6TAAUAMUAKMi7SLCA22iktO3xU 6pkL5s0OxJCyVC0nglPL4shdEPeI4s0hsjm4p3iMn3q5o/U63c85N1n5lYfmxpuLwTyY riKw== X-Gm-Message-State: AOAM533HC5yYg1dijVYeJO/lPKU81BQ5/MmFWBihPpEbyirNVAN2sRdb ayUCOMZdhL6QN/JNBAzIbte3tQ== X-Google-Smtp-Source: ABdhPJykYBCwe9aQMDhIZ8XGDNf9p2LGcca3xyCDUbkpjt15wUq7VCOYejWxIXJEzJpfvaAJeCOHOw== X-Received: by 2002:a17:907:6d12:b0:6f3:d304:e259 with SMTP id sa18-20020a1709076d1200b006f3d304e259mr10624053ejc.110.1651241795135; Fri, 29 Apr 2022 07:16:35 -0700 (PDT) Received: from [192.168.0.170] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id j12-20020a50ed0c000000b0042617ba63d4sm2982642eds.94.2022.04.29.07.16.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 07:16:34 -0700 (PDT) Message-ID: <75b94ccd-b739-2164-bc4a-20025356cc34@linaro.org> Date: Fri, 29 Apr 2022 16:16:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v7 12/12] rpmsg: Fix kfree() of static memory on setting driver_override Content-Language: en-US To: Marek Szyprowski , Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Stuart Yoder , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes , Andy Shevchenko References: <20220419113435.246203-1-krzysztof.kozlowski@linaro.org> <20220419113435.246203-13-krzysztof.kozlowski@linaro.org> <870885de-33f3-e0ba-4d56-71c3c993ac87@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <870885de-33f3-e0ba-4d56-71c3c993ac87@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 29/04/2022 14:29, Marek Szyprowski wrote: > Hi Krzysztof, > > On 19.04.2022 13:34, Krzysztof Kozlowski wrote: >> The driver_override field from platform driver should not be initialized >> from static memory (string literal) because the core later kfree() it, >> for example when driver_override is set via sysfs. >> >> Use dedicated helper to set driver_override properly. >> >> Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") >> Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") >> Signed-off-by: Krzysztof Kozlowski >> Reviewed-by: Bjorn Andersson > > This patch landed recently in linux-next as commit 42cd402b8fd4 ("rpmsg: > Fix kfree() of static memory on setting driver_override"). In my tests I > found that it triggers the following issue during boot of the > DragonBoard410c SBC (arch/arm64/boot/dts/qcom/apq8016-sbc.dtb): > > ------------[ cut here ]------------ > DEBUG_LOCKS_WARN_ON(lock->magic != lock) > WARNING: CPU: 1 PID: 8 at kernel/locking/mutex.c:582 > __mutex_lock+0x1ec/0x430 > Modules linked in: > CPU: 1 PID: 8 Comm: kworker/u8:0 Not tainted 5.18.0-rc4-next-20220429 #11815 > Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) > Workqueue: events_unbound deferred_probe_work_func > pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : __mutex_lock+0x1ec/0x430 > lr : __mutex_lock+0x1ec/0x430 > .. > Call trace: >  __mutex_lock+0x1ec/0x430 >  mutex_lock_nested+0x38/0x64 >  driver_set_override+0x124/0x150 >  qcom_smd_register_edge+0x2a8/0x4ec >  qcom_smd_probe+0x54/0x80 >  platform_probe+0x68/0xe0 >  really_probe.part.0+0x9c/0x29c >  __driver_probe_device+0x98/0x144 >  driver_probe_device+0xac/0x14c >  __device_attach_driver+0xb8/0x120 >  bus_for_each_drv+0x78/0xd0 >  __device_attach+0xd8/0x180 >  device_initial_probe+0x14/0x20 >  bus_probe_device+0x9c/0xa4 >  deferred_probe_work_func+0x88/0xc4 >  process_one_work+0x288/0x6bc >  worker_thread+0x248/0x450 >  kthread+0x118/0x11c >  ret_from_fork+0x10/0x20 > irq event stamp: 3599 > hardirqs last  enabled at (3599): [] > _raw_spin_unlock_irqrestore+0x98/0x9c > hardirqs last disabled at (3598): [] > _raw_spin_lock_irqsave+0xc0/0xcc > softirqs last  enabled at (3554): [] _stext+0x470/0x5e8 > softirqs last disabled at (3549): [] > __irq_exit_rcu+0x180/0x1ac > ---[ end trace 0000000000000000 ]--- > > I don't see any direct relation between the $subject and the above log, > but reverting the $subject on top of linux next-20220429 hides/fixes it. > Maybe there is a kind of memory trashing somewhere there and your change > only revealed it? Thanks for the report. I think the error path of my patch is wrong - I should not kfree(rpdev->driver_override) from the rpmsg code. That's the only thing I see now... Could you test following patch and tell if it helps? https://pastebin.ubuntu.com/p/rp3q9Z5fXj/ ----- diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h index 3e81642238d2..1e2ad944e2ec 100644 --- a/drivers/rpmsg/rpmsg_internal.h +++ b/drivers/rpmsg/rpmsg_internal.h @@ -102,11 +102,7 @@ static inline int rpmsg_ctrldev_register_device(struct rpmsg_device *rpdev) if (ret) return ret; - ret = rpmsg_register_device(rpdev); - if (ret) - kfree(rpdev->driver_override); - - return ret; + return rpmsg_register_device(rpdev); } #endif diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg/rpmsg_ns.c index 8eb8f328237e..f26078467899 100644 --- a/drivers/rpmsg/rpmsg_ns.c +++ b/drivers/rpmsg/rpmsg_ns.c @@ -31,11 +31,7 @@ int rpmsg_ns_register_device(struct rpmsg_device *rpdev) rpdev->src = RPMSG_NS_ADDR; rpdev->dst = RPMSG_NS_ADDR; - ret = rpmsg_register_device(rpdev); - if (ret) - kfree(rpdev->driver_override); - - return ret; + return rpmsg_register_device(rpdev); } EXPORT_SYMBOL(rpmsg_ns_register_device); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99547C433EF for ; Fri, 29 Apr 2022 14:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LQiJ2wu/ibFuyDNz44cuIeNMrLsNq0nPMvSi+kpIhpw=; b=vpJ3/8i6TMtpqI yjRMp6FgCMuBreQb9VKA5eHM5Q+HoLryDrm+03m68DsEdwkKArYllZ3JkkQq9bJTw3IqzADYVdqWQ L3/glxDjwZspaZ0tHhs0/8f+3QXMEM3rYOCw1HYEuBvVOxIJ2F8dRHxjlTk0ML0a3oig5OZ5Vjs4R QhpN9WTM6DVM5CXSIIvD37v+2XMsLp0g4gqi+tHJY67eVL/+0Dn0d2mCLPhzNC19yg0iRNNvwIaZK NZBoXMLYeKilUCCHyjxzZhysF9gCxMK0eHv9xHvh0OR0X0iivuTyGi1W347T89WYnhuG2xWc3irTZ vYef9InGz0JvWJCqE7PQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkRQJ-00BWZ0-6D; Fri, 29 Apr 2022 14:16:43 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkRQE-00BWWR-RA for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 14:16:41 +0000 Received: by mail-ej1-x631.google.com with SMTP id gh6so15816262ejb.0 for ; Fri, 29 Apr 2022 07:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UdINARUtzcFoW7h6RyjDI8lgOBSw6WOSOqD14X2CFJU=; b=R3GZ3IwUpu5UUm3UrgEWZ4yVRf5jvXz7GwFUllasFjFFL0aBEmLKNpewMp+KpvazTf g8p8hr+kOKGqyfgS7Y6uQhzrVoBaclahGzEyJPahetcB4lmaLSZiOEXz2JI6zFxDHQpC maW0lcQI5+oePb8/E6eX0hAdKzV8yvr+mZ4vk1i/OguhilfBrgpfSdkLeZzOH/QGszCI RH2NayuUkJaUmwHXmH4I6VtjsZF4R1jZUbZ8lGtIMUIXu5uVYHzuEr+3e8Zq7RWXMNWD XG+381AkVI2TTgKMvdTb9CLibCPzJlooCB/siw0KduRzu5GuQpMZWdmfj293jx06HRzp Ng6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UdINARUtzcFoW7h6RyjDI8lgOBSw6WOSOqD14X2CFJU=; b=NvWOF+J9nMnaqA8UaaplKQbIbu3XTpHVnUmiTEdlnONkfh7Ta7kGh6QXLU/m6jQLW/ CA7ZVfrnb0KMO7SZ5lPD/hS1/0gkkp3x9IujcaORu37FGmpnwxRVmNtYJmZujcmUbOqp 6xrdkRUn5MH/e2KClYs+u7QJA3Aqzq+dDV30IlTsS6VUiYeag+4Yw3qfvwYEkgN7gYNe 5eeg9RKd1ME4luiehKOEduGZIWNIyyEaODfN8q2GieJu66llmh2xs72Acg5GYvxWyFmA 6LgC09Y91NFP+rNJ9MSnHUCaA/+J54fPO1zp5UbOJ4uJJw5zew3oAnojEuZFuA6emnyc F13A== X-Gm-Message-State: AOAM533CI7+E6X/2HEiEeA8LAZ+HNLtxb8WZMBHfgTL3Tq7nStrHLawM +WaE7MopAHMzuaj0OZRRn1PodQ== X-Google-Smtp-Source: ABdhPJykYBCwe9aQMDhIZ8XGDNf9p2LGcca3xyCDUbkpjt15wUq7VCOYejWxIXJEzJpfvaAJeCOHOw== X-Received: by 2002:a17:907:6d12:b0:6f3:d304:e259 with SMTP id sa18-20020a1709076d1200b006f3d304e259mr10624053ejc.110.1651241795135; Fri, 29 Apr 2022 07:16:35 -0700 (PDT) Received: from [192.168.0.170] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id j12-20020a50ed0c000000b0042617ba63d4sm2982642eds.94.2022.04.29.07.16.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 07:16:34 -0700 (PDT) Message-ID: <75b94ccd-b739-2164-bc4a-20025356cc34@linaro.org> Date: Fri, 29 Apr 2022 16:16:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v7 12/12] rpmsg: Fix kfree() of static memory on setting driver_override Content-Language: en-US To: Marek Szyprowski , Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Stuart Yoder , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes , Andy Shevchenko References: <20220419113435.246203-1-krzysztof.kozlowski@linaro.org> <20220419113435.246203-13-krzysztof.kozlowski@linaro.org> <870885de-33f3-e0ba-4d56-71c3c993ac87@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <870885de-33f3-e0ba-4d56-71c3c993ac87@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_071639_027751_DF639049 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjkvMDQvMjAyMiAxNDoyOSwgTWFyZWsgU3p5cHJvd3NraSB3cm90ZToKPiBIaSBLcnp5c3p0 b2YsCj4gCj4gT24gMTkuMDQuMjAyMiAxMzozNCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK Pj4gVGhlIGRyaXZlcl9vdmVycmlkZSBmaWVsZCBmcm9tIHBsYXRmb3JtIGRyaXZlciBzaG91bGQg bm90IGJlIGluaXRpYWxpemVkCj4+IGZyb20gc3RhdGljIG1lbW9yeSAoc3RyaW5nIGxpdGVyYWwp IGJlY2F1c2UgdGhlIGNvcmUgbGF0ZXIga2ZyZWUoKSBpdCwKPj4gZm9yIGV4YW1wbGUgd2hlbiBk cml2ZXJfb3ZlcnJpZGUgaXMgc2V0IHZpYSBzeXNmcy4KPj4KPj4gVXNlIGRlZGljYXRlZCBoZWxw ZXIgdG8gc2V0IGRyaXZlcl9vdmVycmlkZSBwcm9wZXJseS4KPj4KPj4gRml4ZXM6IDk1MGE3Mzg4 ZjAyYiAoInJwbXNnOiBUdXJuIG5hbWUgc2VydmljZSBpbnRvIGEgc3RhbmQgYWxvbmUgZHJpdmVy IikKPj4gRml4ZXM6IGMwY2RjMTlmODRhNCAoInJwbXNnOiBEcml2ZXIgZm9yIHVzZXIgc3BhY2Ug ZW5kcG9pbnQgaW50ZXJmYWNlIikKPj4gU2lnbmVkLW9mZi1ieTogS3J6eXN6dG9mIEtvemxvd3Nr aSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPgo+PiBSZXZpZXdlZC1ieTogQmpvcm4g QW5kZXJzc29uIDxiam9ybi5hbmRlcnNzb25AbGluYXJvLm9yZz4KPiAKPiBUaGlzIHBhdGNoIGxh bmRlZCByZWNlbnRseSBpbiBsaW51eC1uZXh0IGFzIGNvbW1pdCA0MmNkNDAyYjhmZDQgKCJycG1z ZzogCj4gRml4IGtmcmVlKCkgb2Ygc3RhdGljIG1lbW9yeSBvbiBzZXR0aW5nIGRyaXZlcl9vdmVy cmlkZSIpLiBJbiBteSB0ZXN0cyBJIAo+IGZvdW5kIHRoYXQgaXQgdHJpZ2dlcnMgdGhlIGZvbGxv d2luZyBpc3N1ZSBkdXJpbmcgYm9vdCBvZiB0aGUgCj4gRHJhZ29uQm9hcmQ0MTBjIFNCQyAoYXJj aC9hcm02NC9ib290L2R0cy9xY29tL2FwcTgwMTYtc2JjLmR0Yik6Cj4gCj4gLS0tLS0tLS0tLS0t WyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tCj4gREVCVUdfTE9DS1NfV0FSTl9PTihsb2NrLT5tYWdp YyAhPSBsb2NrKQo+IFdBUk5JTkc6IENQVTogMSBQSUQ6IDggYXQga2VybmVsL2xvY2tpbmcvbXV0 ZXguYzo1ODIgCj4gX19tdXRleF9sb2NrKzB4MWVjLzB4NDMwCj4gTW9kdWxlcyBsaW5rZWQgaW46 Cj4gQ1BVOiAxIFBJRDogOCBDb21tOiBrd29ya2VyL3U4OjAgTm90IHRhaW50ZWQgNS4xOC4wLXJj NC1uZXh0LTIwMjIwNDI5ICMxMTgxNQo+IEhhcmR3YXJlIG5hbWU6IFF1YWxjb21tIFRlY2hub2xv Z2llcywgSW5jLiBBUFEgODAxNiBTQkMgKERUKQo+IFdvcmtxdWV1ZTogZXZlbnRzX3VuYm91bmQg ZGVmZXJyZWRfcHJvYmVfd29ya19mdW5jCj4gcHN0YXRlOiA2MDAwMDAwNSAoblpDdiBkYWlmIC1Q QU4gLVVBTyAtVENPIC1ESVQgLVNTQlMgQlRZUEU9LS0pCj4gcGMgOiBfX211dGV4X2xvY2srMHgx ZWMvMHg0MzAKPiBsciA6IF9fbXV0ZXhfbG9jaysweDFlYy8weDQzMAo+IC4uCj4gQ2FsbCB0cmFj ZToKPiAgwqBfX211dGV4X2xvY2srMHgxZWMvMHg0MzAKPiAgwqBtdXRleF9sb2NrX25lc3RlZCsw eDM4LzB4NjQKPiAgwqBkcml2ZXJfc2V0X292ZXJyaWRlKzB4MTI0LzB4MTUwCj4gIMKgcWNvbV9z bWRfcmVnaXN0ZXJfZWRnZSsweDJhOC8weDRlYwo+ICDCoHFjb21fc21kX3Byb2JlKzB4NTQvMHg4 MAo+ICDCoHBsYXRmb3JtX3Byb2JlKzB4NjgvMHhlMAo+ICDCoHJlYWxseV9wcm9iZS5wYXJ0LjAr MHg5Yy8weDI5Ywo+ICDCoF9fZHJpdmVyX3Byb2JlX2RldmljZSsweDk4LzB4MTQ0Cj4gIMKgZHJp dmVyX3Byb2JlX2RldmljZSsweGFjLzB4MTRjCj4gIMKgX19kZXZpY2VfYXR0YWNoX2RyaXZlcisw eGI4LzB4MTIwCj4gIMKgYnVzX2Zvcl9lYWNoX2RydisweDc4LzB4ZDAKPiAgwqBfX2RldmljZV9h dHRhY2grMHhkOC8weDE4MAo+ICDCoGRldmljZV9pbml0aWFsX3Byb2JlKzB4MTQvMHgyMAo+ICDC oGJ1c19wcm9iZV9kZXZpY2UrMHg5Yy8weGE0Cj4gIMKgZGVmZXJyZWRfcHJvYmVfd29ya19mdW5j KzB4ODgvMHhjNAo+ICDCoHByb2Nlc3Nfb25lX3dvcmsrMHgyODgvMHg2YmMKPiAgwqB3b3JrZXJf dGhyZWFkKzB4MjQ4LzB4NDUwCj4gIMKga3RocmVhZCsweDExOC8weDExYwo+ICDCoHJldF9mcm9t X2ZvcmsrMHgxMC8weDIwCj4gaXJxIGV2ZW50IHN0YW1wOiAzNTk5Cj4gaGFyZGlycXMgbGFzdMKg IGVuYWJsZWQgYXQgKDM1OTkpOiBbPGZmZmY4MDAwMDkxOTA1M2M+XSAKPiBfcmF3X3NwaW5fdW5s b2NrX2lycXJlc3RvcmUrMHg5OC8weDljCj4gaGFyZGlycXMgbGFzdCBkaXNhYmxlZCBhdCAoMzU5 OCk6IFs8ZmZmZjgwMDAwOTE5MGJhND5dIAo+IF9yYXdfc3Bpbl9sb2NrX2lycXNhdmUrMHhjMC8w eGNjCj4gc29mdGlycXMgbGFzdMKgIGVuYWJsZWQgYXQgKDM1NTQpOiBbPGZmZmY4MDAwMDgwMTA0 NzA+XSBfc3RleHQrMHg0NzAvMHg1ZTgKPiBzb2Z0aXJxcyBsYXN0IGRpc2FibGVkIGF0ICgzNTQ5 KTogWzxmZmZmODAwMDA4MGE0NTE0Pl0gCj4gX19pcnFfZXhpdF9yY3UrMHgxODAvMHgxYWMKPiAt LS1bIGVuZCB0cmFjZSAwMDAwMDAwMDAwMDAwMDAwIF0tLS0KPiAKPiBJIGRvbid0IHNlZSBhbnkg ZGlyZWN0IHJlbGF0aW9uIGJldHdlZW4gdGhlICRzdWJqZWN0IGFuZCB0aGUgYWJvdmUgbG9nLCAK PiBidXQgcmV2ZXJ0aW5nIHRoZSAkc3ViamVjdCBvbiB0b3Agb2YgbGludXggbmV4dC0yMDIyMDQy OSBoaWRlcy9maXhlcyBpdC4gCj4gTWF5YmUgdGhlcmUgaXMgYSBraW5kIG9mIG1lbW9yeSB0cmFz aGluZyBzb21ld2hlcmUgdGhlcmUgYW5kIHlvdXIgY2hhbmdlIAo+IG9ubHkgcmV2ZWFsZWQgaXQ/ CgpUaGFua3MgZm9yIHRoZSByZXBvcnQuIEkgdGhpbmsgdGhlIGVycm9yIHBhdGggb2YgbXkgcGF0 Y2ggaXMgd3JvbmcgLSBJCnNob3VsZCBub3Qga2ZyZWUocnBkZXYtPmRyaXZlcl9vdmVycmlkZSkg ZnJvbSB0aGUgcnBtc2cgY29kZS4gVGhhdCdzIHRoZQpvbmx5IHRoaW5nIEkgc2VlIG5vdy4uLgoK Q291bGQgeW91IHRlc3QgZm9sbG93aW5nIHBhdGNoIGFuZCB0ZWxsIGlmIGl0IGhlbHBzPwpodHRw czovL3Bhc3RlYmluLnVidW50dS5jb20vcC9ycDNxOVo1ZlhqLwoKLS0tLS0KCmRpZmYgLS1naXQg YS9kcml2ZXJzL3JwbXNnL3JwbXNnX2ludGVybmFsLmggYi9kcml2ZXJzL3JwbXNnL3JwbXNnX2lu dGVybmFsLmgKaW5kZXggM2U4MTY0MjIzOGQyLi4xZTJhZDk0NGUyZWMgMTAwNjQ0Ci0tLSBhL2Ry aXZlcnMvcnBtc2cvcnBtc2dfaW50ZXJuYWwuaAorKysgYi9kcml2ZXJzL3JwbXNnL3JwbXNnX2lu dGVybmFsLmgKQEAgLTEwMiwxMSArMTAyLDcgQEAgc3RhdGljIGlubGluZSBpbnQKcnBtc2dfY3Ry bGRldl9yZWdpc3Rlcl9kZXZpY2Uoc3RydWN0IHJwbXNnX2RldmljZSAqcnBkZXYpCiAgICAgICAg aWYgKHJldCkKICAgICAgICAgICAgICAgIHJldHVybiByZXQ7CgotICAgICAgIHJldCA9IHJwbXNn X3JlZ2lzdGVyX2RldmljZShycGRldik7Ci0gICAgICAgaWYgKHJldCkKLSAgICAgICAgICAgICAg IGtmcmVlKHJwZGV2LT5kcml2ZXJfb3ZlcnJpZGUpOwotCi0gICAgICAgcmV0dXJuIHJldDsKKyAg ICAgICByZXR1cm4gcnBtc2dfcmVnaXN0ZXJfZGV2aWNlKHJwZGV2KTsKIH0KCiAjZW5kaWYKZGlm ZiAtLWdpdCBhL2RyaXZlcnMvcnBtc2cvcnBtc2dfbnMuYyBiL2RyaXZlcnMvcnBtc2cvcnBtc2df bnMuYwppbmRleCA4ZWI4ZjMyODIzN2UuLmYyNjA3ODQ2Nzg5OSAxMDA2NDQKLS0tIGEvZHJpdmVy cy9ycG1zZy9ycG1zZ19ucy5jCisrKyBiL2RyaXZlcnMvcnBtc2cvcnBtc2dfbnMuYwpAQCAtMzEs MTEgKzMxLDcgQEAgaW50IHJwbXNnX25zX3JlZ2lzdGVyX2RldmljZShzdHJ1Y3QgcnBtc2dfZGV2 aWNlICpycGRldikKICAgICAgICBycGRldi0+c3JjID0gUlBNU0dfTlNfQUREUjsKICAgICAgICBy cGRldi0+ZHN0ID0gUlBNU0dfTlNfQUREUjsKCi0gICAgICAgcmV0ID0gcnBtc2dfcmVnaXN0ZXJf ZGV2aWNlKHJwZGV2KTsKLSAgICAgICBpZiAocmV0KQotICAgICAgICAgICAgICAga2ZyZWUocnBk ZXYtPmRyaXZlcl9vdmVycmlkZSk7Ci0KLSAgICAgICByZXR1cm4gcmV0OworICAgICAgIHJldHVy biBycG1zZ19yZWdpc3Rlcl9kZXZpY2UocnBkZXYpOwogfQogRVhQT1JUX1NZTUJPTChycG1zZ19u c19yZWdpc3Rlcl9kZXZpY2UpOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=