From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:43568 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423376AbeCBPdt (ORCPT ); Fri, 2 Mar 2018 10:33:49 -0500 Received: by mail-pl0-f68.google.com with SMTP id f23-v6so5874165plr.10 for ; Fri, 02 Mar 2018 07:33:49 -0800 (PST) Subject: Re: [PATCH v2 net-next 08/10] mlxsw: spectrum_router: Add support for ipv6 hash policy update To: Ido Schimmel Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, tom@herbertland.com References: <20180302032950.21154-1-dsahern@gmail.com> <20180302032950.21154-9-dsahern@gmail.com> <20180302140224.GH23979@splinter> From: David Ahern Message-ID: <75cd9825-e733-8904-aa4a-5079a3e40a5d@gmail.com> Date: Fri, 2 Mar 2018 08:33:47 -0700 MIME-Version: 1.0 In-Reply-To: <20180302140224.GH23979@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/2/18 7:02 AM, Ido Schimmel wrote: > On Thu, Mar 01, 2018 at 07:29:48PM -0800, David Ahern wrote: >> Similar to 28678f07f127d ("mlxsw: spectrum_router: Update multipath hash >> parameters upon netevents") for IPv4, make sure the kernel and asic are >> using the same hash algorithm for path selection. >> >> Signed-off-by: David Ahern > Reviewed-by: Ido Schimmel > Tested-by: Ido Schimmel > > I know the patch is valid at this point because the driver depends on > IPv6 since the mirror to GRE tap code went it. We're going to remove the > dependency and will take care of the reference to > 'init_net.ipv6.sysctl.multipath_hash_policy'. > Thanks