All of lore.kernel.org
 help / color / mirror / Atom feed
From: Siddharth Gupta <sidgup@codeaurora.org>
To: Greg KH <greg@kroah.com>
Cc: bjorn.andersson@linaro.org, ohad@wizery.com,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v4 4/4] remoteproc: core: Cleanup device in case of failure
Date: Tue, 15 Jun 2021 13:21:11 -0700	[thread overview]
Message-ID: <75ce2563-3d34-a578-200d-8ec5f259d405@codeaurora.org> (raw)
In-Reply-To: <YMj6N46ElCq/ndJJ@kroah.com>


On 6/15/2021 12:06 PM, Greg KH wrote:
> On Tue, Jun 15, 2021 at 12:03:44PM -0700, Siddharth Gupta wrote:
>> When a failure occurs in rproc_add() it returns an error, but does
>> not cleanup after itself. This change adds the failure path in such
>> cases.
>>
>> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
>> Cc: stable@vger.kernel.org
>> ---
>>   drivers/remoteproc/remoteproc_core.c | 15 ++++++++++++---
>>   1 file changed, 12 insertions(+), 3 deletions(-)
> Why is this needed for stable kernels?  And again, a Fixes: tag?
Patch 2 and patch 3 are leading up to fix rproc_add()
in case of a failure. This means we'll have errors with
use after free unless we call device_del() or cdev_del(),
also the sysfs and devtempfs nodes will also not be
removed.

Thanks,
Sid

  reply	other threads:[~2021-06-15 20:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 19:03 [PATCH v4 0/4] remoteproc: core: Fixes for rproc cdev and add Siddharth Gupta
2021-06-15 19:03 ` [PATCH v4 1/4] remoteproc: core: Move cdev add before device add Siddharth Gupta
2021-06-15 19:03 ` [PATCH v4 2/4] remoteproc: core: Move validate " Siddharth Gupta
2021-06-15 19:06   ` Greg KH
2021-06-15 19:06     ` Greg KH
2021-06-15 19:03 ` [PATCH v4 3/4] remoteproc: core: Fix cdev remove and rproc del Siddharth Gupta
2021-06-15 19:06   ` Greg KH
2021-06-15 19:06     ` Greg KH
2021-06-15 19:03 ` [PATCH v4 4/4] remoteproc: core: Cleanup device in case of failure Siddharth Gupta
2021-06-15 19:06   ` Greg KH
2021-06-15 19:06     ` Greg KH
2021-06-15 20:21     ` Siddharth Gupta [this message]
2021-06-16  5:56       ` Greg KH
2021-06-16  5:56         ` Greg KH
2021-06-23 21:50 ` [PATCH v4 0/4] remoteproc: core: Fixes for rproc cdev and add patchwork-bot+linux-remoteproc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75ce2563-3d34-a578-200d-8ec5f259d405@codeaurora.org \
    --to=sidgup@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=psodagud@codeaurora.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.