From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: patrick.fu@intel.com, dev@dpdk.org, chenbo.xia@intel.com
Cc: yinan.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed
Date: Mon, 20 Jul 2020 17:51:50 +0200 [thread overview]
Message-ID: <75dbcd56-26e8-93e9-d65a-1377d32b9ffe@redhat.com> (raw)
In-Reply-To: <20200715155848.9501-1-patrick.fu@intel.com>
Do you agree with below title?
vhost: fix double-free with zero-copy
Thanks,
Maxime
On 7/15/20 5:58 PM, patrick.fu@intel.com wrote:
> From: Patrick Fu <patrick.fu@intel.com>
>
> zmbufs should be set to NULL when getting freed to avoid double free on
> the same buffer pointer
>
> Fixes: b0a985d1f340 ("vhost: add dequeue zero copy")
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> lib/librte_vhost/vhost_user.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index df0db8a07..9ddeae362 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -1934,6 +1934,7 @@ free_zmbufs(struct vhost_virtqueue *vq)
> drain_zmbuf_list(vq);
>
> rte_free(vq->zmbufs);
> + vq->zmbufs = NULL;
> }
>
> /*
>
next prev parent reply other threads:[~2020-07-20 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 15:58 [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed patrick.fu
2020-07-16 8:23 ` Xiao, QimaiX
2020-07-17 3:19 ` Xia, Chenbo
2020-07-17 12:35 ` Ferruh Yigit
2020-07-20 15:51 ` Maxime Coquelin [this message]
2020-07-20 16:49 ` Ferruh Yigit
2020-07-21 3:18 ` Fu, Patrick
2020-07-21 12:10 ` [dpdk-dev] [PATCH v2] vhost: fix double-free with zero-copy patrick.fu
2020-07-21 9:16 ` Maxime Coquelin
2020-07-21 14:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75dbcd56-26e8-93e9-d65a-1377d32b9ffe@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=patrick.fu@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.